MIME-Version: 1.0
References: <cover.1676063693.git.andreyknvl@google.com> <923c507edb350c3b6ef85860f36be489dfc0ad21.1676063693.git.andreyknvl@google.com>
 <2085e953-ff9d-4d2e-cb35-24383592f2c4@suse.cz>
In-Reply-To: <2085e953-ff9d-4d2e-cb35-24383592f2c4@suse.cz>
From:   Alexander Potapenko <glider@google.com>
Date:   Mon, 13 Feb 2023 11:35:28 +0100
Message-ID: <CAG_fn=VHAJ4tyVeEv4ZUcP9eAt7+Teatgfu6APdEDM6J1jqGhQ@mail.gmail.com>
Subject: Re: [PATCH v2 09/18] lib/stackdepot: rename slab to pool
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     andrey.konovalov@linux.dev, Marco Elver <elver@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 13, 2023 at 11:20 AM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 2/10/23 22:15, andrey.konovalov@linux.dev wrote:
> > From: Andrey Konovalov <andreyknvl@google.com>
> >
> > Use "pool" instead of "slab" for naming memory regions stack depot
> > uses to store stack traces. Using "slab" is confusing, as stack depot
> > pools have nothing to do with the slab allocator.
> >
> > Also give better names to pool-related global variables: change
> > "depot_" prefix to "pool_" to point out that these variables are
> > related to stack depot pools.
> >
> > Also rename the slabindex (poolindex) field in handle_parts to pool_index
> > to align its name with the pool_index global variable.
> >
> > No functional changes.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Alexander Potapenko <glider@google.com>