Date:   Mon, 13 Feb 2023 19:04:25 +0800
From:   Jianhua Lu <lujianhua000@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523
 bindings
Message-ID: <Y+oZOXyE8/a+vreS@Gentoo>
References: <20230210161925.32343-1-lujianhua000@gmail.com>
 <6cffa875-d8cc-a4fe-e18d-2e24c28a49d8@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6cffa875-d8cc-a4fe-e18d-2e24c28a49d8@linaro.org>
Precedence: bulk

On Mon, Feb 13, 2023 at 11:45:23AM +0100, Krzysztof Kozlowski wrote:
> On 10/02/2023 17:19, Jianhua Lu wrote:
> > Novatek NT36523 is a display driver IC that can drive DSI panel. It
> > is also present in the csot and boe video mode panels. It is found
> > in Xiaomi Mi Pad 5 series.
> > 
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> >  .../display/panel/novatek,nt36523.yaml        | 101 ++++++++++++++++++
> >  1 file changed, 101 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> > new file mode 100644
> > index 000000000000..a7098d0ce7e1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> > @@ -0,0 +1,101 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/novatek,nt36523.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Novatek NT36523 based DSI display Panels
> > +
> > +maintainers:
> > +  - Jianhua Lu <lujianhua000@gmail.com>
> > +
> > +description: |
> > +  The nt36523 IC from Novatek is a generic DSI Panel IC used to drive dsi
> > +  panels.
> > +  Right now, only support cost and boe LCD display panels with the
> 
> boe? both?
Boe Technology Group Co., Ltd
> 
> > +  resolution of 1600x2560. It is a video mode DSI panel.
> 
> The binding or hardware supports only 1600x2560? The how it can be
> "right now"? It's defined, isn't it?
Yes
> 
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - xiaomi,elish-csot-nt36523
> > +          - xiaomi,elish-boe-nt36523
> > +      - const: novatek,nt36523
> > +    description: This indicates the panel manufacturer of the panel that is
> > +      in turn using the NT36523 panel driver. This compatible string
> > +      determines how the NT36523 panel driver is configured for the indicated
> > +      panel. The novatek,nt36523 compatible shall always be provided as a fallback.
> 
> Drop description. First it is free form text of binding, so unnecessary.
> Second, does not really bring any new information.
Acked
> 
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +    description: phandle of gpio for reset line - This should be 8mA, gpio
> > +      can be configured using mux, pinctrl, pinctrl-names (active high)
> 
> Simplify description - 90% of it is redundant and only drive strength of
> 8 mA is important.
Acked
> 
> > +
> > +  vddio-supply:
> > +    description: regulator that supplies the I/O voltage
> > +
> > +  vddpos-supply:
> > +    description: positive boost supply regulator
> > +
> > +  vddneg-supply:
> > +    description: negative boost supply regulator
> > +
> > +  reg: true
> > +  ports: true
> > +  backlight: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - vddio-supply
> > +  - vddpos-supply
> > +  - vddneg-supply
> > +  - reset-gpios
> > +  - ports
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |+
> 
> Drop +
Acked
> 
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi0 {
> 
> dsi {
Acked
> 
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        panel@0 {
> > +            compatible = "xiaomi,elish-csot-nt36523", "novatek,nt36523";
> > +            reg = <0>;
> > +            vddio-supply = <&vreg_l14a_1p88>;
> > +            vddpos-supply = <&lcd_vddpos_5p5>;
> > +            vddneg-supply = <&lcd_vddneg_5p5>;
> > +
> > +            backlight = <&backlight>;
> > +            reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> > +
> > +            ports {
> > +              #address-cells = <1>;
> > +              #size-cells = <0>;
> > +
> > +              port@0 {
> > +                reg = <0>;
> 
> Mixed up indentation.
Acked
> 
> Best regards,
> Krzysztof
>