Message-ID: <d4d7eb38-9b2a-fa41-0041-dc88d5b6f89b@linaro.org>
Date:   Mon, 13 Feb 2023 12:24:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550-qrd: add QRD8550
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Abel Vesa <abel.vesa@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>
References: <20230210163844.765074-1-krzysztof.kozlowski@linaro.org>
 <20230210163844.765074-2-krzysztof.kozlowski@linaro.org>
 <69bbabd1-2248-000d-f0ac-ba9bb4b14665@linaro.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <69bbabd1-2248-000d-f0ac-ba9bb4b14665@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/02/2023 12:14, Konrad Dybcio wrote:
> 
> 
> On 10.02.2023 17:38, Krzysztof Kozlowski wrote:
>> Add a minimal DTS for the new QRD8550 board - a mobile-like development
>> board with SM8550.  Serial, UFS and USB should be working.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
> [...]
>> +
>> +		vreg_l17b_2p5: ldo17 {
>> +			regulator-name = "vreg_l17b_2p5";
>> +			regulator-min-microvolt = <2504000>;
>> +			regulator-max-microvolt = <2504000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +		};
> 
> [...]
> 
>> +		};
>> +
>> +		vreg_l1g_1p2: ldo1 {
>> +			regulator-name = "vreg_l1g_1p2";
>> +			regulator-min-microvolt = <1200000>;
>> +			regulator-max-microvolt = <1200000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +		};
>> +
>> +		vreg_l3g_1p2: ldo3 {
>> +			regulator-name = "vreg_l3g_1p2";
>> +			regulator-min-microvolt = <1200000>;
>> +			regulator-max-microvolt = <1200000>;
>> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> +		};
>> +	};
> 
> [...]
> 
>> +
>> +&ufs_mem_hc {
>> +	reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
>> +	vcc-supply = <&vreg_l17b_2p5>;
>> +	vcc-max-microamp = <1300000>;
>> +	vccq-supply = <&vreg_l1g_1p2>;
>> +	vccq-max-microamp = <1200000>;
>> +	vccq2-supply = <&vreg_l3g_1p2>;
> None of these regulators have allowed-modes + allow-set-load,
> I think you may want that.
> 
> With or without that:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

It's something to fix also for SM8550 MTP.

Best regards,
Krzysztof