Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A9AAC636CC for ; Mon, 13 Feb 2023 11:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbjBML5q (ORCPT ); Mon, 13 Feb 2023 06:57:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjBML5o (ORCPT ); Mon, 13 Feb 2023 06:57:44 -0500 Received: from soltyk.jannau.net (soltyk.jannau.net [144.76.91.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51EA71353E; Mon, 13 Feb 2023 03:57:43 -0800 (PST) Received: by soltyk.jannau.net (Postfix, from userid 1000) id A0A4926F77E; Mon, 13 Feb 2023 12:57:41 +0100 (CET) Date: Mon, 13 Feb 2023 12:57:41 +0100 From: Janne Grunau To: Krzysztof Kozlowski Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Mark Kettenis , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/17] dt-bindings: arm: apple: apple,pmgr: Add t8112-pmgr compatible Message-ID: <20230213115741.GA17933@jannau.net> References: <20230202-asahi-t8112-dt-v1-0-cb5442d1c229@jannau.net> <20230202-asahi-t8112-dt-v1-2-cb5442d1c229@jannau.net> <5ebf96d9-689a-f915-29b8-31af891fc63f@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ebf96d9-689a-f915-29b8-31af891fc63f@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-02-13 12:10:36 +0100, Krzysztof Kozlowski wrote: > On 12/02/2023 16:41, Janne Grunau wrote: > > The block on Apple M2 SoCs is compatible with the existing driver so > > just add its per-SoC compatible. > > > > Signed-off-by: Janne Grunau > > > > --- > > This trivial dt-bindings update should be merged through the asahi-soc > > tree to ensure validation of the Apple M2 (t8112) devicetrees in this > > series. > > No, the bindings go via subsystem. Just because you want to validate > something is not really a reason - you can validate on next. Don't > create special rules for Asahi... or rather - why Asahi is special than > everyone else? We did that 2 or 3 times in the past without commnts that it is not desired so I wasn't aware that this would be special handling. Merging binding and devicetree updates together looks to me like the most sensible option since dtbs validation is the only testable dependecy of dt binding updates. Keeping them together ensures the dtbs validate without delaying devicetree changes by one kernel release after the dt-bindings change was merged. I suppose it works out most of the time if the merge request is sent only if it validates in next. That still depends on the merge order in the merge window but -rc1 should be fine. I'll consider devicetree validation as eventually valid from now on and not care too much about it. Janne