Message-ID: <570ab4b9-eed7-3c5a-400a-261a9a205b4f@nvidia.com>
Date:   Mon, 13 Feb 2023 14:24:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 2/2] vdpa/mlx5: Initialize CVQ iotlb spinlock
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     jasowang@redhat.com, si-wei.liu@oracle.com, eperezma@redhat.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20230206122016.1149373-1-elic@nvidia.com>
 <20230213071855-mutt-send-email-mst@kernel.org>
Content-Language: en-US
From:   Eli Cohen <elic@nvidia.com>
In-Reply-To: <20230213071855-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjlzRHpTSFRrUzhHcnZXNW1jTTgvR05VU1ltZDRMRTFLWG53bWFPVXBnTDBK?=
 =?utf-8?B?b29ib203YTBLUVdFTmMvTFFHRjI3elBST3JhZEQ2bmRxbSs1SHBBc0h6VzVV?=
 =?utf-8?B?dTFGTmd0eEY5eHl3S1ZGc3hESXJwSzVBekdkUnpWa3d3TG9xU2p6UmRCWGFh?=
 =?utf-8?B?ZWxhdE1qMFcybHVwd1NQdmhSUmNtdlBwZzNOVHluVXpYeHNtZGxMMHBteTFP?=
 =?utf-8?B?ZmdwOEhEUERBY1I4ZkhoSGhJWXdoQUtBaVB0ejhxaGt2TVNvQzFIN1JiS0hy?=
 =?utf-8?B?RnJlbmhjNXdJMlVSNXZyK20xcXJnTlorbHViTDc5U1hBeXlWNjh0enlZeUxl?=
 =?utf-8?B?endMSEVmYjZaTkJQQ05iMmlGWTg2NWIvTnp5S0ZsaGJldGo1RGZHaTlXSVpl?=
 =?utf-8?B?RXA5QjZtMllUQndCZUVrb1RHTjNwcFlKN2JGWnZmUTg2QUxiSTBSeEhYeHZ4?=
 =?utf-8?B?QlQwbFhQdHRVQ0JpRkFNejV2UkhXNEtBQmxRcE5uT0hJbUpwRllRWVM5M3FI?=
 =?utf-8?B?Z2pjckw3VGh1SUIyUU9wMWtWOFRaK2FLYTRQQ3NmbVRNbzZObUM3UElzWFBG?=
 =?utf-8?B?SDhTQzJpYkZJcHM4Y21TMUdyaHFSQWNDZkw3YWdMaVFEMGlmcXpERkJqY2Rs?=
 =?utf-8?B?NnNiM0NDcTFkMnNaQUh4Wk1sNkhwdnI1aEk2bTAyRk5xbjBqRG1JN1BUOHhh?=
 =?utf-8?B?SENIRXdObnN5K01udzdJUFpmVENOSVRibmlMdmlnbGNWbmx0S3JaSW1LRVZM?=
 =?utf-8?B?dEF3bS9aa1pJVHEzUHJnRzdjclN2VmNtVElDNkdSRTI2ckJpMVlQN0pHdEc1?=
 =?utf-8?B?ZTRXRStMb0FkbzlMMDRNbStVMnBDSlVQalF4TjBqTmh0OXk5L2svMStWUDZo?=
 =?utf-8?B?WTVaOFVEbkVGTEk3d2p4U205eTEyOVRSZFA5V0t1TE1NdGE5eWVSYWtlTkJz?=
 =?utf-8?B?bFYrdUFmV3AxZ3FiSDdWcU5pYVJDcWxweEFvdFBMcUYrakVZOElLME5hSXNt?=
 =?utf-8?B?Z1lnSHFtZUh3b3BqamVJYlpQR05DZWExek9YNSszdDFZZEdDeXBsZGJvQW5a?=
 =?utf-8?B?WmVvZndlMGZYVVdJL0xTY21GWTZKdXdTY1dlK3I0Z1hnUUkzZ2pBVzNvZHZi?=
 =?utf-8?B?ZGU4Q1ljQmRxQW54V1VvajByYXdyTmZiUFFDRWplQlRDaUVXejV4b0lQUjVO?=
 =?utf-8?B?WFBNZHlUakdWcUpXdm9LN3BCT294RmFKSGZpcHozZ0VKcnl1ejZ2b2JUQUpK?=
 =?utf-8?B?TlUyVjNrcHFUemJFL0xrWmF0SW5nTE5HMWdESk1hajJzN3phN0NTbGpmeW91?=
 =?utf-8?B?RVdwNklSRmhWTFBtdCt3U3IrN2Q0bU9VMXBmZGxIdzVHWVMzcHhOckhIMFh2?=
 =?utf-8?B?ZmNZTFN6R1JhNk1GalI3ZlJSb0x3eG9TaTg3Q2ZRZUpmRXVCNEw0bnZyMFl6?=
 =?utf-8?B?QUZpaExjeWp5RnFHdDJ0c2dPR2JWcHpYbkJFNzlhRHh2Q2p5N0lqUUJycTdP?=
 =?utf-8?B?WnpOeThPN2pWKzFaRTlyVlBYUkNKM0dwT3kyTHhNazliaW1LQnpXYTdTanVM?=
 =?utf-8?B?a0poVXdTZFZGTzZlTWV6RDZsTE91V3lZbUEzWGMzNTMxc0Vxc084N0JVZ3pE?=
 =?utf-8?B?ZTZCMEFLa0Q1cjVVUWNnZ3pmT3pHUC9XWnE1bzJ2cFNLOW9CU2docXF3VnFs?=
 =?utf-8?B?UnJXNHc1b0hjc1pIdzNpbXBzZTVmOWpxN2l0R2JTYVhBZmdVUXJQeVpTbmhn?=
 =?utf-8?B?Z0tmNy9Id0p6RkhMTy9WYmx6ZnBGRjJHY1JZNjBOYVRBbGdHUkRwTDB3WllK?=
 =?utf-8?B?SXlva0lGVktlQjVqU1dSbVI2NlhLQkFUeTk3eXBST01mM1had1NpYVNCQ243?=
 =?utf-8?B?b3J3MnpweGc3VndCVytHbVN3cjhTbzJxQTBIN0R4YjFVdlorZXRCa1RNSU51?=
 =?utf-8?B?d0xTdUwvTVQrZjY5NTlpckt1am5LMG1iWlVWY0hpN01IbGFDRktlalkxSVUv?=
 =?utf-8?B?Qmp3YUNLMjEyMjJ6dEMraW94TGw0SFFyV2QwWG94VDV4K281dmh2REcyVFRU?=
 =?utf-8?B?b1dEWmFHRVR2c3N2Z004dnVROW5jbkFLcXpYUWpIY1BCR1VlU2RyT05Sd016?=
 =?utf-8?Q?lvwxz2+x98qT4ZwehPAvPj01o?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4a36085-7673-4d34-aecc-08db0dbd4be5
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5400.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:24:47.9049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3AsBJdhErw3qbYtBVtLTgKJ+LVmFTekSAnmTD1iQV91xSauDjSI23kxGtzBC18kv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8342
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13/02/2023 14:19, Michael S. Tsirkin wrote:
> On Mon, Feb 06, 2023 at 02:20:16PM +0200, Eli Cohen wrote:
>> Initialize itolb spinlock.
>>
>> Fixes: 5262912ef3cf ("vdpa/mlx5: Add support for control VQ and MAC setting")
>> Signed-off-by: Eli Cohen <elic@nvidia.com>
> threading was broken here but whatevs.
What exactly do you mean by "threading was broken". Is it because I sent 
two unrelated fixes together appearing as patch 1/2 and 2/2?
>
>> ---
>>   drivers/vdpa/mlx5/core/resources.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/vdpa/mlx5/core/resources.c b/drivers/vdpa/mlx5/core/resources.c
>> index 45ad41287a31..d5a59c9035fb 100644
>> --- a/drivers/vdpa/mlx5/core/resources.c
>> +++ b/drivers/vdpa/mlx5/core/resources.c
>> @@ -233,6 +233,7 @@ static int init_ctrl_vq(struct mlx5_vdpa_dev *mvdev)
>>   	if (!mvdev->cvq.iotlb)
>>   		return -ENOMEM;
>>   
>> +	spin_lock_init(&mvdev->cvq.iommu_lock);
>>   	vringh_set_iotlb(&mvdev->cvq.vring, mvdev->cvq.iotlb, &mvdev->cvq.iommu_lock);
>>   
>>   	return 0;
>> -- 
>> 2.38.1