Message-ID: <0f304e2b-f49e-a3c6-9f8a-0061b7665e5f@intel.com>
Date:   Mon, 13 Feb 2023 15:03:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH bpf] bpf, test_run: fix &xdp_frame misplacement for
 LIVE_FRAMES
Content-Language: en-US
To:     =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230209172827.874728-1-alexandr.lobakin@intel.com>
 <87v8ka7gh5.fsf@toke.dk> <8d3a9feb-9ee5-4a49-330a-9a475e459228@intel.com>
 <87lel5774q.fsf@toke.dk>
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <87lel5774q.fsf@toke.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cC9SaTFQRDM2ZTlWVkFrc21nRHZXTmV2OWZLVWJYOTREOVRkYXd3MmxMQUF6?=
 =?utf-8?B?bGx5WGpHZHh6blFjM01UWk9BVTBxYnlCaE1MUzRzNmFvclFYZEZXZGlzZlQ0?=
 =?utf-8?B?WlpjQklHZkJPUnVrNXJBVnArL0QwYzhpdWptRHNUTVFxZWZRTFdaeFBTdkhz?=
 =?utf-8?B?YjlBcFNFeHRZY1F4YnozbmRYNkJGUXJRQ1c2WHFsSEVwVm03V3FCSWczMi9u?=
 =?utf-8?B?dkFqZ25BQmw0OFM0RS9hTGd6SlR0TWtoYW9UQlJhYzM0Ry95bUhjMW1qdkdT?=
 =?utf-8?B?VkZhNTRTS1p5WkhEVENYWVhBd0kycUpJU3hoNkxVWGcvR2hkSjVLNUlaSW1s?=
 =?utf-8?B?OVRpdFZ3WDFBb3pUQTZjK054eFlmU3JRY0IzK0ViZzdMbitmY2ZTUzZvVmFh?=
 =?utf-8?B?eUFvd0l4aEwzZ2dKMGVka3JEQjZGeFlkbDJJdEVnSWV1cDZJalFPT1lyYXA4?=
 =?utf-8?B?czBTdjlzRGsyQy9sdFJ1LzFxWXhCa1U1YmhFYktxUVJZaDgwWGM0Mi80eXYz?=
 =?utf-8?B?cVBSd1BydmlDOGdabmRjdzAxOExEeVhyclkrR2t5QWFkTWQ1a2FrV0w5MjFs?=
 =?utf-8?B?SXFZZ0dFRVY3R29VWWJXaWhmUm40UTM0ZXNOK1FQVWNsdWs4alhyOEJicUp0?=
 =?utf-8?B?cVF0VExNYWx5VTluZjlDeUY5eEpXRmZubDlSckZsMXVUekZNZDl4bm1hUFl5?=
 =?utf-8?B?SUtHcndQNE1nc0tXcnh0TGlBUHdnQlVYQjZyZXIxVjNqbHpiWmNvNE1IZ1p0?=
 =?utf-8?B?SmVPa0ZIclIxMzdNKzlQMG16KzdwKy9TQXpJZUxrYVpmSi8xamI1cDBiTFhZ?=
 =?utf-8?B?WVdZQUNlR1dHN1ZTN20xcXNCRytaRmpWUHFEZkIrUW9KU3Fjb05mUFcxVWtF?=
 =?utf-8?B?UWhWek9kdnR0bmJ2dmdLbFEzWWdOZTZhWTdYN1BueUltVEh3M2EvRWM2aUJ5?=
 =?utf-8?B?K2VQbEE2ZU9TK05BV1VBMUZzeEJQQU9Qa3VydzNUdVFrSGM5MG5FVm45ZmQr?=
 =?utf-8?B?emt6MVNRNEtNTDJ5ZzBhMUIwTTlQWWswbTd3dGREVHNzajNUeFBycG9LYjQx?=
 =?utf-8?B?ZHFtZjZDK2lpU1dNTXNNdExUTzMrbHhxOExsZkhqaDVRSVR3Sk9pUmhOMCtQ?=
 =?utf-8?B?NE0yTmh4Sk9GZFFmSTIyNDR0NVIxWVdicCsrajlLbEdpbkt4ZHp0WTJ6aVI1?=
 =?utf-8?B?bEJTRTdHbDZHRkxFZHZpREh3bGk0eTAvc3QySTI2cXZjeVYxTVJaWlE2aE5i?=
 =?utf-8?B?YmhUR1dZYXVmQjBjNExjM3pJSkZscUkxemE4VEloUTNVT2o5RTM0aXFVTG00?=
 =?utf-8?B?L2oxcldKaHBtM0h4V3VzUnYxM2NZYVAwcDB1UnpPd3VPSWVDMWl1dGtGYS9i?=
 =?utf-8?B?WXRQUU55alFqQU1nZnRObXoxL2JyNVNldm9UVmRVaFpiN0lkeHhZM0JtL2tt?=
 =?utf-8?B?aFNnaWZkMFIrSWlIaHFvQ0dLNCt4cWlaN0lBVThGWkFOcDI1cDFqOHp0VlFH?=
 =?utf-8?B?dlVMREFjN2NkWjJVLzVYd0FYSE40aVJhbG9aU2M4OWZjdTVWZUltOVRPVTVw?=
 =?utf-8?B?SUMyZUd3SngweEdBaHhoRGwxa2tkc2w0TFBWOGpqVkQ5NzMwbklsUndjV0NR?=
 =?utf-8?B?WkM3MTgybjUyTUp1QjY3R3ExY0NGQ1c2MFY1ck82R1E0K3hEYkpEek83MnlT?=
 =?utf-8?B?clFyUG15MUJnWG1tVmZOdSttRXdGTzRPcjFMbndHL1hEM2ZCSmMrdFdTcUNR?=
 =?utf-8?B?cUIxc3d1ZmFiMnlaU3lQWGVqNXBKV2RvazM1ZmMxbEE4OUJmWDM3Q2pEMVU4?=
 =?utf-8?B?Wko3YnlBbnB3ZHFuVExNc3lsS01VS3NxckF3VE01SGhRb242VnprZ2NoRHQr?=
 =?utf-8?B?akZpY3czaUludWVrNEg1S1JMbHZXTGQrNEZvRU9LREk4VSs2dUQzYmpRM0dG?=
 =?utf-8?B?OWNibjlVUFJ2K1dwcWVzZ2drdHNKUEVnQ1M5bHJZcEZMcGgxTHl0aXNMOGdq?=
 =?utf-8?B?aVU5V09mc0JJZ3RaUG4yNnE5SlVTMVZPWE03ZVZPYkoxUmI5NmY0WjZUM2FS?=
 =?utf-8?B?SWU4dFVtSnhrK1duOHVOWDlwZEhkamk4bEFPbW1zaW96RDhzcklKT3M4bkdy?=
 =?utf-8?B?RGM2MlpDdjBSSEtUS2RrTWlGNXZ1M1o4QkJLd0pkb0xpS09QdTVuSDJWUlF3?=
 =?utf-8?B?anc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f5911714-9730-497c-9d72-08db0dcb2eb5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:04:11.9358
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M2cjqCXXNN4S7HJvxa/JUQRxIi620SRHwok75rZ9hBRycCdlOv7gUdZALSM8BhUPfJP8ToWmiLdD6z94cqid9IYw2Z3nEWfqakTzRiYctLU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7402
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Toke Høiland-Jørgensen <toke@redhat.com>
Date: Fri, 10 Feb 2023 18:38:45 +0100

> Alexander Lobakin <alexandr.lobakin@intel.com> writes:
> 
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>> Date: Thu, 09 Feb 2023 21:04:38 +0100

[...]

> both of those assignments refer to flex arrays, which seems a bit
> inconsistent. The second one works because it's assigning to a void
> pointer, so the compiler doesn't complain about the type mismatch; but
> it should work with just 'data = head->data' as well, so can we update
> that as well for consistency?

Aaaah, I see, you're right. Will do in a minute.

> 
> -Toke
Thanks,
Olek