Message-ID: <632e5aa9-6b0a-032f-27db-3cbda6c66d7f@linaro.org>
Date:   Mon, 13 Feb 2023 15:38:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm7225-fairphone-fp4: move status
 property down
Content-Language: en-US
To:     Luca Weiss <luca.weiss@fairphone.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230213-fp4-more-i2c-v1-0-5be09dbb5ce6@fairphone.com>
 <20230213-fp4-more-i2c-v1-1-5be09dbb5ce6@fairphone.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230213-fp4-more-i2c-v1-1-5be09dbb5ce6@fairphone.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13.02.2023 14:26, Luca Weiss wrote:
> Currently the dts contains a mix of status-as-first-property (old qcom
> style) and status-as-last-property (new style).
> 
> Move all status properties down to the bottom once and for all so that
> the style is consistent between different nodes.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 34 +++++++++++------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index f7602e93121a..86114dd2c0c4 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -110,8 +110,8 @@ active-config0 {
>  };
>  
>  &adsp {
> -	status = "okay";
>  	firmware-name = "qcom/sm7225/fairphone4/adsp.mdt";
> +	status = "okay";
>  };
>  
>  &apps_rsc {
> @@ -355,13 +355,13 @@ &cci1_i2c0 {
>  };
>  
>  &cdsp {
> -	status = "okay";
>  	firmware-name = "qcom/sm7225/fairphone4/cdsp.mdt";
> +	status = "okay";
>  };
>  
>  &i2c10 {
> -	status = "okay";
>  	clock-frequency = <400000>;
> +	status = "okay";
>  
>  	haptics@5a {
>  		compatible = "awinic,aw8695";
> @@ -396,8 +396,8 @@ &ipa {
>  };
>  
>  &mpss {
> -	status = "okay";
>  	firmware-name = "qcom/sm7225/fairphone4/modem.mdt";
> +	status = "okay";
>  };
>  
>  &pm6150l_flash {
> @@ -423,11 +423,11 @@ led-1 {
>  };
>  
>  &pm6150l_wled {
> -	status = "okay";
> -
>  	qcom,switching-freq = <800>;
>  	qcom,current-limit-microamp = <20000>;
>  	qcom,num-strings = <2>;
> +
> +	status = "okay";
>  };
>  
>  &pm6350_gpios {
> @@ -441,8 +441,8 @@ gpio_keys_pin: gpio-keys-state {
>  };
>  
>  &pm6350_resin {
> -	status = "okay";
>  	linux,code = <KEY_VOLUMEDOWN>;
> +	status = "okay";
>  };
>  
>  &pm7250b_adc {
> @@ -535,21 +535,21 @@ &uart9 {
>  };
>  
>  &ufs_mem_hc {
> -	status = "okay";
> -
>  	reset-gpios = <&tlmm 156 GPIO_ACTIVE_LOW>;
>  
>  	vcc-supply = <&vreg_l7e>;
>  	vcc-max-microamp = <800000>;
>  	vccq2-supply = <&vreg_l12a>;
>  	vccq2-max-microamp = <800000>;
> +
> +	status = "okay";
>  };
>  
>  &ufs_mem_phy {
> -	status = "okay";
> -
>  	vdda-phy-supply = <&vreg_l18a>;
>  	vdda-pll-supply = <&vreg_l22a>;
> +
> +	status = "okay";
>  };
>  
>  &usb_1 {
> @@ -562,26 +562,26 @@ &usb_1_dwc3 {
>  };
>  
>  &usb_1_hsphy {
> -	status = "okay";
> -
>  	vdd-supply = <&vreg_l18a>;
>  	vdda-pll-supply = <&vreg_l2a>;
>  	vdda-phy-dpdm-supply = <&vreg_l3a>;
> +
> +	status = "okay";
>  };
>  
>  &usb_1_qmpphy {
> -	status = "okay";
> -
>  	vdda-phy-supply = <&vreg_l22a>;
>  	vdda-pll-supply = <&vreg_l16a>;
> +
> +	status = "okay";
>  };
>  
>  &wifi {
> -	status = "okay";
> -
>  	vdd-0.8-cx-mx-supply = <&vreg_l4a>;
>  	vdd-1.8-xo-supply = <&vreg_l7a>;
>  	vdd-1.3-rfa-supply = <&vreg_l2e>;
>  	vdd-3.3-ch0-supply = <&vreg_l10e>;
>  	vdd-3.3-ch1-supply = <&vreg_l11e>;
> +
> +	status = "okay";
>  };
>