Message-ID: <6c97dcd6-89fe-89b6-ed58-674810ae5fa1@intel.com>
Date:   Mon, 13 Feb 2023 15:53:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH bpf-next 0/6] ice: post-mbuf fixes
Content-Language: en-US
To:     =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        "Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        "Song Liu" <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "Jakub Kicinski" <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230210170618.1973430-1-alexandr.lobakin@intel.com>
 <87fsbd75pz.fsf@toke.dk>
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <87fsbd75pz.fsf@toke.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVNzYjFWZ0Zjd0ptVXZxL1FmakxEclZXQzlxQUsrMmgrM3RhOEdpOTk0OUZp?=
 =?utf-8?B?R2E4R0tZMlFLR045UFRSNG8wSXpqNGlsQUVnZkxjOVV5WHNvdkNuTmkyeEZN?=
 =?utf-8?B?b1p4TGJ1Nk40SlN1K216aE9NbFNqOFZaTkcwZ0FDTDJUclNMbGNSN3NJZjVM?=
 =?utf-8?B?Y0JCUkNLeXlZRTdxT0ZPK3lob2ZZQ0JYU3dDa3ZiTDY2SnFJQTU5RTZkRllp?=
 =?utf-8?B?M3Q3SUJnR0x4Vk1pbWxOaGpYOEtYUTh0REdWQXVvOUZRaE9lVHdRQ09kaDF6?=
 =?utf-8?B?bXVyc2tRSnNZRGlyTXFITW84ZWVrRmlXVjEwZ1NHRlNzdWY2eUl0dzNoUUM1?=
 =?utf-8?B?SnpDNGhEMVJNb1FBYUJmTFZ3YU1VRWxWY3FiTm9EV2x2TEVqZ2Vydy9vbUM3?=
 =?utf-8?B?NTIxR2tBcjRBcllrUm5XNXNUWFhMZEQ4L3pNcTZpQXFFdHpZR3o0eGJ3WFc3?=
 =?utf-8?B?YTd4MHRFazdDaDlaR1ZEdkdJWnRvZ2xjMy9odkNSUEt6ZVdWWmphUG1xd1dY?=
 =?utf-8?B?VXJkMHZRQmgrWUl2b1R2MFJTc214U24vaHN3VkgvYUZad3ZZUmt4S05neC9o?=
 =?utf-8?B?aFVwRGhrNExveEp6TkVUUWVvOHRUOWVjN0V6T29LSXBSVHhpZEpWalA2VVVx?=
 =?utf-8?B?MlJ3eTNUWVF6SlFkV0YyV0plRi9SbjlCOTBhQ2ZqbGVCaGR2MDZjNVZNZ1RX?=
 =?utf-8?B?ZTY1dHVpQlU1YjVIZ3pJUnFWb0pNL0k2WlZsVUtjN21QNTJGb1RmT2ZzNFM2?=
 =?utf-8?B?WENTU2JCRkZJR254K2V3TGdad01MNWUzaVc3eFRCTmJER0d3R1B5U005STNF?=
 =?utf-8?B?MmdCVGhaM2Mzek4zZnRKWjNoOGo4UWJkMlpleWtoY21NZHVFc014UUZsSytj?=
 =?utf-8?B?cWprRGcwQlFNSXQ0cUhrMDgxN1Vmem51akhtQlBKb2xwNXBiVjNtRVZES25N?=
 =?utf-8?B?K29sV2pTb2ZSa09BRHBtYjVsOXhEVUhSUlkweXh2R1RndDFtWlA1YnNXbDhO?=
 =?utf-8?B?dVZWUXhCdVUyTkVZRGJiODlPbnluaDV1Q0NoRmtUN1hQNFUzNDF6ZnNMbG5T?=
 =?utf-8?B?NnUwYWpnSzlCS0hIOVlQR0tiMUl5TWtXeXdsOElPTVhCckhxYlZKa01MYWxE?=
 =?utf-8?B?Q3djWVlOVjdLaTZ4UzFTQmtZa0RPN254NmhIYXZnK3hLaWpycUVxdkppRldN?=
 =?utf-8?B?aVIvOWNUVy9KdmNPWTBDbEJEZWNYc3dod0hKU2k1Qk5IRU1yN1dDY3ZMOElK?=
 =?utf-8?B?dHY4Wkg2U1Y2eU9aVVU4RVRyZC93TWF1K1lFY2ZXZkt2czVIYkkxS1EvZWhx?=
 =?utf-8?B?bWNHNEN5RHpsazB3OStLRWRmdDZJbG9ac0JyT2MyU1k1bTd4ZnloOUlQVDZo?=
 =?utf-8?B?UW9idGZFWDF6SjZaelIvSXVkazc4d2ZhQXNaRGlUR2MxNFVFMzMrNG56Wk9G?=
 =?utf-8?B?dlpGaXdDL2IwY2k4UG00ZzBYV1NVUVdpZXZIQXRaanhtVkMyMXd1YkN3SU9O?=
 =?utf-8?B?U01lUytuWVlHOThmL2VYbW9vbWIyNStEYU9uYUc0dXBaN1pHazZleG56L1Vu?=
 =?utf-8?B?cml0WkRYVGh6eTNlNE0vNDhlcmVEZmp6bzFzd3QxSWVFQ2pCUGR6am9SSkY1?=
 =?utf-8?B?M2JDcitRTllpV3NNSCtDTEFULzJjMmNGVHdLZCt3NmpSU1dJOFc0NE5ObzJm?=
 =?utf-8?B?RnhJV2NtZmtGZ3BRTUJtbiszOHhFcDN2Ky9UamFaNVluZHA3V1RIc1NmQkxH?=
 =?utf-8?B?ZmowS1B1aFVDMDI2ZHAvYTIwNndWMkgwdkxRS09JVU5GZkh5eFZzbTV6NVpr?=
 =?utf-8?B?LzBwYllBYWoxRTk1ME9JMXdlSHJuZnFwY0F6NDZxL0RlUyt2QjdmYjh6QUpp?=
 =?utf-8?B?T2E1K0N3bXBuNEh4Q0ozcFcxeFZiSnJ3Rjc3ZXdXcGQzYTR4aTAzbldhdmdD?=
 =?utf-8?B?QzJoMG53TTdvZ0ZMN1NHY2dCUnFyY2VrS2I0bGxobFBhV0ZuL2NSaEs5R3JO?=
 =?utf-8?B?MjJiT1MyT0duaHZCdVhhQWJja1E1ZU1uQW1OKzFweDRpWUxSZzVzZEE4Ylpv?=
 =?utf-8?B?NlZ2dGQrdGJPNnpXanBpdndHS1JTY1pnN0o3eklKQVF4S2VNczNRSDFObmJL?=
 =?utf-8?B?Sm5vTnZVbUM2MnF2NEE2eCtvZGpNYkFJTnZ3M0xqMXpheVhuUEhPODk1MkNh?=
 =?utf-8?B?REE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1656adae-cc4e-424a-fa20-08db0dd228c4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:54:08.4004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3WF42oa0Guy91frSGL+ITPBnBoUOEl2k542ID+uP+ASZ9jCSHLHX0EAQXl3q9WQtPhhE8TahBB+TaBmn6iIyx1ig3JzV3SP9OXdL8UO1aXw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6782
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Toke Høiland-Jørgensen <toke@redhat.com>
Date: Fri, 10 Feb 2023 19:09:12 +0100

> Alexander Lobakin <alexandr.lobakin@intel.com> writes:
> 
>> The set grew from the poor performance of %BPF_F_TEST_XDP_LIVE_FRAMES
>> when the ice-backed device is a sender. Initially there were around
>> 3.3 Mpps / thread, while I have 5.5 on skb-based pktgen...
>>
>> After fixing 0005 (0004 is a prereq for it) first (strange thing nobody
>> noticed that earlier), I started catching random OOMs. This is how 0002
>> (and partially 0001) appeared.
>> 0003 is a suggestion from Maciej to not waste time on refactoring dead
>> lines. 0006 is a "cherry on top" to get away with the final 6.7 Mpps.
>> 4.5 of 6 are fixes, but only the first three are tagged, since it then
>> starts being tricky. I may backport them manually later on.
>>
>> TL;DR for the series is that shortcuts are good, but only as long as
>> they don't make the driver miss important things. %XDP_TX is purely
>> driver-local, however .ndo_xdp_xmit() is not, and sometimes assumptions
>> can be unsafe there.
>>
>> With that series and also one core code patch[0], "live frames" and
>> xdp-trafficgen are now safe'n'fast on ice (probably more to come).
> 
> Nice speedup! And cool to see that you're playing around with
> xdp-trafficgen :)

It's not only good for bombing receivers without any special HW, but
also for uncovering problems with XDP in drivers and/or kernel core,
as I can see :D

> 
> -Toke
>

Thanks,
Olek