From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v3 1/3] serdev: Add method to assert break signal over tty UART port
Date:   Mon, 13 Feb 2023 20:24:30 +0530
Message-Id: <20230213145432.1192911-2-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230213145432.1192911-1-neeraj.sanjaykale@nxp.com>
References: <20230213145432.1192911-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SfjVkUIfkJ3o3jLGTrmf2fDyMQG0z9xHd80HNeZhCeTHbw1Vj/4L1y9MmG8y?=
 =?us-ascii?Q?EQhyLKtqPI/QHnryNw91jxnMsOyQbIVzieX7HbZpM425bUSAJj9z149+6bMn?=
 =?us-ascii?Q?LpZRSsdel8fx6pVv3lpXAJCMJrt/3E4p/sP7oF+L1bOEpDiNsHxnw5Pgc4c6?=
 =?us-ascii?Q?uTNh0sP+j+SkHVffveKXaqdVzhLU5MWTwO9dIZYbH50MznZp+vUPqHs/fPjI?=
 =?us-ascii?Q?kTHukqcWUTqQBLBg2tkcUK19+vHtSzZiSiR6X52p2+cq0Qb4ZHEB1k59KiY8?=
 =?us-ascii?Q?l886ZjGPqYD+LWiIS8m3/t4+7eaZ6aLuuwAbzFgX+KTH/qziC2NflKbylBJ5?=
 =?us-ascii?Q?utdcOrfAGAf9tB8BLikybK5PAkCKaxR4ppyKkWMRNvBGWHEoorfDFJapPHgq?=
 =?us-ascii?Q?VAL1NBbCj06zwry/VF5q/UWg4M+gQw5NzXWXt2Dd8Q8/GkuH9pnpi9WQL5E0?=
 =?us-ascii?Q?AZ68RVRECw6zFkli+EKLFh8hPSxMpkR9PiMUVg4RLyMSJBq3iXR5Jm2iFVen?=
 =?us-ascii?Q?e1syTO9mUbv0XaB1yE5pdb7qbLLx7GxkjxgSmtqgW+KCGNEfuAhVkQ8Dj90S?=
 =?us-ascii?Q?mw4P+jHORhRRM+mMMiGhTZsDGL/xh6QUAiy3h4gOIhddBr//Jb60cqjC1K92?=
 =?us-ascii?Q?s9DhQ0P19bQN5BjJrUtuZz7bE/z7RzAcXsq4Q/cEpPiOGqWHOGF87R3KYcCJ?=
 =?us-ascii?Q?smRJIVKy2x7On97Pvd7N0rEcHAgDNQ/vPGN7/7YpIPEoQSfN57QmVChf9ntQ?=
 =?us-ascii?Q?puFQ/VaYoeuOtE16YN7Rs0rwUloVBoZSXcW3VVn2PbYL0FWNfunvnGYu4a+E?=
 =?us-ascii?Q?brYb0CsNpnc1t+FbWlBIb+89RSLpr/2lpnhaHzIUwFggwKAUBQx0UBg5Xduv?=
 =?us-ascii?Q?NxqQguTwIhjw2pnSkD8kNg6V8rlXMdf7pUV1Fv4yKDip69KLE6LSq/UogBWx?=
 =?us-ascii?Q?Bdz4I5p76vO4eJ2el6J2yZ2VcqvzvXkHc0iCLKrENKL8LCWEDkmPhrDGqROX?=
 =?us-ascii?Q?DEp9ulwKF+EhhYFq57RiYNB6RCf454Fb1eTEziSKMi1I6zx8xzux4md3Yxtd?=
 =?us-ascii?Q?7M78CYbKfIGfH+98fcZw/pwjNmhU6OzfAJVXE/Zw77WifKeHQEqs6CruN7Ka?=
 =?us-ascii?Q?Tk4tLSmCiJPkG1Q8pKvycxk3zLjNKtWEkTTy4nq9IhP+rcjGMY5ZQTKn0/N8?=
 =?us-ascii?Q?jr5F/S9sIoAz6kCZSvGI77NjQh57HPlKR4E0bucD2md1a6wyDIJJ0P9IVmCR?=
 =?us-ascii?Q?X43a2CAa5PeaBw3MrY/Cyfo2pspmhpA4eAD19kTI0JubN4tQrIg3MUqF015k?=
 =?us-ascii?Q?J4iOz/k8rP4ywrur6ka8uAakV9hvJIVXHygd3STo6MaojADusvFhoCxzknLD?=
 =?us-ascii?Q?ZyaOQ6vEMpXF+eysIJFlNaJyVE8ER6DFYqwUlhvtd83PGwxqt2HEpgHmQHpI?=
 =?us-ascii?Q?RS5eXT1kJWKq0f8BeqIXq64eivlTqpdSNlyCvj3P6RY74B3BbnRwgGGZhNp5?=
 =?us-ascii?Q?0kqZPCqX3SGHvAYUtcVbuB54ir+WifWzyqDElZOVKY7n5/JGiSE3w9RNxfqq?=
 =?us-ascii?Q?0frJkdzEF1SZHPXWmR8fQMJCnLD1AIco53ms8EIapQaqEFnnlB5J7Ag+C1MT?=
 =?us-ascii?Q?qg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35c3e598-986e-4fe9-e625-08db0dd25610
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:55:24.3654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tV6R+r95Alpj//Sqn04guwDQ3OMG/YS9urmkBe1n8aaZO7+TrURy9p7g/KQ2zwjdbNQi5qZtDVVpzZNpl/keOuJHLA1UMinKhVgzWc9cw+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7523
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message (Greg KH)
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 29 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 0180e1e4e75d..f2fdd6264e5d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..9888673744af 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,17 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +270,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -ENOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1