MIME-Version: 1.0
References: <20230210022839.3152-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20230210022839.3152-1-jiapeng.chong@linux.alibaba.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 13 Feb 2023 11:15:28 -0500
Message-ID: <CADnq5_OaFqucwsJwm5CCQw=R5CpKnnWFDvp_M0=hutEKAbA0Og@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Remove the unused variable ds_port
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     alexander.deucher@amd.com, Xinhui.Pan@amd.com,
        Abaci Robot <abaci@linux.alibaba.com>,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Thu, Feb 9, 2023 at 9:28 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Variable ds_port is not effectively used, so delete it.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capabilit=
y.c:280:35: warning: variable =E2=80=98ds_port=E2=80=99 set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D4030
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  .../drm/amd/display/dc/link/protocols/link_dp_capability.c    | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capabi=
lity.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index 24d356ebd7a9..816bf4ff8017 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> @@ -277,7 +277,6 @@ static void dp_wa_power_up_0010FA(struct dc_link *lin=
k, uint8_t *dpcd_data,
>                 int length)
>  {
>         int retry =3D 0;
> -       union dp_downstream_port_present ds_port =3D { 0 };
>
>         if (!link->dpcd_caps.dpcd_rev.raw) {
>                 do {
> @@ -290,9 +289,6 @@ static void dp_wa_power_up_0010FA(struct dc_link *lin=
k, uint8_t *dpcd_data,
>                 } while (retry++ < 4 && !link->dpcd_caps.dpcd_rev.raw);
>         }
>
> -       ds_port.byte =3D dpcd_data[DP_DOWNSTREAMPORT_PRESENT -
> -                                DP_DPCD_REV];
> -
>         if (link->dpcd_caps.dongle_type =3D=3D DISPLAY_DONGLE_DP_VGA_CONV=
ERTER) {
>                 switch (link->dpcd_caps.branch_dev_id) {
>                 /* 0010FA active dongles (DP-VGA, DP-DLDVI converters) po=
wer down
> --
> 2.20.1.7.g153144c
>