Message-ID: <f819ed93-67fc-d052-36af-142c0c09683f@kontron.de>
Date:   Mon, 13 Feb 2023 17:15:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 6/6] arm64: dts: imx8mm-kontron: Add support for reading
 SD_VSEL signal
Content-Language: en-US
To:     Marek Vasut <marex@denx.de>, Frieder Schrempf <frieder@fris.de>,
        devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>
Cc:     Fabio Estevam <festevam@gmail.com>,
        Heiko Thiery <heiko.thiery@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
References: <20230213155833.1644366-1-frieder@fris.de>
 <20230213155833.1644366-7-frieder@fris.de>
 <7b1a8b7d-2269-7ff2-d480-ae5de8c4cc4e@denx.de>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <7b1a8b7d-2269-7ff2-d480-ae5de8c4cc4e@denx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHljWXFrS0hBcXkrTW44ZzNEdmMrRndOcEQ1N3dNdkZ0cVZvTGhJV3RQRDJO?=
 =?utf-8?B?MWJlMllBelRUQlJ3a0lidGZaL1JIZ0U1QjhkTC9aUWR3eWpZSHFaVmpNSzVJ?=
 =?utf-8?B?eFo1eFB5RHFETWZINFBQSWFKdjJvYVlNeFRkQVpFTDVPRGxUNmJxZEpVL0FD?=
 =?utf-8?B?TVIyRyswVWR2Y2NLVUgxUUpweHpmc1NLNkJsZ2ZpOXNsNlBEYk9ZdHRCVTA5?=
 =?utf-8?B?Y1IyTkZaQmpwUStyeFRKRXQyQ2YzMXhmWkxQakZibGxzV0xCUjZWbEkzVnF6?=
 =?utf-8?B?UWFnbVFOQUJBcjc5bFFoYXFLanpUazZ0aTFwSGV1c08vaUFGOUZxck4yR3dQ?=
 =?utf-8?B?NWdvU2pEb3JFZkZDbXQvM1pMV0gyaFgyak9UYXNXL3gyRk15YVdDUVNCRkFx?=
 =?utf-8?B?K25wZ1JkdEtCQ01lTld6OXhrMTlpWm40c2RIVEpWZWMwbUdwZFpWbGJLYlN4?=
 =?utf-8?B?a3E3c05BeVppcUNZYWRjNnZtTVpjWWZNYXpKemZ4NFBFQ0R2NkdBdDJWZ0tF?=
 =?utf-8?B?bG9lRTVmdDQxWXhpWFBjZmNFeUFITUpZdDRYWnY2b2pLSjJUOEd2Tko2bWJK?=
 =?utf-8?B?aUVaRTJudHRVM3k4bm1wSTQvMXhsM25ITFUwVURpUTNDMEVUbis5RjlzNDBh?=
 =?utf-8?B?dkJRU3FmNFB3czJUQTNMYVB1NHE1eXJUUjhhbGd2NldlaDFab2xHK1dibkNU?=
 =?utf-8?B?U05PVG5wZE4xOU9zdDRqd1dxbHBFQkgxWUUwWkZPeDNrZFdrdlVaNHNCZGJH?=
 =?utf-8?B?cnVJZktEUjhLUzZ5aVBBcXpBS0RyZ0hpTmY3dm5ZSFJJYlFhZlB4cThnZEV2?=
 =?utf-8?B?LzBBYmZLaWZBSCtZeGNrUURQa3NCVFRjbFhqK3FuUUhUZVpDMkw5L1dDQXVz?=
 =?utf-8?B?OGVmUWdkSW9hM1pGZXg3K3Jpc0lQeDdGK284SDhIbjh0QjVPV1FjY215M3lZ?=
 =?utf-8?B?azNSbGNMd3NCYVBuVjFYYzV0WklhVk1jWkcydGhPMDM5Z0UybU9jWms1dXBL?=
 =?utf-8?B?cWVuWEU0Vm1SVnZVbkVCd1pNbDQyWW9EbU5ickFadDNyVTBEK0cvWFpzb1E2?=
 =?utf-8?B?bFRXK3E1b1F4bkdzY29jN1hZY2VnNVkyM0s2UXI0Zy9IczR5OStuRkFzQTBE?=
 =?utf-8?B?UzROMlE1MUxKMWROdG1Yd0t2S1JwTys5ZSthK0JLTEp2VHFtRWx3QUw1YldX?=
 =?utf-8?B?elFTdVdya2lFZHo3WGlyVGgzNEUvVDVWeHFvd3NsSHpiUHhTSStRSU54QnhR?=
 =?utf-8?B?UmhnejBWNmcwck5ORmpmUGpyaHZpVzdZekE3dzF2bEs0L3c3eG4zY2htTEIx?=
 =?utf-8?B?SzJiSjJDNnJEek9QZlhzSmMxMGxyZXMvQVB0OUs2M2hISlArdUFCNnRLbUkw?=
 =?utf-8?B?ZlRwZ0NPTWRpdGc3M2IrU2pacEJEZGhLV3BDMG94MDFZcnlqak5XNSt4MDVF?=
 =?utf-8?B?L3dqVnd4eGlTWFc3MVBCMldka1E4WE1LTVE5WksrZk1ZR2w4TXd2WDh4bGlh?=
 =?utf-8?B?cTd4a1lBL2VpVmxLcnoycy9Dc011aXBrZ2FvTzhIUUc2RG1jckI1Q1ZwKzhw?=
 =?utf-8?B?TnlZdEZNbEdxVzhhK2VjbCtaVmRnSEJvNUJCdDNGMlhhVzFNM1RBRkFJbzFR?=
 =?utf-8?B?YWtJcjdWblM0TytSbjFMZ3BBU3JLQW1jRitsZ1Z2MzVnR2xIMXpQZnIvY1Vj?=
 =?utf-8?B?TjNuMjN2WTNlVldzMklyQjRySlA1VjNRcUU3VlhEL2dkT0I4OGFYc3cwZzhD?=
 =?utf-8?B?ZTFmd3lzR0lYbXRzekF1K0gzUTQxZG82TzhxR3cyWW1USENXZThWVTQzK1o5?=
 =?utf-8?B?SVZiZys0akJ5SGczZWoxNGh1em9QVzVFYWJIYnlTczVvYUU4clM5RlhKdFQv?=
 =?utf-8?B?RXE5U0FxRmxBUHBpWG5yZ3pxSzdOdVZMbUppMkpwOGVUVzhpb1l5bW9nMjdJ?=
 =?utf-8?B?QmJuMWhtQXVHMmx0cTN3alcvUWhIdlh3WE5PcVN5V0tRaDJIUmRJMUFkQUxr?=
 =?utf-8?B?L3ZsV1I2QjFzTGdnQ1hSbFVNOGt2T2twOHc3ZmVPK1l0ZjgxN2xmVFRiMkFB?=
 =?utf-8?B?TTc2SDdGQnp0UTR6SnFzYVMyNVhPTExISlBPSVY1RjVGSXZ2RUdyT0VBU29l?=
 =?utf-8?B?c0Era0VLellNdDFuTTRudkZJSW4rRE1BU3lkajZBaUJHOUlKc2pWa29Zd0h6?=
 =?utf-8?B?SGc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: b01e8ddc-e853-4ed9-245b-08db0ddd910e
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 16:15:47.7019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jRXaUXGxkejcFUh7l7eO+AdrqkadGKvllDs2dhkVxNocYOGDS2nxbdOPryr18szDBkYIl03KVXsh5Vzpycoy+w8K8vBfR+9PmS8s1QI59W8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13.02.23 17:08, Marek Vasut wrote:
> On 2/13/23 16:58, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> This fixes the LDO5 regulator handling of the pca9450 driver by
>> taking the status of the SD_VSEL into account to determine which
>> configuration register is used for the voltage setting.
>>
>> Even without this change there is no functional issue, as the code
>> for switching the voltage in sdhci.c currently switches both, the
>> VSELECT/SD_VSEL signal and the regulator voltage at the same time
>> and doesn't run into an invalid corner case.
>>
>> We should still make sure, that we always use the correct register
>> when controlling the regulator. At least in U-Boot this fixes an
>> actual bug where the wrong IO voltage is used.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> I may have a kind-of obvious request, since we removed those SD_VSEL
> very recently from other boards, could you just revert all those patches
> and only fill in the SION bit in V2 on all those boards too ? That way,
> we fix the LDO5 regulator for everyone who used it before.

I thought about that, but as the SD_VSEL signal is controlling the LDO5,
I found it more useful/correct to have the sd-vsel-gpios property inside
the LDO5 regulator node. Therefore the old usage where sd-vsel-gpios was
inside the PMIC node isn't compatible anymore.