MIME-Version: 1.0
References: <20230210024343.26220-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20230210024343.26220-1-jiapeng.chong@linux.alibaba.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 13 Feb 2023 11:16:12 -0500
Message-ID: <CADnq5_O_byNv=MVKQSL8hCXy-ENtLo31vq5zdmrE_dKZwif=nA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Remove the unused variable pre_connection_type
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     alexander.deucher@amd.com, Xinhui.Pan@amd.com,
        Abaci Robot <abaci@linux.alibaba.com>,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

On Thu, Feb 9, 2023 at 9:44 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Variable pre_connection_type is not effectively used, so delete it.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4031
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/display/dc/link/link_detection.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_detection.c b/drivers/gpu/drm/amd/display/dc/link/link_detection.c
> index 63e75c392031..d224a44c4cc8 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_detection.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_detection.c
> @@ -886,7 +886,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>         struct dc_sink *prev_sink = NULL;
>         struct dpcd_caps prev_dpcd_caps;
>         enum dc_connection_type new_connection_type = dc_connection_none;
> -       enum dc_connection_type pre_connection_type = dc_connection_none;
>         const uint32_t post_oui_delay = 30; // 30ms
>
>         DC_LOGGER_INIT(link->ctx->logger);
> @@ -923,7 +922,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>
>         link_disconnect_sink(link);
>         if (new_connection_type != dc_connection_none) {
> -               pre_connection_type = link->type;
>                 link->type = new_connection_type;
>                 link->link_state_valid = false;
>
> --
> 2.20.1.7.g153144c
>