Date:   Mon, 13 Feb 2023 12:24:15 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux.dev,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Raj Ashok <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Message-ID: <Y+pkL5b6mGv40nZy@nvidia.com>
References: <20230210230206.3160144-1-jacob.jun.pan@linux.intel.com>
 <20230210230206.3160144-3-jacob.jun.pan@linux.intel.com>
 <Y+pjTR80bnl9rMK1@myrica>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+pjTR80bnl9rMK1@myrica>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pCtfiRjHGOj6KbtMKGLK/6LPgqNdhjmQGQWlSSQE3K1rjQx7mNEFaUAzvzBr?=
 =?us-ascii?Q?Zew9HdGyyD/x0ZQ2s4uKtkvtHhEA4J33KMxzyDmj4vMMlygPZZK/7P/LmdRy?=
 =?us-ascii?Q?xFIe0hHOP6DIM9CK7qUKXMJ1dKuqJ9611WhiWDFyL4RZ3il5AAYEGiNrv6u+?=
 =?us-ascii?Q?MtoXnijb/IuQgswsahbmEOcWAcI8JKxcXfj4ZPNnCpTfelSju57Sg68uIpU2?=
 =?us-ascii?Q?KDYo7+1O1+HlqybKYPG0N1yLxqAWFJSTqCpgm9ns7oyzkL0RWdIf3wN/vsXI?=
 =?us-ascii?Q?cMyzQwJZSWh0FGx6suWm5CAH4Y8G3mapgmd3/I7pgvYG3KghQORRysdews5e?=
 =?us-ascii?Q?CKr0S9dNnTxagZiBv99ZjxbGfr/WTvMiHbeu3HJzsY6h1onenG2XdjJC3Unx?=
 =?us-ascii?Q?M+z/0eHIRXE7e27C4nDth/AZ3bYv5LzoKrxuOXlUUqZhA2xiX69Jktl0XTGB?=
 =?us-ascii?Q?zxda1TmLKx18jfto3iop4mUjE1cUnmbgQ2JtR5l84hPEe9v+ULHPoA5e8wAX?=
 =?us-ascii?Q?q+hSC6b2ZjQH2XXzhQ6TA+gSc/uBLeCR0N5cWrpFh8eGxtAkgaEaJ75T7mIj?=
 =?us-ascii?Q?4ZtfMAdSdr24SwlADYtDWk6OqxbYcapaEkoU4d6bk43+/NdJMOewtBECDvg7?=
 =?us-ascii?Q?79IhDdotsHOMPtbq0fCh1xm8JVK4aeEHzfR/lg7ReoFwsFOvCp5/t/idtL2E?=
 =?us-ascii?Q?7ID67mSyn4Zgm+qj7lRxc/2/6Yq2p0TZqXOeFg8TIbuBMaH1d6zBzlK3MrOl?=
 =?us-ascii?Q?ftX1d0oRfBC2OuKqXVvdRtDShDHtsI0G1+T/InVMubJQ9/P73YbqOjnUhCoP?=
 =?us-ascii?Q?sH/AFQpHarPXYE3H8ewetYtiK5jk3+gOaZe7FVhKPOz/OtTpbInq3U3csLcz?=
 =?us-ascii?Q?bTHPY1A/VR+2OQzRpTCZV7aTCQqC0lHQJ3NCVA4ada8H676z08qMomQTlu+8?=
 =?us-ascii?Q?mQPilgvKAmdix7Hv85DiXCzA1KrBDLMC5UjlvQAM7BCFKX/w5kF/ecZ6Wq/Q?=
 =?us-ascii?Q?gG2CmC1wYFekRhoe2uGCecq7KMjLotfKKrPeEWYsDQtOhMp1IhlEZ4U18qEq?=
 =?us-ascii?Q?5M0JHtYht4RrzbP+Y153BC+XPBLSYGxyIbnRgnJ1vrGA1j+sARAsR6/EybbV?=
 =?us-ascii?Q?/Fs8i4vmTUriaKFnRkY3qx14tcwJf4fH+KzjxNSNZGPndYPJHoV12bi9rdGb?=
 =?us-ascii?Q?YTN3xhM3MwRtfq1HYb4ujvIEKTF8XyPCWdxKtKb+V3jnls8RiuwKGDecEVAr?=
 =?us-ascii?Q?Ni5MrWcjnNJkFi8eaSeKgTE7Lj6U0aMdHjN85BPCADstjDdkmwrMgobNYD2E?=
 =?us-ascii?Q?kz1gscJiruF9jyvFewxpEKyAy+lsT0OfFJMO4ybfV6vCrlNlSkBFuZq80wsO?=
 =?us-ascii?Q?jpQ/8sUcng8MHKeoxDEfveURPoH5o1CMHM4Us4FT3+LSzUjN+AuEQQoQxugt?=
 =?us-ascii?Q?W2QL0w4jBtiFK+sZ27U7xRKLMHsoglOuhkpsM6XzF/LNscj1SMlxHZKhlcd+?=
 =?us-ascii?Q?oyY7KaEhtYO9nz7/+9zXbS1IDrVfLnQyIF+3tU3eJnaoc/VOfIjzGqCmG4/n?=
 =?us-ascii?Q?hZ1A0vRGFNJ6WUmwrpq5dQ+tgBGwwhBMLCtOFfoR?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8abf81-372b-4b87-c289-08db0ddec04a
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 16:24:16.5741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 072hLAkTpX7fU0mekVC4MAf1cfkCCvek2v95hO6N1HfpUVvtzjxMT9v9GkYTRLKJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4958
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 13, 2023 at 04:20:29PM +0000, Jean-Philippe Brucker wrote:
> On Fri, Feb 10, 2023 at 03:02:06PM -0800, Jacob Pan wrote:
> > Custom allocator feature was introduced to support VT-d's virtual
> > command, an enlightened interface designed for VMs to allocate PASIDs
> > from the host.
> > 
> > As we remove/withdraw the VT-d virtual command feature, the sole user
> > of custom allocator, we can safely remove the custom allocator as well.
> > Effectively, this will return IOASID core to the original simple global
> > namespace allocator.
> > 
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> 
> You can also drop the spinlock.h include. With that:
> 
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> 
> On a related note, it looks like 100b8a14a370 ("iommu/vt-d: Add pasid
> private data helpers") removed the last user of ioasid_set_data(). I guess
> that could be dropped too, unless you plan to still use it?
> 
> We could also merge ioasid.c into iommu-sva.c at this point, since I
> haven't seen any interest for having multiple IOASID sets on Arm, but I'm
> not sure what the current plan is for vSVA on x86.

Once the customer allocator is removed this is bascially a thin
wrapper around xarray

So anything that needs multiple pasid spaces should just create it on
its own directly with xarray

This is bascially a shared xarray for a global pasid space.

Jason