Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758136AbXIEVXB (ORCPT ); Wed, 5 Sep 2007 17:23:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756904AbXIEVWU (ORCPT ); Wed, 5 Sep 2007 17:22:20 -0400 Received: from mail.fieldses.org ([66.93.2.214]:60914 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756698AbXIEVWS (ORCPT ); Wed, 5 Sep 2007 17:22:18 -0400 From: "J. Bruce Fields" To: Linus Torvalds Cc: nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org, Neil Brown , "Luiz Fernando N. Capitulino" , "J. Bruce Fields" Subject: [PATCH 2/2] knfsd: Validate filehandle type in fsid_source Date: Wed, 5 Sep 2007 17:22:13 -0400 Message-Id: <11890273332461-git-send-email-bfields@citi.umich.edu> X-Mailer: git-send-email 1.5.3 In-Reply-To: <11890273334076-git-send-email-bfields@citi.umich.edu> References: <1189027333981-git-send-email-bfields@citi.umich.edu> <11890273334076-git-send-email-bfields@citi.umich.edu> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1768 Lines: 60 From: Neil Brown fsid_source decided where to get the 'fsid' number to return for a GETATTR based on the type of filehandle. It can be from the device, from the fsid, or from the UUID. It is possible for the filehandle to be inconsistent with the export information, so make sure the export information actually has the info implied by the value returned by fsid_source. Signed-off-by: Neil Brown Cc: "Luiz Fernando N. Capitulino" Signed-off-by: "J. Bruce Fields" --- fs/nfsd/nfsfh.c | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 0eb464a..7011d62 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -566,13 +566,23 @@ enum fsid_source fsid_source(struct svc_fh *fhp) case FSID_DEV: case FSID_ENCODE_DEV: case FSID_MAJOR_MINOR: - return FSIDSOURCE_DEV; + if (fhp->fh_export->ex_dentry->d_inode->i_sb->s_type->fs_flags + & FS_REQUIRES_DEV) + return FSIDSOURCE_DEV; + break; case FSID_NUM: - return FSIDSOURCE_FSID; - default: if (fhp->fh_export->ex_flags & NFSEXP_FSID) return FSIDSOURCE_FSID; - else - return FSIDSOURCE_UUID; + break; + default: + break; } + /* either a UUID type filehandle, or the filehandle doesn't + * match the export. + */ + if (fhp->fh_export->ex_flags & NFSEXP_FSID) + return FSIDSOURCE_FSID; + if (fhp->fh_export->ex_uuid) + return FSIDSOURCE_UUID; + return FSIDSOURCE_DEV; } -- 1.5.3 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/