MIME-Version: 1.0
References: <20230213105803.v2.1.I610cef0ead2d5df1f7bd18bc0e0ae040b03725d0@changeid>
 <Y+ppFm40+gmVK6NU@google.com>
In-Reply-To: <Y+ppFm40+gmVK6NU@google.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 13 Feb 2023 08:49:00 -0800
Message-ID: <CAD=FV=X3Tj8V7cSzY+JQwdNRRqiqQC80cPHQci8f_HPp8y_q2g@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Owen Yang <ecs.taipeikernel@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Abner Yen <abner.yen@ecs.com.tw>, Harvey <hunge@google.com>,
        Bob Moragues <moragues@google.com>,
        Gavin Lee <gavin.lee@ecs.com.tw>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Feb 13, 2023 at 8:45 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> On Mon, Feb 13, 2023 at 10:59:05AM +0800, Owen Yang wrote:
> > Tune the PWM to solve screen flashing issue and high frequency noise.
> > While at it, the comment for the PWM settings incorrectly said we were using a 5kHz duty cycle. It should have said "period", not "duty cycle".
>
> Please split this into two lines
>
> > Correct this while updating the values.
> >
> > Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

Reviewed-by: Douglas Anderson <dianders@chromium.org>