Message-ID: <8b25bd1f-4265-33ea-bdb9-bc700eff0b0e@intel.com>
Date:   Mon, 13 Feb 2023 18:44:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH V2 net-next] net: fec: add CBS offload support
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <wei.fang@nxp.com>, <shenwei.wang@nxp.com>,
        <xiaoning.wang@nxp.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <simon.horman@corigine.com>, <netdev@vger.kernel.org>,
        <linux-imx@nxp.com>, <linux-kernel@vger.kernel.org>
References: <20230213092912.2314029-1-wei.fang@nxp.com>
 <ed27795a-f81f-a913-8275-b6f516b4f384@intel.com> <Y+pjl3vzi7TQcLKm@lunn.ch>
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <Y+pjl3vzi7TQcLKm@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eC95eHJWalNta1BDb2lPQXZ0QUMvRHJFNTlLTmVVNFJzakRmS0dNVXN5WmdT?=
 =?utf-8?B?bjRkZk4vUGRoejlzR1pyMko0QllUZ3BISHFONGJGWXI5S2djU1haYm5zQzBU?=
 =?utf-8?B?R3k4RmhXbUhvZEVWZER0NElYbjUwTCtORHV1Q3hoWUs2ZHBwLzZIR0IyTTZP?=
 =?utf-8?B?cHd1bWlOU3FkRno2eVkvN29jMVc0UlhnYnVJd2FOaVh1U1ptUUROZ3ZjVTlC?=
 =?utf-8?B?bnZDbVRWZS8vT0Q1dXdhM20rMndPSEtNSitDYS9HUzBCTVEyN1VMbmRMVURK?=
 =?utf-8?B?bFhobDMvemFQdElQSE9NOXU4TlI5UWk2THdLL3NOTC9FdWxnajdxWlpMbXYx?=
 =?utf-8?B?YWtqNWlXMTRRb2krTGQxSCtUNkFxRDVLVnlpU2ZlazZwZDNCTFFleVV4VTZ5?=
 =?utf-8?B?THBqRkFROHhlV25uMUhaK0dtdDY4QnprZlZxV3poTnVjNlV3enZrdVA3OUd0?=
 =?utf-8?B?YTRKWHh1cGVDUk1INGtyQzcrMzh1Ykk3dU0ySXZwNTlGb0o3NnJVUTJSNXdV?=
 =?utf-8?B?eUNXYkJocTl4M1V6OVRGSHBHQlJ0MEZPalZDSHlrcW5NN3F5OWdpYlJQQlF1?=
 =?utf-8?B?WUpxbXllblE1YTBSUzN6Q2RvOHVWaXI2SWpwcndjOEpHZzhhMGlsb09KNmp4?=
 =?utf-8?B?MThmd3RpV0MyWlBMQU02ZUlsYUJnWU1GQkduVmZMV0U0U3ZJSTNhM1RBbkxw?=
 =?utf-8?B?YmdCZXFVMk1EWWNPRjlkWllvT0hEYm9haDR0YnpQNk0zYWpvRFRHVWpaNWpI?=
 =?utf-8?B?OHBldk5wWURQaWRIN1pHWThCZk9pWXVOcVpidjRtdUN5aHR1VHZxc0F6VGhI?=
 =?utf-8?B?OG15eE1vUlJvUTRGbHdBZnBJTUdNRVIvbGdwQlUrbTJlby9scTlvRTdBRzcw?=
 =?utf-8?B?KzdBYVRsQVdjcWFKN3AxczM4cGNtYVhINHp5RVU1ajhpazczMi9qdXR6NElz?=
 =?utf-8?B?SkdKd25xcnBzZnNKVDg3UnFIUW5KalV0bHNQZDRkWjV0a0JHUUVMWWlKSlFQ?=
 =?utf-8?B?aXVCKy8vdlJCNC9SUjl6R2NpLzN5a3ROcjJGTlZJTmxad2FWbU1BdW9aOU45?=
 =?utf-8?B?TXBySG84ekg1Zkc5OFRYcW9zMzkvUXA0WmNOVGpZbEtobGxLTDZrOHFTQzdD?=
 =?utf-8?B?UnFXR0I4OFY4QTFWZEF1TmxDenJPRHZ2bUExVzl3aUNXZlk4MlVSOWhqcDBm?=
 =?utf-8?B?YnNaQWVvaEVHVnhCeHZpNlp6eEJVenV1eW43WVg2VUtoV2pUalpJWllYS2pL?=
 =?utf-8?B?cG5XeG9TdUpMRHNDTm00bUpyc1pXbXJXSm1HTSttcmF5SVI4TUxKM0ljMFNw?=
 =?utf-8?B?QmEyV2VybHVzUmVpV3hJVEV4MkpWSHBpVlZWZmJZMGpBcTM0L0poUFltalRL?=
 =?utf-8?B?cGErQmJ4eU1ZckN1Z0dYZXE3NTFMd1JWVk0vT1NEMjNMMklYc0ZjNmZVNXVa?=
 =?utf-8?B?RjNwcDFFdmJQRmdHMWdKTmowYmJCRVBKbXZIREFnVDU3aU83VVREZTBtOXBU?=
 =?utf-8?B?clZCdjhUMTJyWG9zcXBDcWxIdnNSVUh4VFdxU2tpNVNibk9VSStzWVdJL3Bv?=
 =?utf-8?B?RVcrelZ5VExNQmZacm1DS2RQZDl5RWJ1THJkSzlicWRRVkFYakJ5MUVZRWZY?=
 =?utf-8?B?RVpSY2lhV09zcURCanRLOHg1U3pZaC9RVUlOcHdoWjYwVCt0c0lUYUVuZHpN?=
 =?utf-8?B?OWFaV0J1eG5WMzJxTFRsblpEY0lVYnB5RlJtOVZXZGVxODNzczNoRE5Oa2xw?=
 =?utf-8?B?ejZzOGpId2NFRytPL1pNanplcDVwN3l3OGt6RjBwbDZDenBuZ2xzNWo2dWZt?=
 =?utf-8?B?RXJna0ttQWNCSnMrZGJyU1Nuc09UV2pYOGRhYVMwa2l6UGxUYmVoV0d4SWZx?=
 =?utf-8?B?cXBiU3pMOG5rY2dZckRTRHV5TlpnemR2clZLYkRhdzNzV2M2ZE13NFNqRkhN?=
 =?utf-8?B?Y0xwVEtJSFlVWUJCQXc1QkQvK0xNaEErM2tCWGhNTGUxRk1QYmN5SHEvMzdW?=
 =?utf-8?B?ZDZ5Vk1yVFQwZFhtUEloRUFEZHZvbGtWSnB5bVZBamN1TXZVUmF6VWVNWmhW?=
 =?utf-8?B?RUNmdFZmWWxGK1g2Q0JIR1lCODI3c2tJd3NyaGVMdWFnZFZibWF6M2dnUjla?=
 =?utf-8?B?MjdXdUV6aWJUOENGL293WW5UN1BnNURVUHc3MkIvMEFqb0hOVFE1eHNPWXo2?=
 =?utf-8?B?M2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07cd7004-d542-42c5-227e-08db0dea0ce6
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 17:45:09.5942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ITGoI0FGOvpiQnGvxqNQ0LDgHH2W0IjxmWabpjud5sa/1zWjZIoZODYTSIQ9UVTyr0oh9YCnCq6mEMCv4MyLyAFwZuRuPC3QEqwfQL4infQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7305
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 13 Feb 2023 17:21:43 +0100

>>> +	if (!speed) {
>>> +		netdev_err(ndev, "Link speed is 0!\n");
>>
>> ??? Is this possible? If so, why is it checked only here and why can it
>> be possible?
> 
> The obvious way this happens is that there is no link partner, so
> auto-neg has not completed yet. The link speed is unknown.

Sure, but why treat it an error path then?

> 
>      Andrew

Thanks,
Olek