Date:   Mon, 13 Feb 2023 18:57:56 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next 0/6] ice: post-mbuf fixes
Message-ID: <Y+p6JAsc+OHxARyq@boxer>
References: <20230210170618.1973430-1-alexandr.lobakin@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230210170618.1973430-1-alexandr.lobakin@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jr4G+WpI8KflJvrxMHKkPdMmVLz6bD/TxH0tY8mh869Iy++2pNdM3fj6qQkt?=
 =?us-ascii?Q?oCvkpvSIJfIn0VwyqUVnoVrtYOyHg9Wkmdnz5zOmoPBR3MrJXln8QkLsJO2E?=
 =?us-ascii?Q?GgV8fat1tHcNlbLc5Hol9AolMX+FUOVYZDswXLryZBFS9sRiGOcNuKFITg6G?=
 =?us-ascii?Q?TvSlI2vLkyc/oJP5R7nKmCn6nKa5lp54PS0Q/sLIoznWumwFf7Q7mQINfc7t?=
 =?us-ascii?Q?obIr4lheTxP3GZ39cnoc2HeNrRL0JBM+3iDJX+2EwAMCnszsS1OwRokDOroV?=
 =?us-ascii?Q?+8TQZUShaX0lUmQ0py8O68GtTiu09VUCj0GTtN2uKYU0MtPUNrmnUnIZLKX7?=
 =?us-ascii?Q?1eaOtFo8rZyq5WKmmZKRdNRGXbZ6ypKitvBY5/SEhOfOSdmPiUjdtuLApiN7?=
 =?us-ascii?Q?uEks1iaQx22hkIneM374Sel7T1QkZJLkkolDMtq5O5IhqpTHqTP1qED4dqg7?=
 =?us-ascii?Q?6aP6PApEOovEVW9QuVyau/8LKVqKAlHcCskVefrDHhAbBvTL7bHRCJM76Mtt?=
 =?us-ascii?Q?6YJlV8cZaTCUKU3JMN9Q2Wp9lDYASaBGhWwKZR0NkAZ1uSvQCOO//owCoA42?=
 =?us-ascii?Q?yBJ1xHzbO+sSowzCAf94J2GTwfZYwNjk0fWfFmxBW3OrNC64fw5mUy2mJ08G?=
 =?us-ascii?Q?MPXKZmnDAzUhl1vGURCTew6TnbwLjeDJoDDDgFBcj0Cb6a9k4jZsMa2Hkhgu?=
 =?us-ascii?Q?PDlsR0YFXSgC49ojhIoebNxdPExsBGijBeLFjt054C3WdKDTcl4xq6xHaU5L?=
 =?us-ascii?Q?lLV3GOrl61VOy6EAsx65YpyoLww4X3gpIyFzBuZwUC3/Uc+HoqkUs9lVBEh3?=
 =?us-ascii?Q?NlWu4VH+uk53M29OQ89tpRslnuEpOexJgFnuX/QPYp4IC/l48BM4PjzAq0La?=
 =?us-ascii?Q?YPaJThJe4oPDXj3iy8ARmBHuzi/gI+4AvBtKvSBqECKKTW3P4Lfdn70heXt6?=
 =?us-ascii?Q?l7gsvgTCPqtssZ3nMNdgLggkyNju3IcT/k/QMvOBnWwbl/07orGJh0ZLjLSd?=
 =?us-ascii?Q?mE+l+ORzt+oJKZJ8ceIQ1ODcENFIBAcfucG3kq/ZFvWxggcx9ZGgt2fgU3Bl?=
 =?us-ascii?Q?dgPjxKgjIEXnPcAMe9ulpF8yqa9zB7yc+RdmDNXYC5Ma5jsGfVvVxlIemXc5?=
 =?us-ascii?Q?o71hFpxxvsoj+rQKoXNyGe4erZioKJVjvZ414r9V5BWO9TIymcbEio5NXbIq?=
 =?us-ascii?Q?WYQamgcl+ZLU66+p0dgrfuUreyfHSvVVZXlXcSOY5bSt7T/TFMVEKO6uQkQJ?=
 =?us-ascii?Q?HMasAkCgHrwK3SDKDRQ+2LShIpYs7mi8z6TYMseHC+ZPFeihp2AHfrN1iueq?=
 =?us-ascii?Q?UOW2/Y1Ff2jbSkemE5a4/7tfBXGJei5doSg1+whU9DVAqaWnDCDwrByKxQV1?=
 =?us-ascii?Q?XkG990DkS4nU3RkfKVPiXdYjxmwIGgt7cBDVjYC6ofsIaw6YY0/GMktYSYUf?=
 =?us-ascii?Q?xUqmT3g5VlhvilTENbyoRWxtov3QI0X7eVzSI+Pa2kGlIcWuONzbXQADKa1F?=
 =?us-ascii?Q?obcftoWjpTF2t8RBG7rF2zUYagjj09/DTkAL7rQJavwDBYcUJFIdVbmFTJgn?=
 =?us-ascii?Q?lmXncFHe/3D5d9wWtkgILAreCx56pl34H98oywwAf5h1IXNjlRbIrJIW67Fk?=
 =?us-ascii?Q?V0c0vIZeU+g+Dbmr0QY38Vk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 73a35cbc-de68-4f2e-9709-08db0debda98
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 17:58:04.0840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Ronw2/JR/MmKXoUc/BR8+KfGJ/t1o2u289+EE4DOtn1vp3vFBcU6UbQAR/9rncjoHQjjOj3qBw72BRTNNcI5kzd6QD4l3YvG1scHl0qyvo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5160
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 10, 2023 at 06:06:12PM +0100, Alexander Lobakin wrote:
> The set grew from the poor performance of %BPF_F_TEST_XDP_LIVE_FRAMES
> when the ice-backed device is a sender. Initially there were around
> 3.3 Mpps / thread, while I have 5.5 on skb-based pktgen...
> 
> After fixing 0005 (0004 is a prereq for it) first (strange thing nobody
> noticed that earlier), I started catching random OOMs. This is how 0002
> (and partially 0001) appeared.
> 0003 is a suggestion from Maciej to not waste time on refactoring dead
> lines. 0006 is a "cherry on top" to get away with the final 6.7 Mpps.
> 4.5 of 6 are fixes, but only the first three are tagged, since it then
> starts being tricky. I may backport them manually later on.
> 
> TL;DR for the series is that shortcuts are good, but only as long as
> they don't make the driver miss important things. %XDP_TX is purely
> driver-local, however .ndo_xdp_xmit() is not, and sometimes assumptions
> can be unsafe there.
> 
> With that series and also one core code patch[0], "live frames" and
> xdp-trafficgen are now safe'n'fast on ice (probably more to come).
> 
> [0] https://lore.kernel.org/all/20230209172827.874728-1-alexandr.lobakin@intel.com
> ---
> Goes to directly to bpf-next as touches the recently added/changed code.

For the series:
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> 
> Alexander Lobakin (6):
>   ice: fix ice_tx_ring::xdp_tx_active underflow
>   ice: fix XDP Tx ring overrun
>   ice: remove two impossible branches on XDP Tx cleaning
>   ice: robustify cleaning/completing XDP Tx buffers
>   ice: fix freeing XDP frames backed by Page Pool
>   ice: micro-optimize .ndo_xdp_xmit() path
> 
>  drivers/net/ethernet/intel/ice/ice_txrx.c     | 67 +++++++++-----
>  drivers/net/ethernet/intel/ice/ice_txrx.h     | 37 ++++++--
>  drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 88 ++++++++++++-------
>  drivers/net/ethernet/intel/ice/ice_txrx_lib.h |  4 +-
>  drivers/net/ethernet/intel/ice/ice_xsk.c      | 12 +--
>  5 files changed, 136 insertions(+), 72 deletions(-)
> 
> -- 
> 2.39.1
>