Message-ID: <ae011239-5eab-29dc-4b90-87182b0d3a1b@denx.de>
Date:   Mon, 13 Feb 2023 19:10:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 3/6] Revert "regulator: pca9450: Add SD_VSEL GPIO for
 LDO5"
Content-Language: en-US
To:     Frieder Schrempf <frieder.schrempf@kontron.de>,
        Frieder Schrempf <frieder@fris.de>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Cc:     Per-Daniel Olsson <perdo@axis.com>,
        Rickard x Andersson <rickaran@axis.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
References: <20230213155833.1644366-1-frieder@fris.de>
 <20230213155833.1644366-4-frieder@fris.de>
 <ee7d0f98-3ae9-7e66-785e-65c9e11a7232@denx.de>
 <4a334087-9c72-2d86-e1d6-5d08ed5adc45@kontron.de>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <4a334087-9c72-2d86-e1d6-5d08ed5adc45@kontron.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/13/23 17:23, Frieder Schrempf wrote:
> On 13.02.23 17:16, Marek Vasut wrote:
>> On 2/13/23 16:58, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> This reverts commit 8c67a11bae889f51fe5054364c3c789dfae3ad73.
>>>
>>> It turns out that all boards using the PCA9450 actually have the
>>> SD_VSEL input conencted to the VSELECT signal of the SoCs SD/MMC
>>
>> 'connected' , typo .
> 
> Thanks!
> 
>> btw would it make sense to squash 3..5 patches into a single patch ?
> 
> Hm, don't know. I think the changes are easier to understand with the
> current separation between "revert", "core changes" and "pca9450 changes".

OK, I don't mind either way.