Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757272AbXIEW1Q (ORCPT ); Wed, 5 Sep 2007 18:27:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754949AbXIEW1D (ORCPT ); Wed, 5 Sep 2007 18:27:03 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:39028 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754325AbXIEW1A (ORCPT ); Wed, 5 Sep 2007 18:27:00 -0400 Date: Thu, 6 Sep 2007 04:10:11 +0530 (IST) From: Satyam Sharma X-X-Sender: satyam@enigma.security.iitk.ac.in To: Willy Tarreau cc: Axel Reinhold , Richard Kojedzinszky , Linux Kernel Mailing List Subject: Re: 2.4.35.1 and panic at boot with arch=c3 and gcc-4.x In-Reply-To: <20070905220027.GB11602@1wt.eu> Message-ID: References: <20070905220027.GB11602@1wt.eu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 24 On Thu, 6 Sep 2007, Willy Tarreau wrote: > > I finally tracked the problem down to a dirty trick used to prevent > do_test_wp_bit() from being inlined (Axel, you identified the right > file). Unfortunately, this trick does not work anymore when gcc-4.x > is used without -fno-unit-at-a-time, so let's use the correct method > instead. > > > -/* Put this after the callers, so that it cannot be inlined */ > -static int do_test_wp_bit(unsigned long vaddr) Ick, that was horrible indeed! > I really hope that this trick is not used anywhere else! Me too ... funnily enough, 2.6.23-rc5 still has that wrong comment in it! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/