Message-ID: <1a933b7c-0318-ce06-9239-197d78c9889d@intel.com>
Date:   Mon, 13 Feb 2023 11:20:08 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH v7 4/6] selftests/resctrl: Cleanup properly when an error
 occurs in CAT test
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230213062428.1721572-1-tan.shaopeng@jp.fujitsu.com>
 <20230213062428.1721572-5-tan.shaopeng@jp.fujitsu.com>
 <616c7fab-65ad-17b7-f360-94b7e22f892@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <616c7fab-65ad-17b7-f360-94b7e22f892@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVVwVXJIQ3hkQnpRbTlEOWlUOTB4MTFtM1dBUWt1bjFsd1pWRVJobVpvdklM?=
 =?utf-8?B?REhTeUlBSmNJMjZBKzBGSjNiYVduT3J3Y2FKSzdsem41dzQ3ZTBkUHR2UmVv?=
 =?utf-8?B?VEY1ZDNGUkIydEltMnJPbnpGRWM2TkY2b1QyTi92MFhWWkNtSmN5bDhMWHg4?=
 =?utf-8?B?T2E4K055ZHI5cWlIUDVmY0VqNVNsdWlYM0h1UjZmQnh5ZUl6amdoQTNyYitF?=
 =?utf-8?B?cXNIRXVOOUx1QkVGYWh3NWNwUFViVDhQNC9tZm53WDFMeWVFTUF6M1ZBbHQ2?=
 =?utf-8?B?d0djOXNCNFBPUlVnTXZxUTkyZkZWdDRXN2RLUVAzaFNvNy9jaDdINkR5TFFT?=
 =?utf-8?B?MlhpZFE4eTNCS0lRcktxcFc3c2U5ZmlRTXVaMldFeU1kbGhTRGdOdWZFdHhP?=
 =?utf-8?B?emV2SWFLRlgrdXVGVjVQRFRJRENHVm5IUFAxeS9zS2lyUVVIeHBiMDNhQjRl?=
 =?utf-8?B?NE9xQ0RhcHdFSCtrT0RyNDRTN3lraVgrZkR1ZDUzc0JwNU5RVGlYMFJSWHQr?=
 =?utf-8?B?WHhEd3FBNmQwbExEc1dWZ3BqYlVIaVhHUmY1d0pJM2VMK3RaWnhHK2lTaHdH?=
 =?utf-8?B?NVYzSE9INDhCcytsa3NwWkFjd1NzTHBzdkQvTUdJWmhSalQzUGRZcFFPKytW?=
 =?utf-8?B?YUxtVVRDeThKalVXYWp6MUhPRTBPR2cwOFhHK2F1aXlpL1ZzeGhISTdtcFFn?=
 =?utf-8?B?ZmM0RWJOMUZPeFpZQkVzcVJLTllZWkZURk5ram5DMUdNOHJSRlJycE9rNitq?=
 =?utf-8?B?WmlXK0RkVUd3cTZnV001YW5XU1ZnYlYyMHJyaEtTRUNEZ215MEk5WHBCZmZN?=
 =?utf-8?B?VDVROXpWajU4OFYwSXp6SU01TmVucFhBeit5eENjenAzNGlRRDNlV2JadXQz?=
 =?utf-8?B?V3VQOW9ScnB2VmlHWlRvZ2M2UDdzOFR4cDdiY2tkTGRLbzlHRmZoQ1JQTHZr?=
 =?utf-8?B?eUJuZCtpbDB3Q21VRzVtUGx6d2s1WmN1WUVqU09PZXk1VjltQXdSZ3NhSG9w?=
 =?utf-8?B?bWlQQXJVVk8wMlJ2czRSVXB4RDJ5ZkhoalpzV25wSGhoT2J3a1diUklVelNh?=
 =?utf-8?B?NFUxb0tpTVNYL0orbmZLeENGRkNncWpVOXJnVy9LVDRIQ05SSHo2SGZJckZR?=
 =?utf-8?B?MUtIcEJpSUU4SWdCK1FsZ2kza3FSWWx2TEpPeUk0Umt5YjJ0bS9yUWtuSG9X?=
 =?utf-8?B?OS92UHJKbVhiWkpuc2d6dG1hK0tnK0xpV3NuVG9mRk5vOGNsc1FsVUF0Si9o?=
 =?utf-8?B?N3M0R3BlY2RsazdvcFkwbHFCUnEzQ3Y4Si9WVjVSazFrVllTL1RKT2t2WUQx?=
 =?utf-8?B?U2V5VSsyd3dHa2ZWS0pQY2dObXRBWmFZWlBiOTBac2FHaE1oUjlwbEZGWWFY?=
 =?utf-8?B?RXRWenpIR3p4MlJ3amMvbXdJbGNoakJrUmdTcUFhdVI5ZGNXTUVUbHVlS1R5?=
 =?utf-8?B?UjhoWk5HajMvVUtITVkveG04SEszSkY2RkxVTnk3cDJzWnNmd0xTU3RIWnM5?=
 =?utf-8?B?VUhPY1JKZzdqQ0VpSXJIRnpJNXBYSzFJeENGTG9YbVZxYXJ1d1h4WnZMcklv?=
 =?utf-8?B?bnN1N2hvM3lXYTZ3WGFVS2laSTUxVzNzL2dGdFRQYU43SUQxeVNVWHVQdnM5?=
 =?utf-8?B?SGpKaVNsNGhmMkU2V0dXQUxTdWo4Ni83YWFDUnU5cEdDMUJnYmpOVlFkT0lC?=
 =?utf-8?B?eENHT25RM2ZQNmhvSkJFSEtLRThxd2VIYXRNSVdiNTgyZUZpVXFuTnVOS1BF?=
 =?utf-8?B?MzUxcHNJVXhETm44bUtUQmpmem15cFh3NlF2V2tRNE52VGEyeWNVS2pUM1Yz?=
 =?utf-8?B?ck1yMnIzWXRxa3VSNzlGanhzUVc5ZzBRKzhESktUV1ZkSGw5dVdZdWVCRGpW?=
 =?utf-8?B?ZGFkMHFiV1NUbUNOL081cHExSTRGTEZFR3gwcnRoMGx3a1NoK2hXeFV1cVZZ?=
 =?utf-8?B?dnovL2RZaG5KZUN2OXJFeVZXbW9DVjZJR1BOV0RsWHZoVDc5OHlmOG9yQ21h?=
 =?utf-8?B?Si80dnMvZmFKWWFHUjRHVFRBVURxYnV1WWhWQjJ1SFZIZ2JRSElRRHdQVHlL?=
 =?utf-8?B?RkpqcUlBSEZqbWV3K0VaSllYMjEvbjdpZlppWE54NHlhejhvYXBQRVBYKzVv?=
 =?utf-8?B?TVVkTkJQeE9Tajh0bXFrQVo4RlJmS3VTRU40VFZmKzE4MmNHVE96bW5WbFZ0?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 39e30570-65c1-402c-5188-08db0df752e4
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 19:20:10.3866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c0u09zo08UNt2nBFnD5I1LfpXcxdpaz2A8cM2eQ0ADijDm735wEU49tD8SviyX1DKNojbXCCGo0ZFkzfMogSqgLTAOiXGeufkmBbMN7mb70=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6048
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/13/2023 2:00 AM, Ilpo Järvinen wrote:
> On Mon, 13 Feb 2023, Shaopeng Tan wrote:
> 
>> After creating a child process with fork() in CAT test, if an error
>> occurs when parent process runs cat_val() or check_results(), the child
> 
> I'd replace the rest of the paragraph with this:
> 
> "returns early. The parent will wait pipe message from child which will 
> never be sent by the child and the parent cannot proceeed to unmount 
> resctrlfs."

Note that the description is about an error within the parent process.
In the case snipped above it is the parent that exits early, not the child.
This first paragraph describes two scenarios, (a) error in parent, and (b)
error in child. I think it is good information to keep descriptions of
both scenarios.

The proposed addition could be used to expand the description of the scenario
when an error occurs in the child. In this case please consider changing "wait
pipe message from child" to "wait for the pipe message from the child", and
"proceeed" to "proceed".

Reinette