Message-ID: <a7f1d984-21b6-0bc8-519d-6d2c5e310381@intel.com>
Date:   Mon, 13 Feb 2023 11:21:19 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH v7 5/6] selftests/resctrl: Commonize the signal handler
 register/unregister for all tests
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230213062428.1721572-1-tan.shaopeng@jp.fujitsu.com>
 <20230213062428.1721572-6-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230213062428.1721572-6-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0ZTeFZLd2F2c0tCckdkTVQ3dWxGOU5sN0JNc0ttMGFHbDNrVXdoTjRsTXVu?=
 =?utf-8?B?OGNhSlI2SFR5S1N2d3pMbnpOYjJPRXhvazd6TnlCZTdWajV4eVRaU3g1VVZI?=
 =?utf-8?B?VFo1eFVSb1dhekJ4a25JTnFGRW5STXdKSktEdmdSOG5HK01hUXZBeC9CSnZr?=
 =?utf-8?B?VVgrVk8va3JBQkw0MFFkVmpGZ3VnRVRPaXA0TmJzR1FLK3ZSK202ZERvRE1G?=
 =?utf-8?B?bytvU3BNY09lRVNZK1UvQWRCZW4yeWZhejkxakw2YmZBS21XVTVrVldxNmF4?=
 =?utf-8?B?QjRHQzJCQ0VYZ0tFbzNqUzYxV05Kdkx6aXN1V2N6NjVjdzM4Y0t3Zk9RYzFM?=
 =?utf-8?B?d0JDeGxPY0ZKYlhtTTI4eFJmeXkrVDlCZnlmakpuNy81VlZnL0N6MHEyY2Z0?=
 =?utf-8?B?U01rZ0lvWHQ3b3AvaGNLYTg3NkJJbjc0T2hTTWQva29zaGNuTUdOc1pNUGpr?=
 =?utf-8?B?TGZsK2t0a05NSU9tQThDWlZPT2VKTThkVHRkbWVjbUwzVmlrQ3QwYmo0L0VG?=
 =?utf-8?B?Y2FOeDFyaGdOYk85WStWZk9DMGNzTTRIdU0zcUZ2VkErb0RIaE9ldVozeTZh?=
 =?utf-8?B?ZlFpVnFkalF2T24rb3gxMGJVK0YydHdjZGJTM3kyRS9RWmtMbnBJM0loWnQv?=
 =?utf-8?B?QXYvd0hmU1FHdGRvNGdqUkhadHhadjRQTGV1NzBNSFh1eHJ0MThUUStnb3Bj?=
 =?utf-8?B?S3FLK09QV3VUanZVczJ5NW04UlpKaHViWW96ZG5tM3hSSHdoN1liREJ3Q0U1?=
 =?utf-8?B?TWtmNXRwN2JHTFRuaWhNdi9rLy9wckhIc041OGlkUTVjKzVkeEJNNkZTUW1L?=
 =?utf-8?B?MUVEWGxhTXljOEN4WGhHZXp1azBxcmlrb1hGT2dua1BySVFuL3VZVHpKWmJr?=
 =?utf-8?B?SklSVjd2d0MyeFhsVTUvZUw2UzVVOGhXdTB1YVZ0UFRKTUxRcHdSZEJZQngz?=
 =?utf-8?B?UzB0cGxDTlJHNGd1NkxGa0Y4bVprSzh4YUVtNUZRNU0yUUs2aE9uK3ZkdW5Y?=
 =?utf-8?B?REs4ZUFCTUFNcWI4SndpNVJpU1dmWE1DR0ZRdU55K2FvWk9haGpaZ2lUL0N0?=
 =?utf-8?B?dGlaR0dtWFlkc1FSb1FFTGM4dFJnc1BUTjc4Y0ZCODgwcFJ4NG5peUZWUDla?=
 =?utf-8?B?NFRtRzBxOUVoVWU4SkFqdVlHN3dDOEdkU3pEeG5oVkEwc056TzF3WEFzdU9s?=
 =?utf-8?B?V1p2dG5NSm1veHdoU0ZHVnVWSzBPeTl1T3A2elU2cmRXRFRreVIrY0tTSUZP?=
 =?utf-8?B?YkVjWEdHQVN0SFo1eWk3MUZMY0RQVFpWd1B0djg3V3R1QmFHYkx6UTdBTHZU?=
 =?utf-8?B?QkwxQnI1NEFpblgzVVk5d1hvbGFOYk8waVNSaDBPM3RQTEFFWHRwSGpNTzJJ?=
 =?utf-8?B?QWtzcXFGT0VrYThSQ2ZOb3NMY0tVZVJrN3VVNzJ6bVFQb3IzcVdhODFEazVK?=
 =?utf-8?B?NDE2bURuRHJXaHI0M3BYNHhVVHlySG1FcWlmS29XajUzMXpzYnNUQkFMWU1V?=
 =?utf-8?B?cUNEeUx4aU4zSURtMHNmSUFQak9xR216cEQ2YVhLS1ZoTkNBMjJrVzB1ckpJ?=
 =?utf-8?B?OWRtSGszMHM1eXI3NWFWYmxNWGZkdTZ6S2ZCWTBHcUI4bWNWUmFsWkRZQ1dR?=
 =?utf-8?B?M3Vkb0lzYVRJNlMwV1h4SUs5V3hVYkRtWS8vZ1hFREI2SGN6Nm1pRFVGU0M0?=
 =?utf-8?B?NjQvMDB2WisrYkpYS2NyRi9NRnVOWGVRRXJUVUh5ZHZsOEk4U0tDdWhvSlRQ?=
 =?utf-8?B?aDhyK0g2cXorWFZ1YTVrc2JWNG5MUnFYR29WODNEOGU5Z2kyOE4vWkFCV2tC?=
 =?utf-8?B?ejZNTlNhY2xESVlIdVE0eVJ3V2I3dC9TaTF6MW13M081SUlDcUxIWGRxanF2?=
 =?utf-8?B?cUJVcHQ2SGJkOHQ3ZXRyVjV0T052YlpoUmkyRXpZa0U4TVBFVXVYSGJISHRn?=
 =?utf-8?B?QkNaNFhGTjE5SzN2YklOaE50SWk1V3hvTVpNa0IyVkZHSjA4bjdXRFZBRXlr?=
 =?utf-8?B?SnJhdkNTMkE5QW5kcjRPOGZNb3B3cnNLOVplOGVIbzA1djViZERCenNkQ3VV?=
 =?utf-8?B?SlZ0bmtaLzJkOEJJdERmbU9KNHNTYkYyelFHekttUFhRWTd1eXJIbVVlNnlt?=
 =?utf-8?B?Zmxac2RGVU1XS1FJZ2F1Y21Qd3UyaW9LWnY3QXRxVU1xL0FrSHZZYURTVGFP?=
 =?utf-8?B?c3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 23df9a44-3aec-4238-4390-08db0df77ceb
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 19:21:20.8964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LhYzfd+j8vi16OF+FBFCTxB2ms9/h5FG/LKrBYAJ21uBgiU6NzO8S+eFmWQUfnMSbV8wPIuDF8RPwU1X6rk2b+Jj/9NJSgVdbY1c8dgiTLY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6048
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 2/12/2023 10:24 PM, Shaopeng Tan wrote:
> After creating a child process with fork() in CAT test, if a signal such
> as SIGINT is received, the parent process will be terminated immediately,
> and therefor the child process will not be killed and also resctrlfs is
> not unmounted.
> 
> There is a signal handler registered in CMT/MBM/MBA tests, which kills
> child process, unmount resctrlfs, cleanups result files, etc., if a
> signal such as SIGINT is received.
> 
> Commonize the signal handler registered for CMT/MBM/MBA tests and
> reuse it in CAT.
> 
> To reuse the signal handler to kill child process use global bm_pid
> instead of local bm_pid.
> 
> Also, since the MBA/MBA/CMT/CAT are run in order, unregister the signal
> handler at the end of each test so that the signal handler cannot be
> inherited by other tests.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you very much

Reinette