Date:   Mon, 13 Feb 2023 15:39:19 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux.dev,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Raj Ashok <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Message-ID: <Y+qR5zC8ZOkVphgv@nvidia.com>
References: <20230210230206.3160144-1-jacob.jun.pan@linux.intel.com>
 <20230210230206.3160144-3-jacob.jun.pan@linux.intel.com>
 <Y+pjTR80bnl9rMK1@myrica>
 <20230213103455.02f3ac37@jacob-builder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230213103455.02f3ac37@jacob-builder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ULYXKrrwDdNIf/axHCXiBqHSZAyYEZogUxe2iFu7u6D5ZqYXfF02oIPUYEqD?=
 =?us-ascii?Q?ON5cRq/DP5vBwDvjKuIbzFiHNLRaUAs0nSzC8rU/HBQ3mLm2QNUPq80mT2dr?=
 =?us-ascii?Q?DdzirG1bgAHCaqzkSXUGWwByg99SBtPvmd0s0Ovhmwat0t+RxlaNj50DEwts?=
 =?us-ascii?Q?gtY/kvs3DxDRI76f3jqVqlPWF5RYZtG8MWwUa17Ek4aCvaol7JOY3IkbEZD0?=
 =?us-ascii?Q?muKPG5ys3CKcPZOrl9MONk3RsHbLy06wpluajtj7ecVmMLbshVXnSEhdBdiq?=
 =?us-ascii?Q?jt50XbfjQh73hOHn2Ba/3bqZPotAEKuHafOaabjLJcfD3toJJH6jxtF4b2r4?=
 =?us-ascii?Q?Kp8s92YLPhC7uVOdE7HArpBZUkHWjP/XzcZ8LuVET6sbHN9VhqQqby0OgjFG?=
 =?us-ascii?Q?P7021D9AOab91FNvGaVlKhAchYaoJafbztH92QKEKSZF9OVbewsg4mChgLyI?=
 =?us-ascii?Q?/JWCMmFWlnx79S7pA+NlJOCK8srvi+9VMY/C2RLh9YDcCMCxc6Z8onD5wI3M?=
 =?us-ascii?Q?QiDjVMjgALE8EqqdfbHmS7eEUZDQu9up24zkpQPgDcK+A6tayv5PlfgjFQwi?=
 =?us-ascii?Q?PrhS7qO6Ocs4KSNsjueFvsh9gofJShvHACorr+XAGS3P43rF5hYzfyb8sJoR?=
 =?us-ascii?Q?VRZuhvJX2qPM0Lk7aTW2z2VeMcETdHmbIr4w01hRb40laRvIUAS1JkURPASb?=
 =?us-ascii?Q?3l46XMeQLprgo01Jo/mH6yc/9DLz1F8BLzEJsDbKODV9+YcvyhrC4T55GB2h?=
 =?us-ascii?Q?We18AjSw8VZxZ2GKdtnkzCHXQ3IhTyN9TxoD/W/Wrg3xpynBtsg4BZ3Qkvjg?=
 =?us-ascii?Q?/fC56eLPgNRLPJIcYMTZUIAmUgvXsLlfOt9h5H3xaxSHRxZP/Zij9VlHeALH?=
 =?us-ascii?Q?Wjpafy5gJ1fiszkRI7jEaewn7CRZlIYDvxiIaUfB3wp86Lm2XjECMZxWdT2R?=
 =?us-ascii?Q?hz/5p3up9F99LOkGRIf8bGlfaxXQR+w4P+X+o65xi8M7ouOcl6tQAslZlFzs?=
 =?us-ascii?Q?a4d0Wmm4KVVxY+GhiHO71nwTKB8DWNR5SK7fpghKq9hL+O0wpyEjVgt9MDJ2?=
 =?us-ascii?Q?PmxOHkrPFxz2fXz1L/FOR69foCZuVVWxD4zDWqg7Jo87sODoDJMhmwwYAInr?=
 =?us-ascii?Q?JKxi3QAvLOW2cG/IFxOBVPDtgbBRs6z/7OdEyHpBUtSI45voZDBDFsSSnOqE?=
 =?us-ascii?Q?BUIXlIOzHXTJrENGzqjLuAaXPMIfct1zINhsY+KO3e60xAZs3IGfV4fn55vO?=
 =?us-ascii?Q?e2ehAqGcpMEe4ERJQsIAXchpU4LUUR3hZbGIhiTOUnwYJFzOwHpMxnobqNFI?=
 =?us-ascii?Q?lZ3vShx01cCjOdLo3UCIcv2O8hXHhNUO1as+Zgz/+D4Q55z36F2ATWd84u7s?=
 =?us-ascii?Q?n+FIO8ZCl0lsDsMfGQX7EFC3Bwaqr89pMjrFumwOHeaKGMf7I+E7nFore2mL?=
 =?us-ascii?Q?VfZKL8uIMZJyOcifPBqQyIr5T1/FbpXhWAiqCunf15IxdGi/gFg8c2gDNl5M?=
 =?us-ascii?Q?rfBxfnw8B8yX6PiRn/Nr3jUsfctudRTS7mjDdNQek2/sjVA0qMipsKcvmVct?=
 =?us-ascii?Q?pTSupLX8bpwiubDLaGW0+arnglD4pKy4F4DKTE/j?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4323be7-dcd7-44e3-d5e7-08db0dfa0084
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 19:39:20.6309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EdLOjD6Z9MRxnMxz9IZNI9XwXsFUO+POG8gwHWEjcbOcqUkX5rm0ywp3X7DtxiK1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6567
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 13, 2023 at 10:34:55AM -0800, Jacob Pan wrote:
> Hi Jean-Philippe,
> 
> On Mon, 13 Feb 2023 16:20:29 +0000, Jean-Philippe Brucker
> <jean-philippe@linaro.org> wrote:
> 
> > On Fri, Feb 10, 2023 at 03:02:06PM -0800, Jacob Pan wrote:
> > > Custom allocator feature was introduced to support VT-d's virtual
> > > command, an enlightened interface designed for VMs to allocate PASIDs
> > > from the host.
> > > 
> > > As we remove/withdraw the VT-d virtual command feature, the sole user
> > > of custom allocator, we can safely remove the custom allocator as well.
> > > Effectively, this will return IOASID core to the original simple global
> > > namespace allocator.
> > > 
> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>  
> > 
> > You can also drop the spinlock.h include. With that:
> > 
> good catch, thanks
> > Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > 
> > On a related note, it looks like 100b8a14a370 ("iommu/vt-d: Add pasid
> > private data helpers") removed the last user of ioasid_set_data(). I guess
> > that could be dropped too, unless you plan to still use it?
> > 
> You are right, will remove.
> I was planning on the other way around which will convert VT-d's private
> pasid data helpers to common ioasid code, but when I look closer the
> private pasid xa is just holding a list of pasid/mm which could be per iommu
> not global. Another cleanup I suppose.

Please lets just delete this entire ioasid thing, it has no purpose
anymore at all.

I did a sketch on how it do it here:

https://github.com/jgunthorpe/linux/commits/iommu_remove_ioasid

I wasn't very careful or elegant with the last patch, can you tidy it
up and repost this as your v2?

Your DMA API PASID thing will simply need one new API to alloc/free a
PASID from the iommu_global_pasid_ida

Thanks,
Jason