Date:   Mon, 13 Feb 2023 15:42:07 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux.dev,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Raj Ashok <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Message-ID: <Y+qSj+xLkqhF7ZE3@nvidia.com>
References: <20230210230206.3160144-1-jacob.jun.pan@linux.intel.com>
 <20230210230206.3160144-3-jacob.jun.pan@linux.intel.com>
 <Y+pjTR80bnl9rMK1@myrica>
 <Y+pkL5b6mGv40nZy@nvidia.com>
 <20230213111152.5ecf734b@jacob-builder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230213111152.5ecf734b@jacob-builder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UxiKCjh/ePpkrCFrVrZeiZJRL0V1lbWlddih/qYiErEBO3JE99XaIP24yhwu?=
 =?us-ascii?Q?5QV4ak03KyTTSaZw+2aRETCfNdN5hOiJckU3O7fWPwic6ZXHDn+c4jBlcO0b?=
 =?us-ascii?Q?f1Qyp4V+9fcwOHu6S8oEkxSt2yQjPp7aDXaf1qnroPzCVhto/PqJRXsaEzwL?=
 =?us-ascii?Q?/tHUZuNJ6m2tDLyzwnpnvyqTLwEzjH0LPeNep73k3gJtiFOq3O2xka5DAbBr?=
 =?us-ascii?Q?W6Ej5t1UFbqBHsXMqumWsd8pqTMqPo4RsbMvJj/Hd1L+fDadJSfpp6auLalX?=
 =?us-ascii?Q?xQMSoc5SfIuA5Ltbh16pBKuOGOrzltE0vlF038Kt0FitzkF1vpyK0MX9LHVC?=
 =?us-ascii?Q?POf4jadVoM5RVOc7ynAou0AOIYPeLw6i4JpBUs2WQgCTg4VQ7s8ghAIQAMUn?=
 =?us-ascii?Q?d9/eLPgMRFdf66w4apuC6AomyG5oTGrD+vEIvaxtmNUadeZwd9y6rJ5X8eAM?=
 =?us-ascii?Q?RNL+pQ56O3X+uv/qSt+ZgQHIJERH3tkhkeQutJPu2sRUQLFeSwgXEVb8jWQ6?=
 =?us-ascii?Q?12cDpO3c7zPkfiCbWgWtPMzEVT68XnQUt97S8a3zK9XV2QuMK56PScFVxVKI?=
 =?us-ascii?Q?7Y3TkxGZb8h77N5y8gy34fa3l4RECrGy+Hvq5LM5zCFBlh//m9nWDhejGsKo?=
 =?us-ascii?Q?XFCSdgA6JOr4kWJqjp63q8/8ByVLCf6fXWJl14StgBVDcCExYERkKmQlVRg9?=
 =?us-ascii?Q?T2qPC7x78FkWfsElOvsvGcwuabZ5552s6vMYcuXZuR4aTpKFJgIXOmZEmfGV?=
 =?us-ascii?Q?qh++6HgrVjcw/tYjVNpN/bXgTcqQzVOYuPoNjwJfm9akP+Wn8Y+tX4NbolJZ?=
 =?us-ascii?Q?jKGqJych7gyzLTBROCvJpgpzvISY2fc/ikp+kzv87Gij4wlOk0MfT0gLX9KX?=
 =?us-ascii?Q?FLNsennLsF1MbvGC4Qo9d7hujHV9eccnonDWjgLLy6F2lDM5LvCkwO5jpjpU?=
 =?us-ascii?Q?SjOyrGbVp62fa4lrPbMipZUS0dQIWDbaqIVy76DAZ6xLD4rtRW3Hu3/S8GUb?=
 =?us-ascii?Q?1X16F3DmGW99YGsrN9hNECIVvwBv//FZn0ib+tQ9DjPi5Z6ZVHQotZRWk37N?=
 =?us-ascii?Q?a2TjxEPHVQjcAG8IuKfB1nAETOemCJzoQeHgYWYOkeTyIrvDRCgxsWlBOEk2?=
 =?us-ascii?Q?q5XNwZlB1/7LzfBCyJBRS3ctU/K3SinjxNv35n8WC6wdwE8KKzGrtIaiK/+E?=
 =?us-ascii?Q?K0UBdLFn/8O9vVrV7ab9BG6oIyo4TBbg60DS1+IBKWt7RGlkmjXi58dnNdut?=
 =?us-ascii?Q?y5bnYvZR00pR/UEwhpqMKs/lO5YU2J8IZ8JUfIEp6lGdPwQOjIYpm7Q6nyvq?=
 =?us-ascii?Q?SDoVhik/0f3MvC38I/FHjmyhPq8MFr7rj5bX3YECPXGR/p+slccWPsphzr31?=
 =?us-ascii?Q?9PfCQk3E/bSI+KAXYPUqnmLRvqtOQCTpslHzapqXn5kEo+iTJrh8ejbJ8/88?=
 =?us-ascii?Q?0h5oKcfXdTrGNUFkgSRMidqrSztOC9CLRZg6ZoOWNr4rG9/rKC47RNQYsgjT?=
 =?us-ascii?Q?iB51RNI4EUm/wg2G+0Ig9RnHOZFmkkAV6UjLbufQ3BqRgi36XnB7EJrnnOZf?=
 =?us-ascii?Q?/lvcEdTQrDOjtVyvagaM0R0a4SovLnYe29LiVaZw?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebf1eec-8cf5-4840-985c-08db0dfa64a4
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 19:42:08.5644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7FVa/2TqpYECJ8BwuDjvab4GwoH7Hu/7HbuCeB4ZG10fRGmyCtFQowtu9s9oGhhK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7518
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 13, 2023 at 11:11:52AM -0800, Jacob Pan wrote:
> Hi Jason,
> 
> On Mon, 13 Feb 2023 12:24:15 -0400, Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > > We could also merge ioasid.c into iommu-sva.c at this point, since I
> > > haven't seen any interest for having multiple IOASID sets on Arm, but
> > > I'm not sure what the current plan is for vSVA on x86.  
> > 
> > Once the customer allocator is removed this is bascially a thin
> > wrapper around xarray
> > 
> > So anything that needs multiple pasid spaces should just create it on
> > its own directly with xarray
> > 
> Just wanted to double check that for devices on VT-d platforms that support
> both SVA and DMA API with PASID, we will still need a single global pasid
> space (due to IOTLB tagging). 

Each driver chooses the PASID allocator it wants to use.

If the driver uses SVA then the driver must select the global SVA
allocator. If the driver needs PASID's for other purposes then it must
get them from the SVA allocator too.

> As I replied to Jean as well, we could use the ioasid_set to separate SVA
> and DMA API PASIDs.

That doesn't make sense to me..

Jason