MIME-Version: 1.0
References: <20230213010020.1813-1-michael.christie@oracle.com> <20230213010020.1813-2-michael.christie@oracle.com>
In-Reply-To: <20230213010020.1813-2-michael.christie@oracle.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 13 Feb 2023 11:57:12 -0800
Message-ID: <CAHk-=wg+q2KWMzw1XG_p8=taG1UaiiuUEeCJ4wmX+xrHi=CV6Q@mail.gmail.com>
Subject: Re: [PATCH 1/5] kernel: Move kernel_clone_args's fn to new struct
To:     Mike Christie <michael.christie@oracle.com>
Cc:     brauner@kernel.org, ebiederm@xmission.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 12, 2023 at 5:00 PM Mike Christie
<michael.christie@oracle.com> wrote:
>
> The next patches will add callouts to set the task's comm, and create
> internal resources. This adds a new struct to for these callouts to
> organize them and reduce the args passed into kernel_thread and
> create_io_thread.

This patch too seems to just make things more complicated for no reason.

When the point was to make things simpler, adding a (pointless)
indirection through another structure seems to be against the whole
idea.

The code is neither simpler not more legible. Quite the reverse.

            Linus