Date:   Mon, 13 Feb 2023 12:16:59 -0800
From:   Patrick McLean <chutzpah@gentoo.org>
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-core: Disable READ LOG DMA EXT for Samsung
 MZ7LH
Message-ID: <20230213121635.001a2a65@moya.linuxfreak.ca>
In-Reply-To: <d2a0c3bd-d7ef-85ff-6268-712c098e9d32@opensource.wdc.com>
References: <20230210215151.812839-1-chutzpah@gentoo.org>
        <d2a0c3bd-d7ef-85ff-6268-712c098e9d32@opensource.wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 11 Feb 2023 12:12:23 +0900
Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:

> On 2/11/23 06:51, Patrick McLean wrote:
> > Samsung MZ7LH drives are spewing messages like this in to dmesg with AMD
> > SATA controllers:
> > 
> > ata1.00: exception Emask 0x0 SAct 0x7e0000 SErr 0x0 action 0x6 frozen
> > ata1.00: failed command: SEND FPDMA QUEUED
> > ata1.00: cmd 64/01:88:00:00:00/00:00:00:00:00/a0 tag 17 ncq dma 512 out
> >          res 40/00:01:01:4f:c2/00:00:00:00:00/00 Emask
> >          0x4 (timeout)
> > 
> > Since this was seen previously with SSD 840 EVO drives in
> > https://bugzilla.kernel.org/show_bug.cgi?id=203475 let's add the same
> > fix for these drives as the EVOs have, since they likely have very
> > similar firmwares.
> > 
> > Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
> > ---
> >  drivers/ata/libata-core.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index 2ea572628b1c..c4c89d24f84c 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -4045,6 +4045,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> >  	{ "Samsung SSD 870*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
> >  						ATA_HORKAGE_ZERO_AFTER_TRIM |
> >  						ATA_HORKAGE_NO_NCQ_ON_ATI },
> > +	{ "SAMSUNG*MZ7LH*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |  
> 
> Are you sure about the upper case here for this drive model name ?
> 
Yes, the drive model name is upper case. We have tested this patch and
it does resolve the problem on our hardware.
> > +						ATA_HORKAGE_ZERO_AFTER_TRIM |
> > +						ATA_HORKAGE_NO_NCQ_ON_ATI, },
> >  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
> >  						ATA_HORKAGE_ZERO_AFTER_TRIM },
> >    
> 
> -- 
> Damien Le Moal
> Western Digital Research
> 


--