Date:   Mon, 13 Feb 2023 13:28:04 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Yazen Ghannam <yazen.ghannam@amd.com>, Tom Rix <trix@redhat.com>,
        tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
        rric@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: remove unneeded call to
 reserve_mc_sibling_devs()
Message-ID: <Y+qdVHidnrrKvxiD@dev-arch.thelio-3990X>
References: <20230213191510.2237360-1-trix@redhat.com>
 <Y+qZthCMRL1m0p4B@yaz-fattaah>
 <Y+qcU2M5gchfzbky@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+qcU2M5gchfzbky@zn.tnic>
Precedence: bulk

On Mon, Feb 13, 2023 at 09:23:47PM +0100, Borislav Petkov wrote:
> On Mon, Feb 13, 2023 at 08:12:38PM +0000, Yazen Ghannam wrote:
> > These errors are encountered when extra warnings are enabled, correct?
> 
> It says so in the warning which one it is: -Werror,-Wsometimes-uninitialized
> 
> Don't know if we enable that one for clang with W= or Nathan adds
> additional switches.

-Wsometimes-uninitialized is part of clang's -Wall so it is on by
default in all builds, regardless of W=

-Werror comes from CONFIG_WERROR, which is enabled with allmodconfig.

> > I think the following patch would resolve this issue. This is part of a set
> > that isn't fully applied.
> > https://lore.kernel.org/linux-edac/20230127170419.1824692-12-yazen.ghannam@amd.com/
> > 
> > Boris,
> > Do you think one of these patches should be applied or just hold off until the
> > entire original set is applied?
> 
> I still wanted to go through the rest but I'm not sure I'll have time
> for it before the merge window. So unless this is breaking some silly
> testing scenario, I'd say I'll leave things as they are.

This breaks allmodconfig with clang, so it would be great if one of
these solutions was applied in the meantime.

Cheers,
Nathan