From:   andy.shevchenko@gmail.com
Date:   Mon, 13 Feb 2023 23:56:33 +0200
To:     Werner Sembach <wse@tuxedocomputers.com>
Cc:     mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com,
        linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx
Message-ID: <Y+qyEVxMh4VRIsy3@surfacebook>
References: <20230210164636.628462-1-wse@tuxedocomputers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230210164636.628462-1-wse@tuxedocomputers.com>
Precedence: bulk

Fri, Feb 10, 2023 at 05:46:36PM +0100, Werner Sembach kirjoitti:
> commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
> changed the policy such that I2C touchpads may be able to wake up the
> system by default if the system is configured as such.
> 
> However on Clevo NH5xAx/TUXEDO XA15 Gen10 there is a mistake in the ACPI
> tables that the TP_ATTN# signal connected to GPIO 10 is configured as
> ActiveLow and level triggered but connected to a pull up. As soon as the
> system suspends the touchpad loses power and then the system wakes up.
> 
> To avoid this problem, introduce a quirk for this model that will prevent
> the wakeup capability for being set for GPIO 10.

Please, update the commit message and send v2.

We would like to have this fix nevertheless, because users will suffer w/o it.

-- 
With Best Regards,
Andy Shevchenko