From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>
CC:     "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] Support NVIDIA BlueField-3 GPIO controller
Thread-Topic: [PATCH v3 1/2] Support NVIDIA BlueField-3 GPIO controller
Thread-Index: AQHZPWNgnp9EGxTKw0yj8uaPzkWZSa7Jo5cAgAN3lhA=
Date:   Mon, 13 Feb 2023 23:14:06 +0000
Message-ID: <CH2PR12MB389571F58AE1F8BF2196DC10D7DD9@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <cover.1676042188.git.asmaa@nvidia.com>
 <c1bf45a868edcd3df5263fa76a32b28e6c9ca3d1.1676042188.git.asmaa@nvidia.com>
 <Y+eBRLB0Q38vGtjR@smile.fi.intel.com>
In-Reply-To: <Y+eBRLB0Q38vGtjR@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nPizLL1aNfc1DjFGlTyXRxd0LYg/bKrloofTxh4ySqNqENJ+LA8WjMz7K4lS?=
 =?us-ascii?Q?xuEs0yiWMrpsWUmBd7bvgeDuWG+kezeD9SuFxRhITpKmeedMluiDp2dn0Io5?=
 =?us-ascii?Q?0g5mvvhsNvaDYOouv1vUz6GYrbahLzgxq8IuJhcCYr7X2qV5IHLd6SIs4h6y?=
 =?us-ascii?Q?AIqRcHPAD1NqQ8W+7dvtaeKJ8MltPl0Y+BJC0w5P2cZ5KAco1S5FPyba28+m?=
 =?us-ascii?Q?eSUlfXG2DsPZgyOuxFLcHGhF4zf0DiJOiNjgLIPwIu32AqNhFYr4OSfiRVsc?=
 =?us-ascii?Q?3DE0cjtEtPPF20CRKNWhPT+0M/w5FMS6ur8rcCKgP9f3rQ6Qn6g8DkBeUFvS?=
 =?us-ascii?Q?L3geOQeIyUreQJ07Wg/rUSMEiz3CEx3XJbG7UKBKy5SGVnDxCdojty5rgNQn?=
 =?us-ascii?Q?tTBg4w8Hodrk7TRRG19G1HKBm4nOGmH4e4MNtO/Ahih9OMY41EwtVq8/zoBv?=
 =?us-ascii?Q?spD5PptuSO71GwZ227lWVWeFBiE0+XwqTtVnI3qJuWydd4zkOecuDmwy6lq3?=
 =?us-ascii?Q?p7kD7nOs5LgbyQcT8MlXWpMJETnRwo2Rl2+bM2lX9RVpa4GUnB+PM7VIRaDA?=
 =?us-ascii?Q?R55cPGyjPdoFD04V17dCjV8PM/lk5FF1w2igM2RBY7efhNJ+evaiW6/cRnFD?=
 =?us-ascii?Q?LnJOW6sjoZYlVlb7BcsCWroXnAyfWqPe6qS5S32tKpuzxjSymLMPKI75hP0Q?=
 =?us-ascii?Q?8StvH592fAUFJ2gMseZWdL0derhw6YmFkkQKfLDUw09DuzMg+mVgSabB7Twq?=
 =?us-ascii?Q?z79TFhl5e82LiIhBRcy4PZjI3fjxkPpGg2wVhK9ugzZFVtETtOGc036ShrIv?=
 =?us-ascii?Q?GwF3ApObrRy3z/xQ53ezT6EKlBNLxEwf4w/Ymo0ewy2HaCEFQQ0NEpb2olcj?=
 =?us-ascii?Q?lcyLGII5fBhlrfkVrwO144BoCA5MFoj7Zay3twT9Q1TtBBy++CwSxCy1Hs0L?=
 =?us-ascii?Q?19HAINMT6xbwgIAamaAp4I6yS4XC5M1Q2zw2h2PoIXptuRHDSee0lYNpSthV?=
 =?us-ascii?Q?/Mn3VQOOEmmNaz5WB3BmjABNQZkbyASWi91Qb68H8JfT8wq741Gll3nk9/Vg?=
 =?us-ascii?Q?mDv2ch7sWp7xHpY8xGVlou5KlyLTuQGg2CQ+k0Kl9TuPQjZsDDrnrD18S8ZC?=
 =?us-ascii?Q?M7406Xme+dcMTY8dl19yTvgdY5Q7qNzj8vXkFKqvSwXjz783TVJ5Fgee7JEN?=
 =?us-ascii?Q?2hh25QhOqPSv1GbHMAKtvxH/rkT0z6+MIyXInDZmrCyUyzmkkc7UEdg9Lblv?=
 =?us-ascii?Q?+yHSQnbru+16VsH8TuK3khrV9HS1mVcmpd1cmzUUE4XR3e/lbc8/iUyQNUQA?=
 =?us-ascii?Q?rlx3EMwgJrpIdBAr7m8SKKm9kOoMLvMV36GwsD+uh+hRLqvKfQAiHCthT4AM?=
 =?us-ascii?Q?6JaejoTPNU5fbeFPznDjv1zipCz9yQ07e9zCV3JZjwK3Ezgda1tP2oEfydAH?=
 =?us-ascii?Q?gJbZNYmjtDcsQ1WXDU0dz3f6aPPn+uYbXkLsEqs2Cp/qglTVo9rKBbM20zKk?=
 =?us-ascii?Q?aMLVsVzdL5hnmRMnEvz6RBOKLFyMKq0OmU2FICyaxD9sMcRXo+Mq9B04s8tI?=
 =?us-ascii?Q?20dHMuIeud46jT4op7A=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72215102-ae93-49c8-9877-08db0e180128
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 23:14:06.4030
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oLweDbZOsv3BbUuu4gKBxqWujycdZytbY5G1NwcuO0CU0g7kiYLDUOxoFcjIGf0K4/78xi2etISkOF9oIIQRUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5081
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Andy for the feedback! Will address your comment in v4.

> +		generic_handle_irq(irq_find_mapping(gc->irq.domain, level));

There is a helper that unites these two calls together.

I didn't find any helper in v6.2. Could you please point me to it?

> +static int mlxbf3_gpio_init_valid_mask(struct gpio_chip *gc,
> +				       unsigned long *valid_mask,
> +				       unsigned int ngpios)
> +{
> +	struct mlxbf3_gpio_context *gs =3D gpiochip_get_data(gc);
> +
> +	*valid_mask =3D gs->valid_mask;
> +
> +	return 0;
> +}

Why do you need this?

Since we only use ACPI tables and we want user space (libgpiod tool) or pos=
sibly (in the future)
other kernel drivers to have access to certain GPIO pins, we use this valid=
_mask to do so.
Linus previously explained that if we ask for a GPIO then it will be muxed =
in using .gpio_request_enable().
And so we would use .valid_mask to restrict the use of certain gpios.