Feedback-ID: ie3994620:Fastmail
Date:   Tue, 14 Feb 2023 03:45:10 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Juergen Gross <jgross@suse.com>
Cc:     Borislav Petkov <bp@alien8.de>, linux-kernel@vger.kernel.org,
        x86@kernel.org, lists@nerdbynature.de, mikelley@microsoft.com,
        torvalds@linux-foundation.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 2/8] x86/mtrr: support setting MTRR state for software
 defined MTRRs
Message-ID: <20230214004510.4qfcsxjy3sqbzl5z@box.shutemov.name>
References: <20230209072220.6836-1-jgross@suse.com>
 <20230209072220.6836-3-jgross@suse.com>
 <Y+ohfE/wICFKO/93@zn.tnic>
 <6257114d-a957-f586-145c-d2a885417360@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6257114d-a957-f586-145c-d2a885417360@suse.com>
Precedence: bulk

On Mon, Feb 13, 2023 at 03:07:07PM +0100, Juergen Gross wrote:
> > So this here needs to check:
> > 
> > 	if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR) &&
> > 	    !(cpu_feature_enabled(X86_FEATURE_SEV_SNP) ||
> > 	      cpu_feature_enabled(X86_FEATURE_XENPV))) {
> > 		WARN_ON_ONCE(1);
> > 		return;
> > 	}
> > 
> > as we don't want this to be called somewhere or by something else.
> 
> Wouldn't !cpu_feature_enabled(X86_FEATURE_HYPERVISOR) be enough?
> 
> I'm not sure we won't need that for TDX guests, too.

TDX guests are covered by X86_FEATURE_HYPERVISOR.


-- 
  Kiryl Shutsemau / Kirill A. Shutemov