Message-ID: <632ec3c6-0a1a-1c65-f85a-06f594b72a9f@intel.com>
Date:   Mon, 13 Feb 2023 16:59:08 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH 1/4] selftests/resctrl: Change initialize_llc_perf()
 return type to void
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
References: <20230208094026.22529-1-ilpo.jarvinen@linux.intel.com>
 <20230208094026.22529-2-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230208094026.22529-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVE5SFA0WExDRkRXNlNhVDVCMGlFd05aTWlSUzlNSldXZncvaVFKV0VlcjRM?=
 =?utf-8?B?Z1d0ZDYzOXlTY1NPY0lZNEFBOGtTOFhUdURuNVBWTExiRCtNdjlpTU1yWURo?=
 =?utf-8?B?YzR1NExPZ1lpeGhnWFZmRm1Md1ErMzNoNmxHVG81eWZyUlZ4NFNMN2R0YzEx?=
 =?utf-8?B?V2M4SjhoSGh6Uzc2ZVlXQVVUUi9YeUVoUm5hMXdUV3g5c1JGcW15YUNpWWJF?=
 =?utf-8?B?SDRiZ2VmaFJ2d1JjRHRRNlp2TEJ1WUZRbkZqU2tqUG40a08xazhvQWgwVGRZ?=
 =?utf-8?B?V0ZrYSt1OG11Y3pnUWpiZ3YrQ05wRHRrM0h2azBOWGdZdnRzZVdCQmdoNTNt?=
 =?utf-8?B?SzZ6VmRGczhVR3prcElQVS8vajkzUHJEZGJmY1F4djVDVDJ5WTJFbURXeUVR?=
 =?utf-8?B?bnQwMjV0elZLcGdkNXZaNmR5UkRxSlJvUkdRRWVNYTVuOGhBVE9yZ0hES1JJ?=
 =?utf-8?B?NCtyWVJMT1d6L2NydXNyUk1RVUlZOU15UmxCcmg0YlJ5VGNRdnRSeno5QXB6?=
 =?utf-8?B?VTArd0Q2eTEweFRZOGdXMkhYcnZsY3R5RXpYUTI1U0hMVThMUzF5a3l2N3Rt?=
 =?utf-8?B?VFFyQjF5ak90cU9iakErbVN2WGZHcGZIZk9SdDVMeWNCdHlmTUIxRkVEQkNk?=
 =?utf-8?B?NzRjOXQvR0xDUEhUSUN4TGwxWVRUdmJjY2FERlB5NlN0Yk93R1BHZXVBNXZD?=
 =?utf-8?B?bVlENFh4cHMrUG1mSlZZS3dwSFpJaHRhTVBqczBRRG1QK0RLN3o5VXBQOUVR?=
 =?utf-8?B?K2htUVJuaytuWlVKUUdUazZWUE5HRXl3bFMrRG9ybzJib09WTlZtdXJmRzFr?=
 =?utf-8?B?R0xmeGduZ0hCOVMzR0JnK1QwRWQyeGpVcnI2V0diNmFjdzZyRi92TklWQ0ow?=
 =?utf-8?B?VVFrM0h2d2VzSytaNmVxRnRjMExRTm10SnJoZko2R3pkY0RwUUh2UU9ZZmlP?=
 =?utf-8?B?RWpGMzhNQ1pJTEVEdzRRaHZuMWs1WWdMcForbmY2ZjFCVTk0RHM1NEJZak1S?=
 =?utf-8?B?eDl5TmtOZDIvY2FJajZkNEpWZWRoTzZjWW43YXh6Rk5kVGZSeVk5VEV2OXUy?=
 =?utf-8?B?NVBnSWFaRWZ3VTd2bENTM1pUNisyV2pLd1RUdlJIc3JkNk0wVjdkdEM3TGFE?=
 =?utf-8?B?dTdqTWsyOUg3aTh5U1h3eDA1UG9JelF1a3F4Y0p2N1pqeUpHZ2FhTWhLN0pp?=
 =?utf-8?B?TlJ3QnJ6WXNUckJHV29LZnlTdzJPWHg4MVdYQ3gzR3lkT0I2SWdVVldjWEFV?=
 =?utf-8?B?bmRLcHJid2k1VUY4M2ZrOXVZMXREajRJS0o1OHdreFB4aldsYUZMRURJTmVT?=
 =?utf-8?B?ck5oMi9sazZRWmw5Slk5M3FHd3BMamltZGtnRG1sMnpGdGJtSUlSalZ0Umw5?=
 =?utf-8?B?MFJjUDBxTDNyL1ZQcEk2NlhzUHlsSk1XQTNpbFhNbTdIRjF2Y0hRMkl0bW1J?=
 =?utf-8?B?VStwa0o1b2NmdUxRQkhGNDZpK0FxQlBmR0xpWWZqMWxjTUcxdjN1c0pRbVlS?=
 =?utf-8?B?d1JPYmNpYmU0SUdtcGxFWWdkR0NhTTdpS3QwWkVKU0Rod21WbWhVVEFQQVJD?=
 =?utf-8?B?UThSak4xWTd1di9zUml2NmFZcnhVckxMckFIWmhKSVdNaU9QdmRTQkVRUjlj?=
 =?utf-8?B?TVk0NlB1WjgvY09JdGVUUUlmeEoxaEMyUVFwanI5bFh4U3p1a1pHb1FUUEx4?=
 =?utf-8?B?YmtNMUJjeEhaSE1HZVNycjExbGVWSWFxMnVIYTEzWUNVMXJXc1BFU2lxRWxi?=
 =?utf-8?B?WHJYS2syZjMzby9CaUdqWld2SnRkUGQwamF1dkVqSTQ1RG1NbVZxTUh6TEN3?=
 =?utf-8?B?QzAwVzgrYzMxUDROS3lhZnFrVmJIOS8rUU8xbWhDbVRLMW1GSVFHTmFsN2lR?=
 =?utf-8?B?aXlWZm9NODRlUlhKcGpiU0hBcEJiQVZPeVFPcVpGdlh1aFdUWDhOTlZpM1Zr?=
 =?utf-8?B?emE3NUQrZU56MkdRM1JZQlJvVnF2enU4Q3NqYVRqMEtmZWlHWG1iSkVVN1dM?=
 =?utf-8?B?bzBtWm5tVXd1TVVVUi9RYS8xL014U3BYSHQzL2ZPZXhJMENlNUxzQlc1TDZF?=
 =?utf-8?B?SVZtSHdSaUo2dXRVbDFMMktZcUd4SFpXUDNWSWhveVJCNGxkVmo5MTI5Wm42?=
 =?utf-8?B?YnJ1ZW1NQkhLQ3ZyWjNCdzMvWlVoN1Q5WFV2YjllNHduTzU2Um9FL3dvWXVy?=
 =?utf-8?B?dnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 914e9fae-845c-4e7b-1580-08db0e26aefc
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 00:59:11.4421
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LbMBmaAFhI7koySWiDofdz7kDMJTxMTBe778BCAcTBtuvC3cXeAwYG09pqPbRm8JU/+stkzojWoohHPCU2k4Z9dUkS59RnRe2nf/Kgp4IZg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4602
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/8/2023 1:40 AM, Ilpo Järvinen wrote:
> initialize_llc_perf() unconditionally does return 0 so no point in
> having it's return type as int. Hence, change it's return type from int
> to void.
> 

Thank you very much for contributing to resctrl. As a new resctrl
contributor I would like to share that resctrl follows the x86
style guidance and to be consistent this is for the most part
true for the resctrl selftest area.

To that point, changelogs are easier to read if the context, problem,
and solution are clearly separated by placing them in separate
paragraphs. See "Changelog" in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst

Please compare to a changelog as follows:

"
initialize_llc_perf() unconditionally returns 0.

initialize_llc_perf() performs memory initialization, none of
which can fail.

Change the return type from int to void to accurately
reflect that there is no checking of return value needed.
"

For such a small change as this, the changelog could possibly be
simplified but the context, problem, and solution should always
be clear to the reader. This may be significant changelog feedback
for such a small change. This is because it is your first patch to
this area and my goal is to point out the style that will help
your future resctrl contributions to have the pattern that
x86 maintainers expect.

Reinette