Message-ID: <8ed0dcbd-86af-2658-95de-fdccffba7728@intel.com>
Date:   Mon, 13 Feb 2023 16:59:29 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH 2/4] selftests/resctrl: Don't hard code divisor in MBM
 results
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
References: <20230208094026.22529-1-ilpo.jarvinen@linux.intel.com>
 <20230208094026.22529-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230208094026.22529-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?endvSll5UDJ0YzFFb2x3b1c0WlVKQVpwTEN0aUhQTndwSnBYQWNpSWZtay90?=
 =?utf-8?B?OTV6aThnVVRpeTg3andXUmZkT2JRWkNiR20yelZyQ2lDTDExOXBMcVZOY0N2?=
 =?utf-8?B?c005NlEzTCt2OXRKbmduSFN5ZFQrckdXSXA5YlVSdnRNK0c3a0x4UWY5UnNW?=
 =?utf-8?B?bEluYTZwclAxRmVCS1gyblRVTm41Q3FjZE1xcHBMWVBkd3RzUUd4clBRUm4r?=
 =?utf-8?B?ZWordGE0N0c1ekFnRHZrUUZxQ0ErNjUvSThRb0xNRFlOQmtJSFRLeFdHOStO?=
 =?utf-8?B?SitDVnhBcm14U0l3WE5yVnZoU0pyblhMaW1ReWF2bStpTWk0RHo1ckpqU1Ni?=
 =?utf-8?B?WitJUWkzcFc4Z3NiVUVka3UyV3dTZjNJLytBVVlIc1ZaTVRCQkwvalJIVzAy?=
 =?utf-8?B?ODZzVC83MGZpRmhTUFlEZmhSWW8yVEtOamJMdVNvRDlJc0NRZVpscEtraEkw?=
 =?utf-8?B?bFJvZVR2Wm5Ock1Vdy93WWhMZnR6cURHZXlsOUFvSEdabnBwT0FQdDJIUGIy?=
 =?utf-8?B?V09FQ21FUFI1MlZBWXJpemxucW1hZE5iZjVXWkE5N0x3OEcwYTZ4YWJJcXI4?=
 =?utf-8?B?a2tTclBvcGlkZ0dpSHYxUDhqZS9JWnVCTDJlc1B1QXdoR2VuRTNyc0VpaFo3?=
 =?utf-8?B?aGF5ZGh1dG00ZkNRZTRscTF0akEwaXZGdW5jMUY5dlhWM2x4cUVMMnVycWxI?=
 =?utf-8?B?UHN4bEJGY3JxUk5ZdnlxNU5VWG5WZUtXN0pBU1ZTenkwNHd3Z3FGQkhWM2lk?=
 =?utf-8?B?UTNrbDV1OVBMSlFrMnYrTXVEWFFFdnJJcGQreWNCUzZCVnVtWC9aSGoyZjdW?=
 =?utf-8?B?SmluV3d2alQrT0J3OVJCeHduRjhVd3FJS2FCN0JGZHpndVJkSnZBL2MrM0d5?=
 =?utf-8?B?blBURUcwQ1E5T2Z4am9FSURmZGVqQmJUVnllV2U1em5vTHRwd0RDc1FzWGhC?=
 =?utf-8?B?NTVLd2NKU1lIME0vQWQxaFdxK0RLM1h2VGxKTlpLYXAvdkxaNXBsYnFCU3cv?=
 =?utf-8?B?VWJ1QW8zSW4vK3ZEd25nQWlBR1ZrVURrWXo3K1AzUk1nUGQwSS85MFZIK1U1?=
 =?utf-8?B?UHZjVEZRcVpsUWJoS2lsMFpINW90dTRFV2RpRkVrb3FrdUM0T0tyTkphYkda?=
 =?utf-8?B?L0dyVWg4dGpBanJwc0RRNFpnczUyNU5sbjgxT0NEd05yRXpRdFlTOUEzV3lN?=
 =?utf-8?B?eGozT3gwbW1ybm5EMlV4blR6c1VPRjNJeTNWb05TdFlJcm8rdDJnYldPVmFu?=
 =?utf-8?B?UTd2SGVtQlBSRUtvcThLZlA2d1JBV3kxd09pQWFGR0UzQjdvL3lWdVZpLzlU?=
 =?utf-8?B?Tnc5Skd4bXZ0azgrWU9FbTFzQXdNcEUvT3lSeWpBaGZOa1RQUUpqRjYydk01?=
 =?utf-8?B?ZEt4cytnUzZENDNqZmRLQ1ZwVEZiQjVQdG5MSHU2cmh2MFZ6Y2cxbzhMZC8w?=
 =?utf-8?B?NmluSEN4dmx2YVN4U2cvQkZWTE9yckhvRDRpM0YzaDNKYS9jQXBmeXNtbEMx?=
 =?utf-8?B?Y3VVdzcyNEJGOUhqRGJrK0gyNDVaT0FUNXVEck9QSnVLalQzb3dycnptNHB0?=
 =?utf-8?B?d0N1RHNaQkRQYlMvbldjdEc4NnZmb2FwWlVEY0xKUENXLytva0svRXJGbkdS?=
 =?utf-8?B?bW40UmhjSE9zU2FSR2NUcGNBTFRncGxVSjBrcHJTdk03aDBSeUcxS0piL0ln?=
 =?utf-8?B?VUhTMHRzb0dzVytDYjVNS05FUERGTklFWnhFY1R2UkRJWGdVME5BNnNlR0dz?=
 =?utf-8?B?U0NDc1JyOHV5eHhVMHZIRno5VERSU1FyekVOVk5nSWNEd21JVWdTOEFDVnF0?=
 =?utf-8?B?L3QzcFpGdDdMWlIwdVV1WXd6cFFTeTRubk9MYmJzS2xUaHZyQ05UaklBVzB5?=
 =?utf-8?B?Wnh3Q29PRXFPSWdmTDA3eFl3cnlsd0xxV1JiVkk0ZWE5OHBKWUcydHFuVWFZ?=
 =?utf-8?B?OUxMVGdWMWxYZnJNbHVtMFhHckEraU1HYWtOL3BBSGlqRHM2OHhpVDkvUVEw?=
 =?utf-8?B?ajlPbTZkeVRUOThuNStNdTZZdXBCV0x3ci8xdENaa0EzZjM3endqNkhaTGYy?=
 =?utf-8?B?NVA3MkdmclNEYjFoOU5QcUtEV1JhbDVDM244VmVqS0VYUW5WUllzcEpJR2lS?=
 =?utf-8?B?THpmRzVIYW9qRHVxeW5JSnFXakJXK00yNXQ3MklyZk1IcHc0VFZGSEFWT0Yr?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 22403a82-7b75-4c9c-f890-08db0e26bae9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 00:59:31.2217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uFQY54AFhE68YI5ULOppGnA8QNnXKYn6+AYQ/CIZl/7Dw/DYucymL3guetzd+nwiOKaZRqxFPa7fI/0vd9gsIx/GvphS/rgnhqfsw9uW4hY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4602
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

The subject is "Don't hard code divisor ..." yet it seems to me
that the hard coding persists. It is just changed from a magic
constant to a macro.

On 2/8/2023 1:40 AM, Ilpo Järvinen wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> Presently, while calculating MBM results, the divisor is hard coded as 4.

"Presently" can be removed. Here and in the rest of the series the usage of
"presently" and "currently" can usually be removed to improve clarity.

> It's hard coded to 4 because "NUM_OF_RUNS" is defined as 5 and the test
> does not count first result and hence 4. So, instead of hard coding the
> value to 4, change it to NUM_OF_RUNS - 1.

Are there any plans surrounding using struct resctrl_val_param::num_of_runs
instead?

> 
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Missing your Signed-off-by?

> ---
>  tools/testing/selftests/resctrl/mbm_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
> index 8392e5c55ed0..4f85cbbfd037 100644
> --- a/tools/testing/selftests/resctrl/mbm_test.c
> +++ b/tools/testing/selftests/resctrl/mbm_test.c
> @@ -31,8 +31,8 @@ show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, int span)
>  		sum_bw_resc += bw_resc[runs];
>  	}
>  
> -	avg_bw_imc = sum_bw_imc / 4;
> -	avg_bw_resc = sum_bw_resc / 4;
> +	avg_bw_imc = sum_bw_imc / (NUM_OF_RUNS - 1);
> +	avg_bw_resc = sum_bw_resc / (NUM_OF_RUNS - 1);
>  	avg_diff = (float)labs(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
>  	avg_diff_per = (int)(avg_diff * 100);
>  


Reinette