Message-ID: <88a819d7-b236-aed5-7cb8-6659e3f9f405@intel.com>
Date:   Mon, 13 Feb 2023 17:00:27 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH 1/4] selftests/resctrl: Return error if memory is not
 allocated
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
References: <20230208093016.20670-1-ilpo.jarvinen@linux.intel.com>
 <20230208093016.20670-2-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230208093016.20670-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU9yMzNYYVBNVnhmRDJBTXZHWEw1YUFRc2grUDdPMGNvanNkUk1RV3o0bE9S?=
 =?utf-8?B?K0lCeXpUc3ozUFBySGNObFZLOEVuU09kbDZ5bmk4MFpvcjE1MmxmK0oxdHZY?=
 =?utf-8?B?aU5odDVZUituUGN2NmxnRmhTRzFCUm04THAxZDh2YlcyU3lNK1c1bncyWEV0?=
 =?utf-8?B?eUszTk9rNEQ5TFc2cGc4VFJLK2JpSU84TWVVUTVwcER6bk5CbEVmVWtjaW13?=
 =?utf-8?B?VzlMR2h3RW5PZmtwTlBOSVdhOGZ3ZVNRMTVSbWhuS2pwV0Y0cW0rNEdOa3Va?=
 =?utf-8?B?SUdRNkxlNmROeWtYUFMra2pTb25iSzhzbW45eVp2ZWhuS0w0dExrVkltNStJ?=
 =?utf-8?B?MWM0LzBOWmFBNGdJUFl6dHRLTVBTdHpyeThqTUxURHlwZHo0QWxsa0c1Nmo0?=
 =?utf-8?B?MXArYmtNVVcrME1HRjVkMHlXYlB2Tkk5Mjh6RUt3czg2ZE5LVkFyWEFsTm1m?=
 =?utf-8?B?NmxhWDlBT1MwOExoeE01Sld5c3JiMi9CTWVyNFAzK0NXQ1hSVk1RT1RIeWpo?=
 =?utf-8?B?UWlrWkwrSmoyVnQ5bDE0KzBRTjZGWnlCMis0STZ6dDdUcUx0cU9zalZMTmNW?=
 =?utf-8?B?M2FXeWVrZndHNnpweUM4cm5JTjdGU2hqUlJKcm9GaG9RQkp2UlZRVXJkdzJE?=
 =?utf-8?B?WFRwQ3l1RnB2TnRSeUhhMzF4cmN4YWczSnY4NmoyWUd6ZUlsbUV3ZHdIbXNS?=
 =?utf-8?B?MjBldUw5ZHU0OEl2UVBxVHpwOTJndDV0eGxYc2ZRWWRhOFFqYUdNdml3NENG?=
 =?utf-8?B?OWNTSEs4WnlkTmhUQkl2dW5TdU5BODdubVlWdi9naVJNTlZUbmNFUEYyalZ4?=
 =?utf-8?B?OXF0M2h5M3gvL3lybnFhNWlVaHFRZFVaSUpnci9BTXNGUGk1K3BwRjA2MzdS?=
 =?utf-8?B?MDVoUlJhVUlsT3M5YjNvdnNGRlc1Y0orN0ZjSGhFTlVzRGVHZVBBMm04TUVp?=
 =?utf-8?B?VDhkL2dKOXAwb002YlhUME0yM0hVQnlFNmJ0ejVVbSt1cFZkdmpHRHVVQkpj?=
 =?utf-8?B?M0pnaU9CSjJEbzhBNjIyNVoydi9jaWhQQlRKM0pQMldRQW9YelFsTmRrZ25i?=
 =?utf-8?B?UkNrUnFYUEV2YWdPMENjNTF6bVFnRzJqSzNsRTBvQ0tncldLOEpkWlZTZ1hP?=
 =?utf-8?B?ZTJOWXVVWTg2eVRYVG02MnBlV2Jzc2NyUy9HUVhXS0ZZamNjYlNxUzVyTFBq?=
 =?utf-8?B?M21WY3hzc3A2eFdEdFVtZllCcVorVXZkdFFMWnJBYVozMS9iU2hudWx2RDIv?=
 =?utf-8?B?MVRtajhYb1Y0VWxpcVNSRmNyUTVBNHNyYStac3hndExsYnhqdTFmVHY3UkU0?=
 =?utf-8?B?MlJTNzY5QjVJeW1Gck9oTlp5N255M1c0QWk3SWE2UVlTZVVoNUs4elE3SEVo?=
 =?utf-8?B?Wi8xYTFmZmFqeWQreHFoK3NsQ3RoaXFjdDAwZS96L3YrLzRaS3l2MFFrcTU4?=
 =?utf-8?B?L3VnZUdyV1BsVTNZUmE5TTRxN3NuMUJ6ZTV3VEt0OEhyRWduTVdYcTFoeDh2?=
 =?utf-8?B?UHRGNHhRaFBkYjJNRy9WbXE3d2JIRmJ5emhpb1lTSDduVXlJOUV6QXRuVHhR?=
 =?utf-8?B?ZzRLTUZUcUVtaVYrc3lXZDVqa1dIZjhBeUhrNktUMFREOHpxRWhFbXI1Vkkx?=
 =?utf-8?B?RW1NV0dSc0tJL1FRYkZMVzUvcE1XUm50eE1PQXRXalF1OVF0TVNvUHN0a1d1?=
 =?utf-8?B?N0ZocXRpVmJsYU5maW1JR3pjNC9pQjZQNXl4d3U1ZXhZVURNcnJVMHVNdnVK?=
 =?utf-8?B?SE04TnFuL3BPdU45UGh4NFpmbXh2OTBYRkl4TVFmUTBpY25adHJPWFVMTlNW?=
 =?utf-8?B?RXJKbmkvdCtKUmRSOUV6N2pxbjl5VWdRcjZrVUo1dFQ1TGZQVVFlcFVXdUtt?=
 =?utf-8?B?T2FycU05WGw3VGMvQWR6S2F6blFOdXZhUGtlQkhCMUs4cGpQeGdBMnBPVStK?=
 =?utf-8?B?VFE4TktXMXlWRk9mRWw1UGtieGlZNUw1K0xBS05wbGxObGkwcU53VmVlZGQ4?=
 =?utf-8?B?NzhiUkFhaHlRbVRIUDMrR25XeHhvaFovdFpveElWRkNwZHJaeUJIRFdRbGhD?=
 =?utf-8?B?ZVI3dzlNVjRSY0RienRaRVBubVh0Q3BDVVROZXlmTVJIK281ZHdTeUZHMndt?=
 =?utf-8?B?dHBWTHBmaGt0cFBpZFBKRGM5elI4VWxob2NrcURITkV2amFndGVrWXVBMEhI?=
 =?utf-8?B?YXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d45d17b2-0e11-45c3-89cf-08db0e26ddd3
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 01:00:29.8106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: znoRG9P6fMMnyyiWP2FftN/4d6G3upavmdvLeBJe5YEjZyAdyZcY7h2GbvIxR9mTTuNSXmuRKecHiX3l8gFkdwtbxJQdtjcJX8VRoj7I9ZM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4602
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

I do not see a why two patch series are needed for
the resctrl fixes. It may make it easier for everybody if
it is handled as one patch series (with fixes first)?

On 2/8/2023 1:30 AM, Ilpo Järvinen wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> malloc_and_init_memory() in fill_buf isn't checking if memalign()
> successfully allocated memory or not before accessing the memory.
> 
> Check the return value of memalign() and return NULL if allocating
> aligned memory fails.
> 
> Fixes: a2561b12fe39 ("selftests/resctrl: Add built in benchmark")
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Missing your Signed-off-by?

> ---
>  tools/testing/selftests/resctrl/fill_buf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
> index 56ccbeae0638..f4880c962ec4 100644
> --- a/tools/testing/selftests/resctrl/fill_buf.c
> +++ b/tools/testing/selftests/resctrl/fill_buf.c
> @@ -68,6 +68,8 @@ static void *malloc_and_init_memory(size_t s)
>  	size_t s64;
>  
>  	void *p = memalign(PAGE_SIZE, s);

This may also be a good time to stop using an obsolete call?

> +	if (!p)
> +		return p;

Could you please return NULL explicitly?

>  
>  	p64 = (uint64_t *)p;
>  	s64 = s / sizeof(uint64_t);


Reinette