Message-ID: <05f6238e-4ad8-f30c-38da-74c343e6abb5@intel.com>
Date:   Mon, 13 Feb 2023 17:20:01 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.2
Subject: Re: [RFC PATCH 0/4] fpga: add initial KUnit test suite for the
 subsystem
Content-Language: en-US
To:     Marco Pagani <marpagan@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, "Wu Hao" <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-fpga@vger.kernel.org>
References: <20230203170653.414990-1-marpagan@redhat.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20230203170653.414990-1-marpagan@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXgwQzBRaWhFazR2czdJVklrQ1VVZFFFa2MrQkVuZW5RaWdXNmE1RDI0cW9H?=
 =?utf-8?B?Y2x1d2krQnZ6eWptY3lrdnBlMTV3b0h2M251NFlCcmhBNnBuK3I5ejF1MmdR?=
 =?utf-8?B?a3F3aFVmVkpUUHNoVlppVWpObTk5YUxXN3Z1RkdLS0hNd3did2lKRXIveUo2?=
 =?utf-8?B?cFl2c1pjZlh5d0wydkpNOXlEZkhScVV1b2p2QWRaY1AzaksyY0x2OWNObkU2?=
 =?utf-8?B?ZDR1dlRUb3Y2KzU1ckFqOUMyNkIrS1RtWGFuTnlRQlJqVWJuSi9pYXdJdEIx?=
 =?utf-8?B?TnNDSnh3cUxDalI1YzA1V1BiTDRZYkgyUStxWHNsbW93Ry9kdDFuOGFMY0Nl?=
 =?utf-8?B?ZFd5T0FKdHFVdGUrU1pucWhVa21TenQwbi9iU1hDbm5xZ0k4UWN3UU0rM1l1?=
 =?utf-8?B?bWtqTnl5M3l4M1loNEl1Uys4U0VnSWZMVWk2aEsvbXlnM3lzMS9PSVJhYVY4?=
 =?utf-8?B?S2V1NEw5ZHhvYVA5U09pY2FKdjJuWGt1NlJHK0VQZzZzZEJqOWhHVkF0emJR?=
 =?utf-8?B?MkhmYm5MeUlXVEppMGdReTh4ZThxZ2JZZDlvVU9iNFZ5dFhHSUJ3dnN1MUFV?=
 =?utf-8?B?RnZBVWIxaGU3MW9iV1pSa2QwcXFZd0p5RHJRRXhIQVN6LzlHbThBQlZKRnZO?=
 =?utf-8?B?cFRveEpZLzFtVXhLRWhMRGZ0V2VKMDBwWEhnemdjYzJ3VnlEeklweGNSdng1?=
 =?utf-8?B?bnM5cHU2TXd1V3lGQjZxUVRXN0pnSGNaRzMzdE1HUDE3MEJBemNHcncvbUVN?=
 =?utf-8?B?ZU1CYTZLWWRzMDA2KzFhOXp0eG1zQ1ZqcXprUzFWMFRnY0IwWlB0QlJxbTRV?=
 =?utf-8?B?UTN2OUVxbnpRb0tpKys2ZHd1b2dla2UrcnVOVzhpUDM4U3kxQm9uOWYzbDYw?=
 =?utf-8?B?b3BZVXcyU09mTHVra0NrRlQ4MlJpRWc4Z0xvSUZVRnJPd3RveGx4OVNPckd3?=
 =?utf-8?B?RytQZ29UOTcxd2MxUzBxbjRtRkF5amlGVy9ST1hTTnlqWXVpYk1MV2VIS2p2?=
 =?utf-8?B?eXAzWk9nNHBkZmRrc0FTWStYbHM3VEhxL1BLTEJhU1V2NldyaWc3anNBbDF4?=
 =?utf-8?B?UzBZMDNpUnRINWFPYXNkMHBlaGpCanFlRGRmS2tybzlrTlVHc2UvUFdpeXIx?=
 =?utf-8?B?YkkwVkZGY0srazFhU0RFTTVkbHhMRXN2dndBVzV4V1RhTmxqMU4wZW8vUklP?=
 =?utf-8?B?T2xROVJXU095a01Ka01QT2dSb1ptOVVONjg2SGFzTG5CZ1oyVjR3bURlRUww?=
 =?utf-8?B?WEQxdWI4Tjl6LzJ0MzJkckk5NkNSY3pya1FLajlweURjYlNGZHJSZUdQbnJ0?=
 =?utf-8?B?bWpLZzVmOHZKalJPR1ZNSXJiRmYxeDMrU0pONHpVTVBTaEV5V01naGROa0NZ?=
 =?utf-8?B?Yk02RURMVnR0WThWb0lmNUMyOHVabDRaTXlHc0tSZHdHcnVMb29xelNtemVz?=
 =?utf-8?B?RjQ0MGExYmlaTC9aV095TmV3QnBNSVJIaEJCeVNJNTFwN2FERU9KeUJMckVL?=
 =?utf-8?B?OFE1RGZsNGU1MzJxdnY3bEE1Y0VRODZLdW8zYU9zSTNNdk9kcmpBZ1dnTUdh?=
 =?utf-8?B?NWJWbm1LVi9mRGRvcFZNbk5ML2gvSFpsNzF6ejVyeUQ0NFpzSmQydmwvUnkr?=
 =?utf-8?B?Sld0TE8zQlgxK2FKN0FOME04Q0MvR25GUmxWd3dYRDljNG9yd1VKdVNIZEwz?=
 =?utf-8?B?aVdsU1ZtNmRGRTlwNVFObmRhNmhpWGYyenF5M0pQaGZIQmtwTFJNT3V1UkRy?=
 =?utf-8?B?ZkQrczk4TEUzZWVRSGRjbkIrcXdqS2I5UXIyRnNWN01TV3BkR3hWM2l4OUtC?=
 =?utf-8?B?blB1NjRwV3ExZmEraUw3QXhlaG94WU5SUU4wU2Vtajk3RHJyMytPMFZwVnBj?=
 =?utf-8?B?Q3N3SmJVeUtpNWNXQmNveWVRMnVoZG9ZYkY2bHg2K2syTGd4NStrb2tiS00y?=
 =?utf-8?B?cU1VVlA3RU02cXJpZmhlNEV0c0s2OFFabVlKVkNGRldnTk9CSDlHa0hWY1Yz?=
 =?utf-8?B?YlA3bm44OE10Tyt1a2UrOExsN0ZTNVM5Q3gwMndicDVzeGk5dnFGWTQxTVJy?=
 =?utf-8?B?NWFSa0wxeE1SbDM1OXNRQ1RmVmtOS0dNQ1I1ZDBWYW9NT2o2OXlmeDV4bnhW?=
 =?utf-8?B?MjN0VkpPdHVQQ0FZN1J1V25UVlhvK3NPd1FMckxPc0xFR21aZXczYjIrQ1pj?=
 =?utf-8?B?QlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0b4e66-879f-41e0-c0fc-08db0e299a8f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 01:20:05.5898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: koOGpBLxs2ELb85+6dZEtaK6jxIghC2I0Ugj7eEjU2MaDkqQQc0naQHYmwuzNSgYdTTPtosSfdJ7SvotF5Ba1bOFPHbwIiSZm1P+cEZgoVM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6340
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/3/23 09:06, Marco Pagani wrote:
> This patch set introduces a KUnit suite to test the core components
> of the FPGA subsystem. More specifically, the suite tests the core
> functions of the FPGA manager, FPGA bridge, and FPGA region.
>
> These components are tested using "fake" modules that allow
> observing their internals without altering the source code.
>
> The test suite can be run using
> [user@localhost linux]$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/fpga/tests
When I tried running these tests, I got an error until I created this file:

drivers/fpga/tests/.kunitconfig:
CONFIG_KUNIT=y
CONFIG_FPGA=y
CONFIG_FPGA_REGION=y
CONFIG_FPGA_BRIDGE=y
CONFIG_FPGA_KUNIT_TESTS=y

I think this file needs to be included in your patchset?

- Russ

>
> Marco Pagani (4):
>   fpga: add initial KUnit test suite
>   fpga: add fake FPGA region
>   fpga: add fake FPGA manager
>   fpga: add fake FPGA bridge
>
>  drivers/fpga/Kconfig                  |   2 +
>  drivers/fpga/Makefile                 |   3 +
>  drivers/fpga/tests/.kunitconfig       |   5 +
>  drivers/fpga/tests/Kconfig            |  15 ++
>  drivers/fpga/tests/Makefile           |   6 +
>  drivers/fpga/tests/fake-fpga-bridge.c | 214 +++++++++++++++
>  drivers/fpga/tests/fake-fpga-bridge.h |  36 +++
>  drivers/fpga/tests/fake-fpga-mgr.c    | 365 ++++++++++++++++++++++++++
>  drivers/fpga/tests/fake-fpga-mgr.h    |  42 +++
>  drivers/fpga/tests/fake-fpga-region.c | 186 +++++++++++++
>  drivers/fpga/tests/fake-fpga-region.h |  37 +++
>  drivers/fpga/tests/fpga-tests.c       | 264 +++++++++++++++++++
>  12 files changed, 1175 insertions(+)
>  create mode 100644 drivers/fpga/tests/.kunitconfig
>  create mode 100644 drivers/fpga/tests/Kconfig
>  create mode 100644 drivers/fpga/tests/Makefile
>  create mode 100644 drivers/fpga/tests/fake-fpga-bridge.c
>  create mode 100644 drivers/fpga/tests/fake-fpga-bridge.h
>  create mode 100644 drivers/fpga/tests/fake-fpga-mgr.c
>  create mode 100644 drivers/fpga/tests/fake-fpga-mgr.h
>  create mode 100644 drivers/fpga/tests/fake-fpga-region.c
>  create mode 100644 drivers/fpga/tests/fake-fpga-region.h
>  create mode 100644 drivers/fpga/tests/fpga-tests.c
>