IronPort-SDR: hkl3w7mxzrTxYsU1zqED1wbMTuPf8TKMg/0K38RtBHfKmg8Rq3ICuYkkBhcQRdjTaii2rg4Bfb
 psd9KJGva5Pg+CDdg8w1iP8bsnqD23oaOCjb+z0dbzQc4cCzlnaEIHSu3EcV8146ug2In7okDy
 huRJfpwJlPwLthZLRlS4+wloFSmS0tH++txvyK8HB2wDUETclkoKcyQrxjvwDb+SYL2fnyd6cf
 VK2808Gv4BWfC+BPv+4UNY2DAAgXMWHDrzota5uYIWU35GNHwdzUvvHCeVmEKjVXMkRFuWDGKt
 O6s=
IronPort-SDR: voyC81FWCS3kc4D+Ne35IZYnPK/yg2nAr3OXhWRLjB86NUa1xBqQrursQEXhNOsFOuIEXSqnVL
 XCPT/y1KfHAT6m7jmRR/7KCm0Y4EeUQzqOBH/dX0ivNEFfEuUXsj5G9WHno42Ta4LTk253FmAA
 98ky74XN8fUJeF75Wp5HXa+1dWfn651H3ET24BnL+Owe1f6MPPcVKPg9CtEJId29mrop+befd/
 haTVwyUYlP3ql7Dn58yotuL8uI8mNUnOgiNJA+cW3eddlPYrWPhLRrVUXDjtO1MF3qtnF8p4ap
 eac=
WDCIronportException: Internal
Message-ID: <b7626a3c-cf6b-45a2-0342-3bafa8090dcf@opensource.wdc.com>
Date:   Tue, 14 Feb 2023 10:33:23 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] ata: libata-core: Disable READ LOG DMA EXT for Samsung
 MZ7LH
To:     Patrick McLean <chutzpah@gentoo.org>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
References: <20230210215151.812839-1-chutzpah@gentoo.org>
 <dce110de-649d-cde8-9401-346675c95263@opensource.wdc.com>
 <20230213121745.2847a9ff@moya.linuxfreak.ca>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230213121745.2847a9ff@moya.linuxfreak.ca>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/14/23 05:17, Patrick McLean wrote:
> On Sat, 11 Feb 2023 12:11:48 +0900
> Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
> 
>> On 2/11/23 06:51, Patrick McLean wrote:
>>> Samsung MZ7LH drives are spewing messages like this in to dmesg with AMD
>>> SATA controllers:
>>>
>>> ata1.00: exception Emask 0x0 SAct 0x7e0000 SErr 0x0 action 0x6 frozen
>>> ata1.00: failed command: SEND FPDMA QUEUED
>>> ata1.00: cmd 64/01:88:00:00:00/00:00:00:00:00/a0 tag 17 ncq dma 512 out
>>>          res 40/00:01:01:4f:c2/00:00:00:00:00/00 Emask
>>>          0x4 (timeout)
>>>
>>> Since this was seen previously with SSD 840 EVO drives in
>>> https://bugzilla.kernel.org/show_bug.cgi?id=203475 let's add the same
>>> fix for these drives as the EVOs have, since they likely have very
>>> similar firmwares.
>>>
>>> Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
>>> ---
>>>  drivers/ata/libata-core.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>>> index 2ea572628b1c..c4c89d24f84c 100644
>>> --- a/drivers/ata/libata-core.c
>>> +++ b/drivers/ata/libata-core.c
>>> @@ -4045,6 +4045,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>>>  	{ "Samsung SSD 870*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>>>  						ATA_HORKAGE_ZERO_AFTER_TRIM |
>>>  						ATA_HORKAGE_NO_NCQ_ON_ATI },
>>> +	{ "SAMSUNG*MZ7LH*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>>> +						ATA_HORKAGE_ZERO_AFTER_TRIM |
>>> +						ATA_HORKAGE_NO_NCQ_ON_ATI, },
>>>  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>>>  						ATA_HORKAGE_ZERO_AFTER_TRIM },
>>>    
>>
>> Looks OK, but ATA_HORKAGE_NO_NCQ_ON_ATI is for PCI vendor ID 1002h. AMD
>> also has vendor ID 1022h. Did you check you adapter vendor ID & tested
>> this patch ?
> 
> We tested this patch, and it resolves the problem for us (we have been
> using it for several months).

OK. Thanks for confirming. Will apply in a little while. Thanks !

> 
>> -- 
>> Damien Le Moal
>> Western Digital Research
>>
> 
> 

-- 
Damien Le Moal
Western Digital Research