From:   "Rout, ChandanX" <chandanx.rout@intel.com>
To:     Jason Xing <kerneljasonxing@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "hawk@kernel.org" <hawk@kernel.org>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Jason Xing <kernelxing@tencent.com>,
        "Kuruvinakunnel, George" <george.kuruvinakunnel@intel.com>,
        "Nagaraju, Shwetha" <shwetha.nagaraju@intel.com>,
        "Nagraj, Shravan" <shravan.nagraj@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH net v4 1/3] ixgbe: allow to increase MTU
 to 3K with XDP enabled
Thread-Topic: [Intel-wired-lan] [PATCH net v4 1/3] ixgbe: allow to increase
 MTU to 3K with XDP enabled
Thread-Index: AQHZO2dLMmr9MYkhEkebCD9OTimy+q7Nv0hA
Date:   Tue, 14 Feb 2023 02:23:20 +0000
Message-ID: <MN2PR11MB40459B16A67226F780FE76D7EAA29@MN2PR11MB4045.namprd11.prod.outlook.com>
References: <20230208024333.10465-1-kerneljasonxing@gmail.com>
In-Reply-To: <20230208024333.10465-1-kerneljasonxing@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Khk6CR8oQwki4u+tiKTUmR9KZ1FNCqNfNftkfRGiO1qD2uwxD2srRjnpFQW3?=
 =?us-ascii?Q?X2O53PIrf1SNc55nPuPJ/s5kuGSx2wKkGymRND4GCyNFzTXVj+M5PSwi9Ek2?=
 =?us-ascii?Q?hsNPvsi+68lPIbUIBgXtONXAc6HfhTaOYvoRLmKqvGyygOHMHesIkAQvkv8x?=
 =?us-ascii?Q?C86ILQOnGL/t8NUVqSWyYUEicWXPFV8CIVsKrVOxMlEZ1zdYeq4dQyocHl1X?=
 =?us-ascii?Q?mYgA+/SOw38vNXVMen+BqlnV9vZ+7j6TDMVHnhAThKmV1Z7eXfe+rX9zltOB?=
 =?us-ascii?Q?dZoOKbl3jKu6icnSASMeGTHrUWl01JNRuVOrZJR7Adj0XEdvCBEHMiyCzKTO?=
 =?us-ascii?Q?uT/utc4tpJCDqCtrllZAHcj5LeM6+LHKazizPcY24Xivt6bex7tULYYTtrGk?=
 =?us-ascii?Q?E3NH2febegX+mtpYXKmkIhL9z8QhkxnJazfxankhTwTjDLYpfHggmgZzTbpm?=
 =?us-ascii?Q?6MqCRFQUyaUmmp8qOwPp5r3klqvVWaZ5fkcgkTdDA+Jj11wEG9LyZqFkN9NG?=
 =?us-ascii?Q?p3IV8XdwyA5p3hi7EoQaCDij5zN853Gko/C6oadLSsh6UZ4r+j/UczmmInGb?=
 =?us-ascii?Q?CjD3KDuf1A018WJ9V3POETDFNnaMDAbllQ63TRoxQMG+f4aN5/it+JBkBdQj?=
 =?us-ascii?Q?eDtth8E13k/q/Dxaz/i6aeku0l4sF4comkRNzvk9sZX6UmODn4i0CwtN1eXm?=
 =?us-ascii?Q?hwrVj5LCGy676qQm0H2RIvudD+n1RdfQrwlavLFA57k4rOa3fNi3BFuzVRK8?=
 =?us-ascii?Q?PPFIWh3oyJPSN7RMk56OhnbuFPWU2oeLzU7awcTl1WKmrpD9ukbmD3EJ3XQU?=
 =?us-ascii?Q?9En7UCzezG60T0VB1lXow9KZ2HTkaGc0QN1JOEmANGeET5AcY7s3f/Z+4Sdg?=
 =?us-ascii?Q?RUGz+01vT+1xls6+gS63EtikiJ0QrbQ4utSzTnhrkyVRxyEUdEIw8c7ExGtT?=
 =?us-ascii?Q?3dWRiGhrTywK5bIIj0tPUX3wvhr+YV9oEtL1ynMnBEXHXgT4ahaWT/rWnWDz?=
 =?us-ascii?Q?juuYkYou+BsXCK4nncmMK6HngGL/8fMBkjfUwOpxp0+QlPDwctkO9x9aJnFU?=
 =?us-ascii?Q?tGlVsxriLh2NIY+0xtwnuOLJ6oNS5TaL5B/nPorEKtS4+XYSqlOD8FESZ6i1?=
 =?us-ascii?Q?g1zj7FxVwL8h00I7N/dq2841mYbTSwVGeMLtc0NsAbrOtTofRiCbBX5prIKz?=
 =?us-ascii?Q?mb1xyLOS33P+oI3C+DKPEXo/Icnp7SV7yVhqPjpLMxvnapeHbB7rOlDgxPF5?=
 =?us-ascii?Q?N9zrmcPVF4Yb8TGIGLv9y944qtPbHhOI/ww7tSYTGR30CZVeVD3/7/3xOq0u?=
 =?us-ascii?Q?HA5YOLIkfq+MBnwgW9ViYHUZ3aWB8EwgypkTeTGVLb3SYc5MvzlWj7JYwKUg?=
 =?us-ascii?Q?PJqSlhxnFWHbShCtD4sh+se+J62+ombMeOTb5IJCMwnttF9xc+mYqR3jNmvd?=
 =?us-ascii?Q?PEQ5My0PRuVn7PIcUrSCR2JY3vWEZ1t5unI0GCldE9FMkwWpgze6/bYSuQE/?=
 =?us-ascii?Q?pC0ZKDsZG3R0PSJlz1bNhFMKT4jCRctGPpS+iKKkvufeSz6VWpwgPxspSMfW?=
 =?us-ascii?Q?T2FrO+WjmLvatw+XuEkpkT9LFbh9grg6uczKYjsy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4045.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51b59d54-6a83-4d6a-2a1f-08db0e32708d
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 02:23:20.2041
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9ZeIS49DKIJAU2dbNmh8+PCfU+ljY8JT2IML/6YOZyGwkQfXKFeh3lA0aHp578wRmqX5h0ViBIvmEQRFgkmEnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6327
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Jason Xing
>Sent: 08 February 2023 08:14
>To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
><anthony.l.nguyen@intel.com>; davem@davemloft.net;
>edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
>richardcochran@gmail.com; ast@kernel.org; daniel@iogearbox.net;
>hawk@kernel.org; john.fastabend@gmail.com; Lobakin, Alexandr
><alexandr.lobakin@intel.com>; Fijalkowski, Maciej
><maciej.fijalkowski@intel.com>
>Cc: kerneljasonxing@gmail.com; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
>bpf@vger.kernel.org; Jason Xing <kernelxing@tencent.com>
>Subject: [Intel-wired-lan] [PATCH net v4 1/3] ixgbe: allow to increase MTU=
 to
>3K with XDP enabled
>
>From: Jason Xing <kernelxing@tencent.com>
>
>Recently I encountered one case where I cannot increase the MTU size
>directly from 1500 to a much bigger value with XDP enabled if the server i=
s
>equipped with IXGBE card, which happened on thousands of servers in
>production environment. After appling the current patch, we can set the
>maximum MTU size to 3K.
>
>This patch follows the behavior of changing MTU as i40e/ice does.
>
>Referrences:
>[1] commit 23b44513c3e6 ("ice: allow 3k MTU for XDP") [2] commit
>0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
>
>Fixes: fabf1bce103a ("ixgbe: Prevent unsupported configurations with XDP")
>Signed-off-by: Jason Xing <kernelxing@tencent.com>
>---
>v4:
>1) use ':' instead of '-' for kdoc
>
>v3:
>1) modify the titile and body message.
>
>v2:
>1) change the commit message.
>2) modify the logic when changing MTU size suggested by Maciej and
>Alexander.
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25 ++++++++++++-------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worke=
r at Intel)