Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FDEC636CC for ; Tue, 14 Feb 2023 02:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231386AbjBNCiN (ORCPT ); Mon, 13 Feb 2023 21:38:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjBNCiM (ORCPT ); Mon, 13 Feb 2023 21:38:12 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DF9617179; Mon, 13 Feb 2023 18:38:09 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id D5BC224E2F8; Tue, 14 Feb 2023 10:38:00 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 14 Feb 2023 10:38:00 +0800 Received: from [192.168.125.110] (183.27.97.168) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 14 Feb 2023 10:37:59 +0800 Message-ID: <6a5ced8a-e230-a520-f05f-9972ea77f17b@starfivetech.com> Date: Tue, 14 Feb 2023 10:37:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v3 6/7] riscv: dts: starfive: Add initial StarFive JH7110 device tree Content-Language: en-US To: Conor Dooley CC: Conor Dooley , , , Palmer Dabbelt , "Rob Herring" , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , "Thomas Gleixner" , Marc Zyngier , Stephen Boyd , Michael Turquette , "Philipp Zabel" , Linus Walleij , Emil Renner Berthing , References: <20221220011247.35560-1-hal.feng@starfivetech.com> <20221220011247.35560-7-hal.feng@starfivetech.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.168] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Feb 2023 10:07:38 +0000, Conor Dooley wrote: > On Mon, Feb 13, 2023 at 05:41:02PM +0800, Hal Feng wrote: >> On Thu, 9 Feb 2023 11:11:51 +0000, Conor Dooley wrote: >> > On Thu, Feb 02, 2023 at 07:41:33PM +0000, Conor Dooley wrote: >> >> On Fri, Feb 03, 2023 at 02:56:41AM +0800, Hal Feng wrote: >> >> > On Wed, 1 Feb 2023 08:21:05 +0000, Conor Dooley wrote: >> >> > > On Wed, Feb 01, 2023 at 03:21:48PM +0800, Hal Feng wrote: >> >> > >> On Wed, 28 Dec 2022 22:48:43 +0000, Conor Dooley wrote: >> >> > >> > On Tue, Dec 20, 2022 at 09:12:46AM +0800, Hal Feng wrote: >> > >> >> FWIW, the deadline for getting material in for v6.3 has already passed, >> >> so you can send the next version of this series without waiting for >> >> clarification on the compatibles & ISA string. We should have plenty of >> >> time to get those fixed up before the series gets applied. >> > >> > Also, as it looks like the pinctrl driver is going to land in time for >> > v6.3, that leaves just this series and the clock driver required for >> > base support. >> > >> > In the original submission, you sent the clock driver and dt in the same >> > series & I think it might make the process a bit faster if you sent them >> > both together for the next version again. >> > >> > That way, both the drivers and dts can go together as their have an >> > inter dependence. >> > >> > That's my opinion anyway, will make trying to sequence things between >> > trees easier. >> >> Good idea. But how can I write the change log if we do so? Will it make >> the history confused? Thanks. > > I'm not sure what you mean w.r.t. history. > Both series are on V3 I think, so just make the next version v4 title it > something like "Basic clock, reset & dt support..." > For the changelogs, just mention you merged the two series again in > the cover letter & add the changelogs that you would have made for each > series to the cover as a single changelog. > Say somewhere in the cover that I suggested merging the series together > so that they could go via the same tree as the dt-binding headers are > required by both driver & devicetree. OK, I see. I will merge the clock patch series [1] and this DT patch series in v4. Thanks for your suggestions. [1] https://lore.kernel.org/all/20221220005054.34518-1-hal.feng@starfivetech.com/ Best regards, Hal