From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
CC:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Robin Murphy" <robin.murphy@arm.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Thread-Topic: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Thread-Index: AQHZPaM4X827KMb2AkC/Wtvslyhpl67NEuaAgAAlj4CAABH+gIAAItkAgAAafoCAAAb1gIAAAJAAgABvEpA=
Date:   Tue, 14 Feb 2023 06:26:25 +0000
Message-ID: <BN9PR11MB5276D28B4A4BF8DD3AF1A2828CA29@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230210230206.3160144-1-jacob.jun.pan@linux.intel.com>
 <20230210230206.3160144-3-jacob.jun.pan@linux.intel.com>
 <Y+pjTR80bnl9rMK1@myrica> <20230213103455.02f3ac37@jacob-builder>
 <Y+qR5zC8ZOkVphgv@nvidia.com> <20230213134402.194ed7fd@jacob-builder>
 <Y+rFW80DUHvf3hQP@nvidia.com> <20230213154345.0f76eea1@jacob-builder>
 <Y+rLqg66BBPsfsRK@nvidia.com>
In-Reply-To: <Y+rLqg66BBPsfsRK@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q35/+UEyWSCv7uEnkdD+vaAlHmCkLwNffvdNlkg2gGqc8M7lWJ9llbjxmLy4?=
 =?us-ascii?Q?z5+rW5Z7hsrCdj44V720FjffmZmk9B2dYgoBUKTUOE46nVQ2RUPRJm/ikv8G?=
 =?us-ascii?Q?hpvM7TAd60Q/IxuCZi4Gy3tsnJFjWx9pfKxNu4azKUUWe/5jSMTbH/7eQcij?=
 =?us-ascii?Q?Z9bDc7JQRpSReyhcchZnHaMAFsR57iwmUz8b9ANUHRts1vLVtmwOuspdFuxJ?=
 =?us-ascii?Q?rpjnlnsNqgjmlMJmj0sN8WQPMzXYTuitKm4A9f0OsDOcQtj5EI7JFKEzbixf?=
 =?us-ascii?Q?8X7InSL8Dg9YB/c4gpfjGLP/TjP9rEMIjn6toa4E99O30TJGqNEku0Ru3LLz?=
 =?us-ascii?Q?UaZ5JSLtFgTgfRBwXfzmXN5qniKiVvlR6Cg6ZXPGl9e1+OK+skk7VBd+8X7l?=
 =?us-ascii?Q?e2cvubEDZInl4R98zRb6wng5IRBmICDh+zUas3Dc26JaOU81jeAhM//MgxrS?=
 =?us-ascii?Q?0HuTKkR2nBL2lgTU7sA3TFwFHIFYi6RgHw5lkDP5AWCtLKrX3PN3D4AKisdx?=
 =?us-ascii?Q?HalnDYYJfXaOjEJnaTRh59oh9IHd4Pfqn5DgAscHQvNOeDVMamjoO7OoQxRU?=
 =?us-ascii?Q?w5FUPkC1fBp/dAbHUm5EW7oNdqkwTeLrd9vPG7Tq3rQqBFkYgccTbp42Yt1f?=
 =?us-ascii?Q?mVadBy+kwH2e96d/3wqHmwjGpdbaJjzdhmSInrsxqbg79N4bOyXqlxzpUM/K?=
 =?us-ascii?Q?rV+o8nzYnYVNln+jQtYJZrNUDYi6RZPbde/dVuXaQNoy4j3tbLyNusKVd/LD?=
 =?us-ascii?Q?um6uFyXX4zcP8Y6Ic2AAcZWk+ioayPP5axyQY0GyH/UQUvFZe/3Kj89sDXlT?=
 =?us-ascii?Q?2nmNCUOgcLs7p26bfXmBxw0ZyshYGP+sxx6jnxCjToqIfu4M7uuwoeMxCxlh?=
 =?us-ascii?Q?tTnvbfekQzauMUs6RGLRHFYscE6UTRb7/1HkwUzbM0ygFg8Q/hbpk7M3zdMx?=
 =?us-ascii?Q?+PD3MuF35wMCRUJX0uqvUdkgTsu5v9J+nXztMeMCEJxhTMIKSFm3om9fZZZP?=
 =?us-ascii?Q?XILRU3i+WfdRCSgwN903+erPOuJLrNHWadSLaICqVIvcwR0gk36Uj6iX6mby?=
 =?us-ascii?Q?UYTmpni74j4QQc3fydH+g3RFVsJ4UMutRei9eqqdtb1j8rY1LEsFD2ZeVlEn?=
 =?us-ascii?Q?USP0qbHTBmY3N/65qVp9lqOp57L13AeYKiFR5MHZ4lqNcsQxLnqyt3+Ftf+U?=
 =?us-ascii?Q?ByHP0jMYxaAXjbAPi44DfcRsB4Aq3DA28tWU9ZzcJJ0iP7RbOFPhvSiU839M?=
 =?us-ascii?Q?mKvb+U3haDC257YEINPHDRalZWdlQy8dcXC8+7AjaZb+5Q3U3waBUw6trZvo?=
 =?us-ascii?Q?nhaaSxGYZtlxTh29BqZhxZ/gZje63t1estj5k+nTqQzx/MwBOTuUQDKKsAMi?=
 =?us-ascii?Q?O/pJ+ePbwNBnHFz5vphFu5taHa9JQ2hIlwn7jXSq7uE7qm57zfwPcfesRT6C?=
 =?us-ascii?Q?R+/2yAWMS36HyJ8yOX2JPxhto/twascZ9R7RVpCRZnl2IIFHcoJnMjM7z/jL?=
 =?us-ascii?Q?MTx6cMcBxCrO5/arympFkkKppjz5s0xEVxly8kne1EpjpuLi+voaU0+3rm8t?=
 =?us-ascii?Q?cXiceUxTc6LURM+DcKeg2qTA4tI98+wbvFcT8LL7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 432b294a-d45f-4a52-b85f-08db0e546662
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 06:26:26.0219
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dNrfNTG1UA3gza+N4pINLZ4wqd0GOtHKU3EXlTJnRMQIMvy1RD/VrM+fDXj4prWVCa8+EnI/cIjHpFAVgfdoEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5599
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, February 14, 2023 7:46 AM
>=20
> > > So if a cgroup comes it is just a matter of putting charges in the
> > > right place which is auditable by looking at calls to attach pasid
> > > functions.
> > shouldn't we charge cg during allocation? Or it might be too early for
> > iommufd so we have to wait  until attach?
>=20
> We need to sort this all out. I would expect that iommufd will have an
> allocation API.
>=20

yes.=20

btw presumably iommu_global_pasid_ida should be move to iommu.c
since it will be used beyond sva.