Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756239AbXIFJnO (ORCPT ); Thu, 6 Sep 2007 05:43:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754920AbXIFJm6 (ORCPT ); Thu, 6 Sep 2007 05:42:58 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:50640 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbXIFJm5 (ORCPT ); Thu, 6 Sep 2007 05:42:57 -0400 Date: Thu, 6 Sep 2007 15:25:55 +0530 (IST) From: Satyam Sharma X-X-Sender: satyam@enigma.security.iitk.ac.in To: Mark Hindley cc: Steffen Klassert , Linux Kernel Mailing List , Linux Netdev Mailing List , Jeff Garzik Subject: Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug In-Reply-To: <20070904085331.GH5944@hindley.org.uk> Message-ID: References: <20070904081602.GB4241@newton.mathematik.tu-chemnitz.de> <20070904085331.GH5944@hindley.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 40 On Tue, 4 Sep 2007, Mark Hindley wrote: > On Tue, Sep 04, 2007 at 02:09:47PM +0530, Satyam Sharma wrote: > > Hi Steffen, > > > > > > On Tue, 4 Sep 2007, Steffen Klassert wrote: > > > > > On Tue, Sep 04, 2007 at 03:45:55AM +0530, Satyam Sharma wrote: > > > > > > > > drivers/net/3c59x.c: In function 'vortex_up': > > > > drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in this function > > > > > > This came in with the recently applied 3c59x-check-return-of-pci_enable_device patch > > > from Mark Hindley. I just compiled it on a PCI only machine so far, therefore I did > > > not notice the warning yet. > > > > Hmm, the .config I built with had PCI=y as well. Probably a compiler > > version difference -- Jeff also mentioned yesterday that some newer > > GCC versions fail to warn about uninitialized variables cases. > > > > Sorry, this is my bad. I have just checked: there is no warning with gcc > 4.2 or 4.1, but 3.3 emits the warning. This is a GCC bug (regression, actually, as you've found out) -- no two ways about it. Although different from the kind Jeff mentioned couple days back -- that was about wising GCC up to false positives and /not/ emitting warnings. But here a genuine problem was not complained about, so this is more serious. Do you plan to open up a bug at gcc.gnu.org/bugzilla/ ? Satyam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/