Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14459C61DA4 for ; Tue, 14 Feb 2023 08:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232087AbjBNIuz (ORCPT ); Tue, 14 Feb 2023 03:50:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjBNIus (ORCPT ); Tue, 14 Feb 2023 03:50:48 -0500 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12BA2366B; Tue, 14 Feb 2023 00:50:35 -0800 (PST) Received: from [192.168.1.103] (31.173.87.80) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Tue, 14 Feb 2023 11:50:23 +0300 Subject: Re: [PATCH v3 10/24] sparc: Remove COMMAND_LINE_SIZE from uapi To: Alexandre Ghiti , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H . Peter Anvin" , Chris Zankel , Max Filippov , Arnd Bergmann , , , , , , , , , , , , , , , , , CC: Palmer Dabbelt References: <20230214074925.228106-1-alexghiti@rivosinc.com> <20230214074925.228106-11-alexghiti@rivosinc.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <017f0b40-8021-8b3b-24d2-c70661b6b292@omp.ru> Date: Tue, 14 Feb 2023 11:50:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230214074925.228106-11-alexghiti@rivosinc.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.87.80] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 02/14/2023 08:31:15 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 175500 [Feb 14 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 504 504 dc137e1f9c062eb6c0671e7d509ab442ae395562 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.87.80 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.87.80 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.87.80 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 02/14/2023 08:34:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 2/14/2023 6:26:00 AM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/23 10:49 AM, Alexandre Ghiti wrote: > From: Palmer Dabbelt > > As far as I can tell this is not used by userspace and thus should not > be part of the user-visible API. > > Signed-off-by: Palmer Dabbelt > --- > arch/sparc/include/asm/setup.h | 6 +++++- > arch/sparc/include/uapi/asm/setup.h | 7 ------- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/sparc/include/asm/setup.h b/arch/sparc/include/asm/setup.h > index 72205684e51e..d1384ed92547 100644 > --- a/arch/sparc/include/asm/setup.h > +++ b/arch/sparc/include/asm/setup.h > @@ -7,7 +7,11 @@ > > #include > > -#include > +#if defined(__sparc__) && defined(__arch64__) Mhm, I don't think these two can be #define'd simulaneously... > +# define COMMAND_LINE_SIZE 2048 > +#else > +# define COMMAND_LINE_SIZE 256 > +#endif > > extern char reboot_command[]; > > diff --git a/arch/sparc/include/uapi/asm/setup.h b/arch/sparc/include/uapi/asm/setup.h > index 3c208a4dd464..c3cf1b0d30b3 100644 > --- a/arch/sparc/include/uapi/asm/setup.h > +++ b/arch/sparc/include/uapi/asm/setup.h > @@ -6,11 +6,4 @@ > #ifndef _UAPI_SPARC_SETUP_H > #define _UAPI_SPARC_SETUP_H > > -#if defined(__sparc__) && defined(__arch64__) > -# define COMMAND_LINE_SIZE 2048 > -#else > -# define COMMAND_LINE_SIZE 256 > -#endif > - > - > #endif /* _UAPI_SPARC_SETUP_H */ MBR, Sergey