Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D987C61DA4 for ; Tue, 14 Feb 2023 09:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbjBNJSr (ORCPT ); Tue, 14 Feb 2023 04:18:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbjBNJSI (ORCPT ); Tue, 14 Feb 2023 04:18:08 -0500 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 980038A7F; Tue, 14 Feb 2023 01:18:05 -0800 (PST) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1pRrRm-00053o-M8; Tue, 14 Feb 2023 10:17:58 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRrRl-000FyV-UA; Tue, 14 Feb 2023 10:17:57 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 7F4C2240049; Tue, 14 Feb 2023 10:17:57 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id EB8C0240040; Tue, 14 Feb 2023 10:17:56 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id A568D2CFA8; Tue, 14 Feb 2023 10:17:56 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 14 Feb 2023 10:17:56 +0100 From: Florian Eckert To: Jiri Slaby Cc: u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org, pavel@ucw.cz, lee@kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Eckert.Florian@googlemail.com Subject: Re: [PATCH 1/2] tty: new helper function tty_get_mget In-Reply-To: <5f67e2cf-f141-fde4-96de-28ceeeec9c06@kernel.org> References: <20230213140638.620206-1-fe@dev.tdt.de> <20230213140638.620206-2-fe@dev.tdt.de> <5f67e2cf-f141-fde4-96de-28ceeeec9c06@kernel.org> Message-ID: <00390b00bf50f42ff112ee8e31b88c8d@dev.tdt.de> X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate-ID: 151534::1676366278-1EFFD8D8-AC9FBD0F/0/0 X-purgate-type: clean X-purgate: clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> --- a/include/linux/tty.h >> +++ b/include/linux/tty.h >> @@ -419,8 +419,9 @@ void tty_unthrottle(struct tty_struct *tty); >> int tty_throttle_safe(struct tty_struct *tty); >> int tty_unthrottle_safe(struct tty_struct *tty); >> int tty_do_resize(struct tty_struct *tty, struct winsize *ws); >> -int tty_get_icount(struct tty_struct *tty, >> +int tty_get_icount(struct tty_struct *tty > > The robot already complained about this ^^^. > > Have you even tried to compile-test this? Sorry I made a rebase of the patch set. My mistake! I compiled and tested my changes against kernel 5.15 (OpenWrt). And it worked as expected. > >> struct serial_icounter_struct *icount); >> +extern int tty_get_mget(struct tty_struct *tty); >