Message-ID: <7198af95-8835-0f08-09f3-af18a6bcd566@collabora.com>
Date:   Tue, 14 Feb 2023 10:48:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH v3 03/11] iommu/mediatek: Improve comment for the current
 region/bank
To:     Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Hans Verkuil <hverkuil@xs4all.nl>, nfraprado@collabora.com,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        iommu@lists.linux.dev, mingyuan.ma@mediatek.com,
        yf.wang@mediatek.com, jianjiao.zeng@mediatek.com,
        Yunfei Dong <yunfei.dong@mediatek.com>,
        kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
        chengci.xu@mediatek.com, youlin.pei@mediatek.com,
        anan.sun@mediatek.com
References: <20230214031114.926-1-yong.wu@mediatek.com>
 <20230214031114.926-4-yong.wu@mediatek.com>
Content-Language: en-US
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230214031114.926-4-yong.wu@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 14/02/23 04:11, Yong Wu ha scritto:
> No functional change. Just add more comment about the current region/bank
> in the code.
> 
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
>   drivers/iommu/mtk_iommu.c | 31 ++++++++++++++++++++++++++-----
>   1 file changed, 26 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index d5a4955910ff..ab53edcb221f 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -197,12 +197,33 @@ struct mtk_iommu_plat_data {
>   
>   	char			*pericfg_comp_str;
>   	struct list_head	*hw_list;
> -	unsigned int		iova_region_nr;
> -	const struct mtk_iommu_iova_region	*iova_region;
>   
> -	u8                  banks_num;
> -	bool                banks_enable[MTK_IOMMU_BANK_MAX];
> -	unsigned int        banks_portmsk[MTK_IOMMU_BANK_MAX];
> +	/*
> +	 * The IOMMU HW may support 16GB iova. In order to balance the IOVA ranges,
> +	 * different masters will be put in different iova ranges, for example vcodec
> +	 * is in 4G-8G and cam is in 8G-12G. Meanwhile, some masters may have the
> +	 * special IOVA range requirement, like CCU can only support the address
> +	 * 0x40000000-0x44000000.
> +	 * Here list the iova ranges this SoC supports and which larbs/ports are in
> +	 * which region.
> +	 *
> +	 * 16GB iova all use one pgtable, but each a region is a iommu group.
> +	 */
> +	struct {
> +		unsigned int	iova_region_nr;
> +		const struct mtk_iommu_iova_region	*iova_region;
> +	};
> +
> +	/*
> +	 * The IOMMU HW may have 5 banks. Each bank has a indenpendent pgtable.

You got a typo here: `inde*n*pendent` - after fixing that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>