MIME-Version: 1.0
References: <20230213200519.889503-1-sergio.paracuellos@gmail.com>
 <20230213200519.889503-4-sergio.paracuellos@gmail.com> <f105c7a8-8821-1e7b-af46-13a46971db63@linaro.org>
 <CAMhs-H_Cd9F+UWWe+dAA89r_huX_srtsgjh1qus93nGehQN1AQ@mail.gmail.com> <7f2e556c-ee11-fe4e-f4d6-94c761f976d0@linaro.org>
In-Reply-To: <7f2e556c-ee11-fe4e-f4d6-94c761f976d0@linaro.org>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Tue, 14 Feb 2023 10:50:32 +0100
Message-ID: <CAMhs-H8Ls2oTZ8LYguCdizNZN3cUC8kKA4e_L6BD3C3cFDP0tA@mail.gmail.com>
Subject: Re: [PATCH v6 3/3] watchdog: mt7621-wdt: avoid ralink architecture
 dependent code
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
        linux@roeck-us.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        arinc.unal@arinc9.com, tsbogend@alpha.franken.de,
        p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-mips@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 14, 2023 at 10:33 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 14/02/2023 09:54, Sergio Paracuellos wrote:
> >>>       return 0;
> >>> @@ -143,6 +147,10 @@ static int mt7621_wdt_probe(struct platform_device *pdev)
> >>>       if (!drvdata)
> >>>               return -ENOMEM;
> >>>
> >>> +     drvdata->sysc = syscon_regmap_lookup_by_compatible("mediatek,mt7621-sysc");
> >>> +     if (IS_ERR(drvdata->sysc))
> >>> +             return PTR_ERR(drvdata->sysc);
> >>
> >> This should be the backup/error path for original code using syscon
> >> property. Looking up by compatible is really not portable/re-usable.
> >
> > I can change the code in the way you are pointing out here but...
> > Why is it not re-usable? Compatible is not supposed to be changed
> > since in other cases the DTB ABI will be broken. I am totally lost
> > about what is an ABI breakage, then.
>
> How do you use it on other platform?

I see, thanks.

So if I am understanding you correctly I have to maintain the
'mediatek,sysctl' phandle and use it in the first instance and if it
fails I have to use regmap_loopup_by_compatible() stuff, right?
Something like:

...

drvdata->sysc = syscon_regmap_lookup_by_phandle(np, "mediatek,sysctl");
if (IS_ERR(drvdata->sysc)) {
         drvdata->sysc =
syscon_regmap_lookup_by_compatible("mediatek,mt7621-sysc");
         if (IS_ERR(drvdata->sysc))
              return PTR_ERR(drvdata->sysc);
}

....

So in that case, we can add the new phandle to the bindings without
any kind of ABI breakage and we can use old dtbs using new watchdog
driver code.

I really hope I finally understood this properly. Thanks for your
patience, Krzysztof.

Best regards,
    Sergio Paracuellos

>
> Best regards,
> Krzysztof
>