Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5913C05027 for ; Tue, 14 Feb 2023 10:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232425AbjBNKaW (ORCPT ); Tue, 14 Feb 2023 05:30:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjBNKaU (ORCPT ); Tue, 14 Feb 2023 05:30:20 -0500 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE77233DA; Tue, 14 Feb 2023 02:30:18 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 5BD2C3FA55; Tue, 14 Feb 2023 10:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marcan.st; s=default; t=1676370617; bh=imb1OrlC2L4fhlGYWYO9ydzZ8X82aRztwsYTQ4mpkvs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=ZykmX5JNjkB3Y2h1/1GRLL+fijsmHvUBD60tmVyCD6yhG7QlsRKgHefVISM7GHE/u H5lgKlNbrTgU36J59T1YLh20aa53BBvWozzjTA55LHZMGqAiw/KeI4DSGl1I4Iac8F 0b9u30zROlSRIIggJjky6bgDkNzGv96+9mdfoW9wjXB14tKQ9efIaL+m3FgzrUHDcA gg7dIIIHDhfEy5HuJ+UlMJxsZGcoJw4iOzF0F6Aih6EtYjN6yzfn4nKVcs5Amr9Vp9 k2/qdJBTc+B7CW/7srsXmaLPd+jq7K7DDUX2hL2qjwiuCTouhJ2okV2BsnyzI10kZH Pjrn9j2ijK4mw== Message-ID: <65548ce6-d2d8-c913-a494-5ac044af2e35@marcan.st> Date: Tue, 14 Feb 2023 19:30:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] brcmfmac: cfg80211: Use WSEC to set SAE password Content-Language: en-US To: Arend van Spriel , Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Double Lo Cc: Sven Peter , Alyssa Rosenzweig , Linus Walleij , asahi@lists.linux.dev, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230214093319.21077-1-marcan@marcan.st> From: Hector Martin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2023 19.07, Arend van Spriel wrote: > + Double Lo > > On 2/14/2023 10:33 AM, Hector Martin wrote: >> Using the WSEC command instead of sae_password seems to be the supported >> mechanism on newer firmware, and also how the brcmdhd driver does it. > > The SAE code in brcmfmac was added by Cypress/Infineon. For my BCA > devices that did not work, but this change should be verified on Cypress > hardware. Do you mean the existing SAE code does not work on BCA, or this version doesn't? I assume/hope this version works for WCC in general, since that is what the Apple-relevant chips are tagged as. If so it sounds like we need a firmware type conditional on this, if CYW needs the existing behavior. - Hector