Message-ID: <9e9a2822-2b4b-a4e7-d430-e6233ff0c7f1@linaro.org>
Date:   Tue, 14 Feb 2023 11:46:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] interconnect: qcom: qcm2290: Fix MASTER_SNOC_BIMC_NRT
To:     linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc:     marijn.suijten@somainline.org, Georgi Djakov <djakov@kernel.org>,
        Shawn Guo <shawn.guo@linaro.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230103142120.15605-1-konrad.dybcio@linaro.org>
Content-Language: en-US
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230103142120.15605-1-konrad.dybcio@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3.01.2023 15:21, Konrad Dybcio wrote:
> Due to what seems to be a copy-paste error, the _NRT master was
> identical to the _RT master, which should not be the case.. Fix it
> using the values available from the downstream kernel [1].
> 
> [1] https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/scuba-bus.dtsi#127
> Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Gentle bump

Konrad
> Not tested on real hw.
> 
>  drivers/interconnect/qcom/qcm2290.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c
> index 0da612d6398c..a29cdb4fac03 100644
> --- a/drivers/interconnect/qcom/qcm2290.c
> +++ b/drivers/interconnect/qcom/qcm2290.c
> @@ -147,9 +147,9 @@ static struct qcom_icc_node mas_snoc_bimc_nrt = {
>  	.name = "mas_snoc_bimc_nrt",
>  	.buswidth = 16,
>  	.qos.ap_owned = true,
> -	.qos.qos_port = 2,
> +	.qos.qos_port = 3,
>  	.qos.qos_mode = NOC_QOS_MODE_BYPASS,
> -	.mas_rpm_id = 163,
> +	.mas_rpm_id = 164,
>  	.slv_rpm_id = -1,
>  	.num_links = ARRAY_SIZE(mas_snoc_bimc_nrt_links),
>  	.links = mas_snoc_bimc_nrt_links,