Message-ID: <c16693a0-d28f-b83f-e2b9-6e4451b68d7c@linaro.org>
Date:   Tue, 14 Feb 2023 12:06:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 05/16] dt-bindings: interrupt-controller: apple,aic2:
 Add apple,t8112-aic compatible
Content-Language: en-US
To:     Janne Grunau <j@jannau.net>, Hector Martin <marcan@marcan.st>,
        Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Mark Kettenis <kettenis@openbsd.org>
Cc:     asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Marc Zyngier <maz@kernel.org>
References: <20230202-asahi-t8112-dt-v2-0-22926a283d92@jannau.net>
 <20230202-asahi-t8112-dt-v2-5-22926a283d92@jannau.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230202-asahi-t8112-dt-v2-5-22926a283d92@jannau.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/02/2023 12:03, Janne Grunau wrote:
> The Apple M2 SoC uses AICv2 and is compatible with the existing driver.
> Add its per-SoC compatible.
> Since multi-die versions of the M2 are not expected decrease
> '#interrupt-cells' to 3 for apple,t8112-aic. This is seamlessly handled
> inside the driver.
> 

Thank you for your patch. There is something to discuss/improve.

>  
> -      The 2nd cell contains the die ID.
> +      The 2nd cell contains the die ID (only present on apple,t6000-aic).
>  
>        The next cell contains the interrupt number.
>          - HW IRQs: interrupt number
> @@ -110,6 +113,20 @@ additionalProperties: false
>  allOf:
>    - $ref: /schemas/interrupt-controller.yaml#
>  
> +if:

This should be under "allOf" (as next entry so "  - if:").

> +  properties:
> +    compatible:
> +      contains:
> +        const: apple,t8112-aic
> +then:
> +  properties:
> +    '#interrupt-cells':
> +      const: 3
> +else:
> +  properties:
> +    '#interrupt-cells':
> +      const: 4
> +
>  examples:
>    - |
>      soc {
> 

Best regards,
Krzysztof