MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 14 Feb 2023 12:13:40 +0100
From:   Florian Eckert <fe@dev.tdt.de>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        Eckert.Florian@googlemail.com
Subject: Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes
In-Reply-To: <b5dd2505-b087-b521-739b-ad4e97f3cbc5@kernel.org>
References: <20230213140638.620206-1-fe@dev.tdt.de>
 <20230213140638.620206-3-fe@dev.tdt.de>
 <b5dd2505-b087-b521-739b-ad4e97f3cbc5@kernel.org>
Message-ID: <f4f9b09939819709822cea2b328422b8@dev.tdt.de>
User-Agent: Roundcube Webmail/1.3.17
Precedence: bulk

Hello Jiri,

> 
>> +};
>> +
>> +static const char * const mode[] = {
> 

> This is not a wise name.

What do you suggest? For me, the 'mode' here was the most accurate.
It describes how the trigger should behave.

How about
* action
* switch
* tty_trigger


> 
>> +	[TTY_LED_CNT] = "TD/RD", // Trasmit Data / Receive Data
>> +	[TTY_LED_CTS] = "CTS", // CTS Clear To Send
>> +	[TTY_LED_DSR] = "DSR", // DSR Data Set Ready
>> +	[TTY_LED_CAR] = "CAR", // CAR Data Carrier Detect (DCD)
>> +	[TTY_LED_RNG] = "RNG", // RNG Ring Indicator (RI)
>>   };
>>     static void ledtrig_tty_restart(struct ledtrig_tty_data 
>> *trigger_data)
>> @@ -21,6 +38,74 @@ static void ledtrig_tty_restart(struct 
>> ledtrig_tty_data *trigger_data)
>>   	schedule_delayed_work(&trigger_data->dwork, 0);
>>   }

Best regards
-- Florian