Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932316AbXIFMfU (ORCPT ); Thu, 6 Sep 2007 08:35:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757970AbXIFMe7 (ORCPT ); Thu, 6 Sep 2007 08:34:59 -0400 Received: from mx1.redhat.com ([66.187.233.31]:47387 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756565AbXIFMe6 (ORCPT ); Thu, 6 Sep 2007 08:34:58 -0400 To: Jan Engelhardt Cc: James Pearson , "H. Peter Anvin" , Guy Streeter , linux-kernel@vger.kernel.org Subject: Re: 4096 byte limit to /proc/PID/environ ? References: <4474B7DB.8000304@moving-picture.com> <200605242029.k4OKTn9C031700@terminus.zytor.com> <447EF58C.6000605@moving-picture.com> <52dd17640708150954q798d137cn1b07739785917c5b@mail.gmail.com> <46C33700.1060605@zytor.com> <46D6CBED.4040301@moving-picture.com> <46DE6196.3050605@zytor.com> <46DEE0C9.1000402@moving-picture.com> From: Anton Arapov X-URL: http://people.redhat.com/aarapov Date: Thu, 06 Sep 2007 14:34:51 +0200 In-Reply-To: (Jan Engelhardt's message of "Thu\, 6 Sep 2007 14\:31\:28 +0200 \(CEST\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 35 Jan Engelhardt writes: > On Sep 5 2007 18:00, James Pearson wrote: >> >> OK, here is the patch (without the long line) against 2.6.23-rc5 - what else >> needs to be done to get it committed? > > Someone has to point out CodingStyle, so I'll ruin everyone's day now :) > Already pointed out! :) By Alexey Dobriyan. >> +static ssize_t environ_read(struct file * file, char __user * buf, > ^ ^ > be gone these spaces. > >> + while (count > 0) { >> + int this_len, retval; >> + >> + this_len = mm->env_end - (mm->env_start + src); >> + >> + if (this_len <= 0) { >> + break; >> + } > > Be gone, braces. > > > -- Anton Arapov, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/