Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8653FC61DA4 for ; Tue, 14 Feb 2023 11:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232676AbjBNL1j (ORCPT ); Tue, 14 Feb 2023 06:27:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232560AbjBNL1i (ORCPT ); Tue, 14 Feb 2023 06:27:38 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5847EEC50 for ; Tue, 14 Feb 2023 03:27:26 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D680F1FDE8; Tue, 14 Feb 2023 11:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676374044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A/E4T/3OgJIGaRj6v5QXzyfbS6qThchNv1eejOnY2zU=; b=UY+jWwu4L0V9mLO99cjbsGHFQvCfxHrL6X8+PdAlx3zzXowR0i5usO7EMuRxHCP/jZy2yA kQ7Ld5CLKwsJStp50IdSMtbNK/48RQnXAAMgyi7wh+ZAAA/ndGrTqfnvVC+5vY4/XogUnE vHvKZ1sqttfBkFAU628ZgilWDvhbCZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676374044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A/E4T/3OgJIGaRj6v5QXzyfbS6qThchNv1eejOnY2zU=; b=yuWfitZ20+sV1t3gvx48/EO39y8roFdOh9HHjzxQ7buJVp6HmhUs6bxa3OCMCAhVCzEg3c nCJwIExa90JFpWCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71A48138E3; Tue, 14 Feb 2023 11:27:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5TB+Ghxw62OxewAAMHmgww (envelope-from ); Tue, 14 Feb 2023 11:27:24 +0000 Date: Tue, 14 Feb 2023 12:27:23 +0100 Message-ID: <87sff88p2c.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Chi Cc: Jaroslav Kysela , Takashi Iwai , Tim Crawford , Stefan Binding , Meng Tang , Philipp Jungkamp , Kacper =?ISO-8859-2?Q?Michaj=B3ow?= , Gabriele Mazzotta , Yuchi Yang , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops In-Reply-To: <20230214103757.36624-1-andy.chi@canonical.com> References: <87y1p08rxp.wl-tiwai@suse.de> <20230214103757.36624-1-andy.chi@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Feb 2023 11:37:56 +0100, Andy Chi wrote: > > On HP Laptops, requires the same ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED quirk to > make its audio LEDs work. Well, this quirk is not only about mute/mic LED but rather mainly for enabling the Cirrus amp. I suppose the speaker didn't work without this quirk, too? Takashi