Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757653AbXIFMiu (ORCPT ); Thu, 6 Sep 2007 08:38:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755979AbXIFMik (ORCPT ); Thu, 6 Sep 2007 08:38:40 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:2274 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755488AbXIFMij (ORCPT ); Thu, 6 Sep 2007 08:38:39 -0400 From: Herbert Xu To: johannes@sipsolutions.net (Johannes Berg) Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170 Cc: herbert@gondor.apana.org.au, satyam@infradead.org, flo@rfc822.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, michal.k.k.piotrowski@gmail.com, ipw3945-devel@lists.sourceforge.net, yi.zhu@intel.com, flamingice@sourmilk.net Organization: Core In-Reply-To: <1189080575.28781.65.camel@johannes.berg> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev,apana.lists.os.linux.wireless User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Thu, 06 Sep 2007 20:36:32 +0800 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 23 Johannes Berg wrote: > > Hah, I suspected as much but didn't have a chance to look yet. I had > plans to replace that sub_if_list with an RCU list and not require the > lock there, but that's far off. Any ideas how to fix this? We can't > reject the master stop so we have to walk the list, I guess we'll have > to audit the other list manipulation places, I think they're all under > RTNL. Yeah I think they're all under RTNL too. So you don't need to take the lock here at all since you should already have the RTNL. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/