Message-ID: <1145ccf7-ffe0-533e-45ef-5576a54e4531@wolfvision.net>
Date:   Tue, 14 Feb 2023 12:41:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 2/2] dt-bindings: rtc: nxp,pcf8563: add
 quartz-load-femtofarads for pcf85263 and pcf85363
Content-Language: de-DE, en-GB
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Alessandro Zummo <a.zummo@towertech.it>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Riesch <michael.riesch@wolfvision.net>
References: <20230213095018.2255225-1-javier.carrasco@wolfvision.net>
 <12dc51e4-622e-4a26-8bde-2795d77ce36e.e0c24246-04d4-485f-8d5f-1cc8fbefd095.f8cc75cd-465e-4339-8415-7d994963b841@emailsignatures365.codetwo.com>
 <20230213095018.2255225-3-javier.carrasco@wolfvision.net>
 <Y+pur70KB7wWRCCi@mail.local>
From:   Javier Carrasco Cruz <javier.carrasco@wolfvision.net>
In-Reply-To: <Y+pur70KB7wWRCCi@mail.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWdwSmdEQjZReUplOVIyRFhqc2lUN0ozV3ZobVVPQktwODR1azlQeEpSTCtY?=
 =?utf-8?B?Y2QxUWlVWFVCUi9ZU3VwdWtEYmxweGFqZERaVUJtNXZ1Y00wWXdLWnQ5SHlN?=
 =?utf-8?B?QTdYUGRkQ3NYS2ptc3k0ck1Ub1hiQkQxYnc2RFhwM0ljUElUWFVtVGlDUHkz?=
 =?utf-8?B?Nmd2THFpeVFEQ1BuT2czY25RSHdENFk5dWRta3lGNWEzeFRERUk3NUpocm1k?=
 =?utf-8?B?aGptYlF2cG95Q0QxMk1kbTMzMTNLR2FKTkhjdlFCTFZIMG1YcXpzODA5RHVN?=
 =?utf-8?B?Z2pGY0o0VHhlTFJEbVNzV0hsSmV6M3lLT0EyaWxTS09McG9hWHUvUXZHNkZD?=
 =?utf-8?B?RWFtNkpjZmY0M25HMDVVU1dkUmIzaTdQL29ORkhaK1VKNjI3ZytPdm5oRk9Q?=
 =?utf-8?B?eFpHSFI0WnloT045YUdzamZxdDBORTIvUGNYOTFKRXdUSlcvSVVsb05GZG15?=
 =?utf-8?B?OGxPMitRNUZFM0w5OWFlZlJTcUcvekk4QXhINXJ0Y2YwSmoxbDg1c05EbTFV?=
 =?utf-8?B?UjdFV05GRWdENEVlRlpDdnFRd2hNYlRCL1dDMzdvemJZSisvakVBR1EyMlhL?=
 =?utf-8?B?R3RDYWdES01QbHdEYWg0OXQ5TzlVUmtvVG44YkNIb2RWRzhYMjFLNjN3Tk9x?=
 =?utf-8?B?bHpNUGxZSzZsYmdESXhjVWxDOUNEd05GaGtoc2tpZFM3YzBtOXVlc0NoVUpI?=
 =?utf-8?B?L2lKOTM2L0ZsUjJicmJUMzg1RW5uNUFRcXhGYUx0MUFwQ2JIaVNvdCtwbE1k?=
 =?utf-8?B?MGhZWnlZZ0hCa3BOT1g3T3BCY0IycEZIZzZPenZzRGpvZWZGRDJJaXhvT3NF?=
 =?utf-8?B?R1VFRHl1dTVNOGVyV0RyRGJVNkJtbnZwdGRxaENOamswVnU1b1o3MEFCSGNM?=
 =?utf-8?B?RUkvTWhzbFFPVHFOQUt2RUgxMFROaGtLL0tia1pEeHBNWVp3K2lHM0hTZmxQ?=
 =?utf-8?B?TjI1ellIYlBtbmJNSHhZaEJtS3B2cXk3NHYwWW94em5nZUpsVlZaTjk0Z3lu?=
 =?utf-8?B?UVlIV0xyQWN5Wm4vc0xBaSs2a0JSYVlNMnY2Y0FLYnF5a2ZDbnNOOWliejMw?=
 =?utf-8?B?bUs3MHdHRXgrY2ltRUcxM0VnWDQ2a0swaDg0ZEVkSkRieXE2QkZhY1pESnpT?=
 =?utf-8?B?ZUk4bVN6Yml0UmlCTWszV1d1SzBpT2dVcVdPQWFkcVpac2dYV2JLemtzWnA1?=
 =?utf-8?B?Y0d0dlMwek5KQ3pFOFIrdExmMU1ab1NhbG5ka3hDR1c5dGl4eGZoRDl4eGsy?=
 =?utf-8?B?Z0dBUVM1anA4bmFkNDZ1VmVFUnRzNTJZRlJlbENyNE9XdzdIYVErOCtxUGlj?=
 =?utf-8?B?MWU5V2Q0YnZ1ZG9USDVNVHRRTnZxa2ZZU2ZseTFkM2ErMzhaOGJheE11RUU3?=
 =?utf-8?B?SkpoVWp2Mm1GeFlsUGdDaktaVUxRelNEbGtxajZCWnJ2UWNVSTdkTDRaSHd5?=
 =?utf-8?B?MTJSN2M5MUtMSGZ6eTFMMnBaMUZ1UG9vM1Fmd1NQTzVGdGJHZXJsY0VzNk0v?=
 =?utf-8?B?dUlocTZKWFFGb1RvWFJpMFRseWdNbE04cnFvbDMvZUJ6TzhTc25ydnp1R2Nr?=
 =?utf-8?B?aWFhdUxrcE5VRFo5a25jRHhxT0NXMjFBa05qamRhL3I0cXZETXd3ZXFQMDhK?=
 =?utf-8?B?L0FORWMvQUhBNXRLUi93YzU1Z0FOUmJrREs3c08xVEFBUHozT3FnOVFvaUFV?=
 =?utf-8?B?SzF0Y09QSVVHS29JZHo4UlRhRU5pcWVVMlovUjdLRDE4bGlFZW0rMGc1SC9t?=
 =?utf-8?B?M0lkRVZXeC9xYXp4Nys0bDBZcGsxNTVEWVpnSEFqck9hL0lLSDhTdUpIek0z?=
 =?utf-8?B?UXltbGJYUVQrVUxhN1V5Zk9vWm1JNVpqS1ZLbWtSb2g3clRnS2FKVEZlV1ox?=
 =?utf-8?B?VDdhaHZ1aUlZRFlsMkxWZjFPT1pWY0JJMk5uNkZQc01NUHpYSkFUelBPOVNP?=
 =?utf-8?B?VVk5N3ZhajJIL0lXYjh1elBROFFHN3NuTE00VWxVYXRNMFNiM2FPaXc4Ujlz?=
 =?utf-8?B?SkVEUkdCdFVoQ05ndHplaDBIRkNhR3ljb2ZoSEdqYjlBSEozSGhZM1pwemp2?=
 =?utf-8?B?Mkh2S2VPSEdoYWw3SXV6NEZLS0xKM3I3KzIwZFJGTitaZFRyZkVpbmgwZW1F?=
 =?utf-8?B?Mnk5c3dNYnF2c2FWVk9ZckdkZGxvUmlBMUR5QmJsd2krK1IxdzA4S3FhK2kv?=
 =?utf-8?Q?GRZjmaFzGMH/I/uxlnTwYR4=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e406016-bd17-4f0c-689c-08db0e8059e7
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 11:41:03.2341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uKG278yhuAF1aYo0+LAjcE9D+WCnctl3uInKXUm3vFtuZpuFdXGyS2uD36kCmsDGVegO9nFUrJZIcV9FJTnQfnzYmW9bbdxLS9fNwzllWYw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5336
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

Sorry for the previous mail in html format with annoying signatures.

> Hello,
> 
> Krzysztof's confusion is because you are changing the binding for
> nxp,pcf8563 while adding support for the nxp,pcf85263/nxp,pcf85363

If that is ok I would propose a new bindings file nxp,pcf85363 for 
pcf85263 and pcf85363 in the next version.

Best regards,

Javier Carrasco

> 
> On 13/02/2023 10:50:18+0100, Javier Carrasco wrote:
>> These RTCs are handled by the pcf85363 device driver, which now supports
>> the quartz-load-femtofarads property.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
>> ---
>>   .../devicetree/bindings/rtc/nxp,pcf8563.yaml  | 20 ++++++++++++++++---
>>   1 file changed, 17 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
>> index a98b72752349..aac7f7565ba7 100644
>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
>> @@ -9,9 +9,6 @@ title: Philips PCF8563/Epson RTC8564 Real Time Clock
>>   maintainers:
>>     - Alexandre Belloni <alexandre.belloni@bootlin.com>
>>   
>> -allOf:
>> -  - $ref: rtc.yaml#
>> -
>>   properties:
>>     compatible:
>>       enum:
>> @@ -37,6 +34,23 @@ properties:
>>     start-year: true
>>     wakeup-source: true
>>   
>> +allOf:
>> +  - $ref: rtc.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - nxp,pcf85263
>> +              - nxp,pcf85363
>> +    then:
>> +      properties:
>> +        quartz-load-femtofarads:
>> +          description:
>> +            The capacitive load of the quartz(x-tal).
>> +          enum: [6000, 7000, 12500]
>> +          default: 7000
>> +
>>   required:
>>     - compatible
>>     - reg
>> -- 
>> 2.37.2
>>
>>
>> Javier Carrasco
>> Research and Development
>>
>> Wolfvision GmbH
>> Oberes Ried 14 | 6833 Klaus | Austria
>> Tel: +43 5523 52250 <tel:+43552352250> | Mail: javier.carrasco@wolfvision.net <mailto:javier.carrasco@wolfvision.net>
>>
>> Website: wolfvision.com <www.wolfvision.com>
>> Firmenbuch / Commercial Register: FN283521v Feldkirch/Austria
>>
>